Giter Club home page Giter Club logo

Comments (5)

hvt avatar hvt commented on June 8, 2024 1

Hey @alexellis , sorry about meddling with the issue template, thought I only left out bug report related info.

Yeah, I initially started with a patch / PR, before noticing the contributing Markdown. That's where I was pointed to first asking in an issue if all was good ;).

But yes, now that I there's a positive response, I'll work on gold plating my patch.

from arkade.

alexellis avatar alexellis commented on June 8, 2024

Hi @hvt sure, we would welcome it.

Unfortunately, you changed the questions in the issue template and that means I have to ask you a question you deleted, but are you going to contribute this yourself?

Edit: it looks like you have a patch, please make sure you add unit tests.

A good way to get your PR right, without creating too much work for the maintainers is to review the contributing guide, fill out issue and PR templates properly, without delete from them 😄 and test your work.

https://github.com/alexellis/arkade/blob/master/CONTRIBUTING.md

An example of a good PR that was quick to get merged - #842

Alex

from arkade.

alexellis avatar alexellis commented on June 8, 2024

One question we have is "Are you willing to work on this?" 🙂

from arkade.

hvt avatar hvt commented on June 8, 2024

I am :).

from arkade.

alexellis avatar alexellis commented on June 8, 2024

This has now been added. Thanks for the suggestion.

Feel free to update any cert-manager docs with arkade get cmctl etc.

from arkade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.