alexei / python-adapters Goto Github PK

i.e. if editable=False, won't update existing instance

The point is to not have to wonder whether the source object is a dict or an object when accessing the atrribute.

It should default to * so it doesn't break existing code.

Might be confusing as is i.e. one might think it refers to an actual (ORM) model

The BaseField's get_attribute method is reliant on the data provided to the field and so, in the case of all the fields except AdapterMethodField(where get_attribute is overridden), we can get into some nasty issues, for example:
if the data is etree type(from lxml), when we put a CharField() on our custom Adapter, the get_attribute method will think that isinstance(obj, collections.Iterable) is True and such, will try to int(attr) which in our case is a string, <field_name> and it will crash silently(the get_attribute will return undefined because the exception is caught and in the end it will prompt the error message down the line as " Required value not found for field <field_name>. Provide a default value. " which is confusing).

I.e. a field having omitempty=True would not be set on the destination object