alexchantastic / alfred-ip-address-workflow Goto Github PK

It would also be great to display the IP location, maybe in the line below the IP. Some services offer the location back. Here is one example: http://ip-api.com/json

For as long as I can recall (a year or more), the workflow doesn’t return my correct external IP.

It comes back with the following:

I am located in New Zealand. That IP address is from a broadband connection on the COX network, in the USA.
https://www.ip-tracker.org/lookup.php?ip=184.189.4.152

Any suggestions as to why it doesn’t come back with my correct external IP?

ifconfig.co isnt working, i recommend change to ifconfig.me/ip ...

I have multiple local addresses, the debug console gives me this:

[2018-08-20 13:20:24][ERROR: input.scriptfilter] JSON error: Unescaped control character around character 54. in JSON:
{"items": [

	{
		"title": "Local IPv4: 192.168.141.91
192.168.143.155
169.254.241.90",
		"subtitle": "Press enter to paste or ⌘C to copy",
		"arg": "192.168.141.91
192.168.143.155
169.254.241.90"
	},

	{
		"title": "External IPv4: xxx.xxx.xxx.xxx",
		"subtitle": "Press enter to paste or ⌘C to copy",
		"arg": "xxx.xxx.xxx.xxx"
	},

	{
		"title": "Local IPv6: fe80::c6f:4428:7e31:5e23",
		"subtitle": "Press enter to paste or ⌘C to copy",
		"arg": "fe80::c6f:4428:7e31:5e23"
	},

	{
		"title": "External IPv6: xxx.xxx.xxx.xxx",
		"subtitle": "Press enter to paste or ⌘C to copy",
		"arg": "xxx.xxx.xxx.xxx"
	}

]}

Probably need to replace \r\n with , ?

It would be great to see which network interface is associated with each IP.

In terms of formatting, I'm thinking something like:

Local IPv4 (en0): 192.168.0.1

If the computer has multiple IP's (in my case because of virtual machines running on my computer) the workflow just fails. I've fixed it in a quite hacky way for now by replacing the local ipv4 line with

ifconfig | grep 'inet ' | grep -Fv 127.0.0.1 | head -n 1 | awk '{print $2}'

When I get time i'll get on doing a nicer fix and creating a pull request if no one bets me to it :)