alessandro-barbieri / node-overlay Goto Github PK

to build rollup you need rollup and some of it's plugins
to build the plugins you need rollup and other plugins

it's a complete madness

I can't bundle the plugins with the eclass because they are missing package-lock.json and they use pnpm instead of npm

Some packages depends on submodules not packaged elsewhere but as a folder in the main project (e.g. language-* from atom)

Here are 3 ways of packaging I've been thinking of:
one ebuild for submodule
pros: no need to change the eclass
cons: ebuild version and tarball version aren't the same, no way to check for updates

let npm manage them
pros: only one ebuild
cons: difficult to put the documentation where it should be, the eclass must take care of package.json and list only the submodules in it before calling npm (currently the eclass clear the dependencies inside package.json). Complex bash/jq scripting needed

manually install the submodules
pros: one ebuild only
cons: Complex bash scripting needed, in the ebuild we need to cd module/folder then run the configure compile install functions

node.eclass cant handle an ebuild without .tgz files in DISTDIR and will fail.

Relevant error:

npm ERR! code ENOENT
npm ERR! syscall stat
npm ERR! path /var/tmp/portage/dev-node/app-builder-bin-3.4.2_p20201214/distdir/*.tgz
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, stat '/var/tmp/portage/dev-node/app-builder-bin-3.4.2_p20201214/distdir/*.tgz'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

Line 149-152 from node.eclass in function node_src_compile:

    for file in "${DISTDIR}"/*.tgz; do
        "${NPM}" cache add "${file}" || die
        addfile "${file}" || die
    done

This can be worked around with first checking if the files exists.

    # Check that files exists before
    if ls "${DISTDIR}"/*.tgz &> /dev/null; then
        for file in "${DISTDIR}"/*.tgz; do
            "${NPM}" cache add "${file}" || die
            addfile "${file}" || die
        done
    fi

Full build.log
npm debug log

webtorrent-desktop is an electron app & uses babel.

This issue is just making a note that I would like to see it added to this overlay at some point