aleksandrhovhannisyan / eleventy-plugin-code-demo Goto Github PK

Hello Aleksandr,

I'm trying to install your plugin with Eleventy 2.0.0; Node v16.13.0; NPM 8.1.0; Windows 10
and I get:

[11ty] Eleventy CLI Fatal Error: (more in DEBUG output)
[11ty] 1. Error in your Eleventy config file '.eleventy.js'. You may need to run `npm install`. (via EleventyConfigError)   
[11ty] 2. Cannot find module 'lodash/escape'

So I tried npm i --save lodash.escape (successfully installed), and also npm install but still the same error.

Not really a bug from your plugin but really a bug on one of your dependency @minify-html.
Here is the issue and there's a working workaround in the comments.

I thought you should know about it. Maybe you'll feel like adding a disclaimer or switching library or whatever.

This plugin is working vey well. But I do have some questions, though.

In title required for accessibility Nunjucks variables do not work (but I can do without it, not so important)

How can I place allowfullscreen into iframeAttributes? It gives me EleventyConfigError allowfullscreen is not defined (via ReferenceError) . Also, how to put loading="lazy"?

Entities (" < >) are displayed in the output (_site) instead of quotes, opening and closing tags. Maybe it does not matter as browsers read them anyway?

Why output is not properly minified in some lines (see those starting with /assets/img/audio-player)?

Inside img tag class=full height=160 loading=lazy src=/assets/img/audio-player/landscape-680.jpg width=680 have no quotes, or entities, at all. And this may be a problem as I need to serve a fallback jpeg image to browsers who need it, and size and lazy loading to all anyway. No quotes also on a href at the beginning: class=full and href=https://w.soundcloud.com/player