aldaviva / winampnowplayingtofile Goto Github PK

Hey!

Amazing plugin, thanks for this! I often play mixes and it would be incredibly useful to be able to show the current time in the given track. Could this be added?

Hello,
I want to use this plugin for my stream, but i stuck at text part.
I installed the plugin, it make text file at folder i choice but dont write anything in file.
I tryed to change template and it write only thing i write in settings by myself like "-" between artist and song name.
Can you give me any tips where is a problem?
I use winamp 2.95 and windows 7 x64

Since AIMP pretty much can run Winamp plugins, is there going to be an easily installable AIMP version ("easily installable" as in "using the "install" button inside the Plugins window)?

In #11, I made the plugin output the empty album art file (PNG in installation directory, falling back to 1x1px black PNG) when Winamp was stopped/paused/exit, not just when playing a song with no album art, so that OBS would stop complaining.

Users may want different images when the song has no album art compared to when Winamp is stopped. Currently, it is always the same emptyAlbumArt.png or 1×1 black PNG in both cases.

Another possibility not covered by this issue is restoring the ability to delete the output file when Winamp was stopped, as it did in 1.1.0. I'm not sure if this would be useful or desired. If so, it would probably be a boolean setting with a checkbox in the plugin settings UI backed by a registry value, similar to the other settings. It could also be opt-in by creating stopped.png, and if it's not there, fall back to the old behavior of deleting the file.

The test project was failing to compile when I was working on #6 due to the following error, so I skipped that project by explicitly building the C++ plugin project instead of the entire solution.

3>D:\a\WinampNowPlayingToFile\WinampNowPlayingToFile\Test\Test.csproj(155,5): error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\xunit.core.2.4.1\build\xunit.core.props.

I have since updated the Test project to xUnit 2.4.2, the latest stable version available, and tests do compile and pass on my development computer.

It may be worth trying once again to get the tests running in CI, and maybe add coverage reporting too.

Steps

1. Use the insertion menu to insert the If pattern into the template text.
2. Replace the Artist variable with a different variable, like Year. Do this by manually typing Year one character at a time.

Expected

The live preview should just use some dummy value such as Y or null when rendering that placeholder, or maybe replace the rendered text with a helpful message like invalid template. This can apply to both the preview as well as the contents of the text file.

Actual

A KeyNotFoundException is actually thrown:

System.Collections.Generic.KeyNotFoundException: The key Y could not be found.
   at Mustache.Scope.Find(String name, Boolean isExtension)
   at Mustache.PlaceholderArgument.GetValue(Scope keyScope, Scope contextScope)
   at Mustache.ArgumentCollection.GetArguments(Scope keyScope, Scope contextScope)
   at Mustache.CompoundGenerator.Mustache.IGenerator.GetText(TextWriter writer, Scope keyScope, Scope contextScope, Action`1 postProcessor)
   at Mustache.CompoundGenerator.Mustache.IGenerator.GetText(TextWriter writer, Scope keyScope, Scope contextScope, Action`1 postProcessor)
   at Mustache.Generator.render(IFormatProvider provider, Object source)
   at WinampNowPlayingToFile.Presentation.SettingsDialog.renderPreview()
   at WinampNowPlayingToFile.Presentation.SettingsDialog.TemplateEditor_TextChanged(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnTextChanged(EventArgs e)
   at System.Windows.Forms.TextBoxBase.OnTextChanged(EventArgs e)
   at System.Windows.Forms.TextBoxBase.WmReflectCommand(Message& m)
   at System.Windows.Forms.TextBoxBase.WndProc(Message& m)
   at System.Windows.Forms.TextBox.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

The plugin doesn't delete the cover art file when playback is stopped, and doesn't replace it with the mentioned square if no cover art is found.

I changed the files in the settings and tested the plugin. While everything else works, the placeholder feature and the removal from the files after playback doesn't work.

I don't like checking dependencies into repos, but I think it's the best option here because

• Daniel15.Sharpamp.dll does not exist in NuGet
• It also does not exist in the releases or repo files of Daniel15/Sharpamp
• It's not hosted on any web server as far as I can tell
• We can't run the installer on the build machine because it crashes on a policy lookup in the registry if .NET Framework 2.0 is not installed, and it's definitely not installed on the GitHub Windows Server 2022 runners. Faking out the registry seems very difficult because it uses the found frameworks to install DLLs into the GAC. There isn't even a way to click the Ignore button on this error, because Inno Setup's /SUPPRESSMSGBOXES flag always picks the Abort option.

When I try to update album art for the now playing PNG to load them instead of showing the art it just displays a black box and i update the art in Winamp. how do i fix this so it will show all my album art after i update it?

Hello,

I've since a few days been playing your your plugin and it's the best one I can find for this job. So great job!

However that said if Winamp isn't running when I launch OBS it'll give me the missing files pop up they implemented for missing resource files. Is it possible for the plugin to wipe the content of the txt and save a blank/transparent png if no track is playing and when you exit Winamp?

For the time being I've added "--disable-missing-files-check" at the launch paremeters for OBS but then it'll disable the feature as a whole. Maybe there's also another solution as well I'm unaware of.

Thanks in advance!

Plugin has problems when playing songs from SOME Web Stations online (not all).
Errors will popup infinitely from the station while it's playing.

`Unhandled exception while updating song info on song change:
System.ArgumentException: URI formats are not supported.

at TagLib.File.Create(IFileAbstraction abstraction, String mimetype, ReadStyle propertiesStyle)

at WinampNowPlayingToFile.Business.NowPlayingToFileManager.extractAlbumArt()

at WinampNowPlayingToFile.Business.NowPlayingToFileManager.update()`

Steps

1. Start with an empty text template.
2. Insert a placeholder into the text template, such as Artist.
3. Insert another placeholder, like Title.

Expected

The template should be {{Artist}}{{Title}}.

Actual

The template is {{Title}}{{Artist}} because the insertion point stayed at position 0 after step 2, so {{Title}} was prepended instead of being appended.

NowPlayingToFile is great and works really well, but it would be nice to also be able to include the track number of the currently playing track (the contents of the "tracknumber" tag) on the album in the generated text file?

Thanks. :)