alcalzone / iobroker-react Goto Github PK

While moving around the house/town, maybe even when the site goes into the background, the websocket can get disconnected. The reconnect usually works fine, but any updates which happened in the "downtime" won't show up in the page. Subscriptions are restored automatically (probably here), so at least when the value changes again, it will show correctly. This affects at least useIoBrokerState(), but probably also useIoBrokerObject().

I looked into various ways to fix it:

In ioBroker/socket-client, there are various instructions to ensure that loadData() is only triggered for the first connect. Which probably makes sense because that client seems to be mostly stateless. Sure, system config could have changed between disconnect and reconnect, but apart from that there doesn't seem to be any "caching" of objects and values. So there is nothing that could become outdated.

In contrast to that, the hooks remember the last state/object data. Basically useIoBrokerState() would just need to call loadInitial() again after a reconnect. But for that, the Connection would need a way to subscribe to reconnects and the hooks would need to use it.

I also thought that the value from useConnection() would change when the connection disconnects (to null or undefined) or reconnects (to a new object). That would make it possible to track the connection lifecycle (e.g. display a "connected" icon) and would also trigger a re-run of all those effects which have connection in their dependencies. Looks like the most natural way to me, although various places would do unnecessary stuff then. For example, it would be pointless to unsubscribe and then resubscribe to state updates because the former necessarily happens at disconnect and the latter is done by the socket-client already, without any way to disable it. But I'm sure that there would be fairly easy ways to avoid such efforts.

Finally, it might be possible (maybe not here, but in socket-client) to request the latest state/object for all subscriptions after a reconnect. After all, someone cared to subscribe to them and they might have changed in between. The results of those requests would be handled via the usual means, just as if the value had really changed. But I guess wildcards would be a problem.

My favorite would be the one with useConnection(), but I'd like to hear your opinion.

Would it be possible to add an option to the useDialogs hook to optionally pass css to customize the dialog a little bit e.g. size, position etc.?

When creating the native obj I noticed that when I change/add my config the save buttons are not unlocked.
My native obj consists of one obj and otherwise just array with obj that are changed or deleted/added here is an example:

"native": {
	"tablets": [
	  {
		"id": 0,
		"config": {
		  "active": false,
		  "interval": 30,
		  "name": "Test1",
		  "Login": {
			"ip": "",
			"port": 2323,
			"password": ""
		  },
		  "charger": {
			"active": false,
			"chargerId": "",
			"powerMode": "false",
			"loadStart": 20,
			"loadStop": 85
		  }
		}
	  },
            {
		"id": 1,
		"config": {
		  "active": false,
		  "interval": 30,
		  "name": "Test2",
		  "Login": {
			"ip": "",
			"port": 2323,
			"password": ""
		  },
		  "charger": {
			"active": false,
			"chargerId": "",
			"powerMode": "false",
			"loadStart": 20,
			"loadStop": 85
		  }
		}
	  }
	]
  },

please create a SelectID Hook like here SelectID

I noticed that the password is not encrypted when I use "encryptedNative": ["password"] it is written unencrypted in "native": {"password": "12345",} and then encrypted in the adapter code

I have put all this in the template_adapter, you can have a look at it there.
branch: 123-convert-to-iobroker--adapter-dev
Link