Giter Club home page Giter Club logo

Comments (3)

yjukaku avatar yjukaku commented on July 21, 2024 1

Forgot to thank you for the fix. Thanks!

from legitbot.

alaz avatar alaz commented on July 21, 2024

Hello,

Why is it a problem? Currently Legitbot does not reload the set of Facebook IPs, so it makes sense to initialize it once. It can be a problem indeed for long-running Ruby applications, so there is #5.

Do you have other considerations?

from legitbot.

yjukaku avatar yjukaku commented on July 21, 2024

We sometimes run tests without internet connection, but the entire suite fails to boot simply because Legitbot is in the Gemfile. We can't even get to a point where stubbing the Legitbot class would work, since the stub would run after the Legitbot class is required.

Maybe one solution could be to lazy-load the IPs. That way, the request is only made on the first valid? call to the FacebookBot. Or, add a requirement for a Rails initializer like:

# in config/initializers/legitbot.rb
Legitbot.load_bots!

from legitbot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.