Comments (3)
Forgot to thank you for the fix. Thanks!
from legitbot.
Hello,
Why is it a problem? Currently Legitbot does not reload the set of Facebook IPs, so it makes sense to initialize it once. It can be a problem indeed for long-running Ruby applications, so there is #5.
Do you have other considerations?
from legitbot.
We sometimes run tests without internet connection, but the entire suite fails to boot simply because Legitbot is in the Gemfile. We can't even get to a point where stubbing the Legitbot
class would work, since the stub would run after the Legitbot
class is required.
Maybe one solution could be to lazy-load the IPs. That way, the request is only made on the first valid?
call to the FacebookBot
. Or, add a requirement for a Rails initializer like:
# in config/initializers/legitbot.rb
Legitbot.load_bots!
from legitbot.
Related Issues (20)
- FacebookBot mislabeled as fake HOT 7
- Upgrade `create-pull-request` to V5
- Split Google crawlers into categories
- Valid bingbot detected as fake due to multiple DNS names
- DuckDuckGo Browser, identified as bot.
- Migrate from Travis CI to Github Actions
- Is API ready for 1.0 ?
- NoMethodError: undefined method `empty?' for nil:NilClass HOT 9
- NoMethodError: undefined method `index' for nil:NilClass HOT 5
- Does AppleBot still masquerate as GoogleBot? HOT 3
- Petalbot tests are failing
- Update the list of Oracle IPs
- New: Amazon / Yahoo
- iMessageBot HOT 1
- Automate the process of updating IPs
- Mock Resolv
- Resolv issues with googlebot sometimes HOT 7
- Add missing Google crawlers HOT 4
- Add support for GPTBot
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legitbot.