NoMethodError: undefined method `empty?' for nil:NilClass about legitbot HOT 9 CLOSED

Hello,

Do you know the IP causing this?

from legitbot.

Never mind, I can reproduce the bug

Alaz-Laptop:~ alaz$ irb -r interval_tree
Ignoring bson-4.7.1 because its extensions are not built. Try: gem pristine bson --version 4.7.1
irb(main):001:0> t = IntervalTree::Tree.new([])
irb(main):002:0> t.search(1)
=> nil
irb(main):003:0> t.search(2)
=> nil
irb(main):004:0> t = IntervalTree::Tree.new([(0...3)])
irb(main):005:0> t.search(2)
=> [0...3]
irb(main):006:0> t.search(7)
=> []

from legitbot.

@xgrei just wanted to let you know. I suspect that whois returns an empty list of Facebook's AS in your environment. You might want to investigate this further. See the commands here in Facebook documentation: https://developers.facebook.com/docs/sharing/webmasters/crawler

from legitbot.

Thanks for reply, Sorry I cannot get the problematic ip address, Can you just change the code from !ranges.empty? to !(ranges && ranges&.empty?

from legitbot.

Could you please show the rest of the stack trace? I do not quite understand how this is possible. Do you have your own BotMatcher with ip_ranges ?

from legitbot.

NoMethodError: undefined method `empty?' for nil:NilClass
…ms/legitbot-1.0.0/lib/legitbot/validators/ip_ranges.rb:   43:in `valid_ip?'
…ms/legitbot-1.0.0/lib/legitbot/validators/ip_ranges.rb:   20:in `valid_ip?'
…uby/2.6.0/gems/legitbot-1.0.0/lib/legitbot/botmatch.rb:   25:in `valid?'
…uby/2.6.0/gems/legitbot-1.0.0/lib/legitbot/legitbot.rb:   26:in `select'
…uby/2.6.0/gems/legitbot-1.0.0/lib/legitbot/legitbot.rb:   26:in `bot'
…200325332231/app/controllers/application_controller.rb:  160:in `check_bot'

# application_controller.rb
@is_search_bot = ::Legitbot.bot(request.user_agent, request.remote_ip)&.valid? || false

from legitbot.

client user agent:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/601.2.4 (KHTML, like Gecko) Version/9.0.1 Safari/601.2.4 facebookexternalhit/1.1 Facebot Twitterbot/1.0

from legitbot.

Thank you for reporting the bug. The fix is included into version 1.0.1

from legitbot.

Thank you very much for help. :)

from legitbot.