alanduong07 / swipo Goto Github PK

So we should definitely just not load a card if it doesn't have a preview URL, as this is something that is random.

This happens whenever the user is on mobile, and they swipe a card.
It will freeze.

This is most likely because hammer.js doesn't recognize a panend even consistently on mobile.

And there also isn't any indicator that a playlist is even being made, so the user doesn't know that Swipo is writing onto their Spotify profile

It seems that an onClick function simply does not work on mobile, at least not as simple as it does on desktop.

We can use a global volume state for this, and set the volume prop based on it.

It should only create a new one whenever the current_playlist changes!

Gonna have to make sure id is unique, and do some string splicing to extract songURI when needed in call to the swiped function.

Swipo's main issue is because of its unstable routing system. A full redesign of the app is required to maintain a more stable routing system that propagates a single Spotify Web API object in app.js down to the rest of the entire main app. That single object will be updated using useEffect in app.js only.

This is because I recently added the "current_track" global state that allows for automatic audio playing/pausing based on the currently focused card. Swipo is currently setting current_track to undefined, so there should be a way to know when the last song is currently current_track and we just swiped it. Ideally, we should even redirect to the genrePicker for a seamless experience.

Probably because they have the same id

Right now, Swipo will play music for a card only when the play button is clicked. Ideally, we want the user to click play once and play cards automatically, whenever swiped. And then when they don't want anymore sound, they can click the button again.

This intuitively entails a wrapper component/button/module around the cards that controls all of them at once, as currently, the user is clicking on each individual card's play button.

This is a good time to explore a new audio player library, one that is customizable and programmable.

This is a strange bug that seems to occur whenever one loads an album after a playlist, or the symmetric of that, when you load an album after a playlist. Interestingly enough, there seems to be no consequences of this bug.

Steps to recreate this bug:

1. Open Swipo
2. Log in normally
3. Search for a playlist
4. after the playlist starts playing in player, click to the genrePicker page again.
5. Search an album
6. Done.

The most semantic error is this one: Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause().

A useful thread that may be useful: https://developers.google.com/web/updates/2017/06/play-request-was-interrupted

Replicate: Load a playlist, then go back to genrepicker and choose a different playlist. The cards will not be loaded with event listeners and thus cannot be swiped.

Somehow the function is being called twice. This happens whenever someone with no swipo playlist logs in.

Similar to the genre page problem, clicking on the homepage button results in the URL auth tokens being erased. So nothing will load. Also there is no state that saves what the current playlist is, so any page changes at all will erase the URL.

For example, when the user already put in a genre but wants to go back to the genre page to search for something else, the genre page cannot retrieve an auth key in the URL because when the link to the genre page is clicked, it's only the bare url.

This is an easy fix, just rearrange the code so that localstorage isn't searched in when the user completely swiped on something. or just instantly do push the genrepage path when the user swiped on the last track.

A simple button should do! Use local state here, as the rest of the app does not need this state information.

For example, sometimes there isn't a song album cover image retrieved for some reason, and the program crashes.

This is the first of many additions that will have to be made before I apply for approval from Spotify.

Buttons that can be left for a later update to Swipo:

• Settings Button
• Profile Button
• Shuffle/Misc. Button