alan-hicks / django-dmarc Goto Github PK

Hi @alan-hicks and thanks for publishing django-dmarc as an open-source project :)

I was looking for a web-based tool to automate DMARC report processing, and thought that django-dmarc would be a nice base for a self-hosted alternative to dmarcian (and similar tools).

To this effect, I've forked the repository and started a sandbox branch at https://github.com/virtualtam/django-dmarc/tree/vt/master , that currently features the following additions and changes:

• add the Tox virtualenv management tool to automate managing test environments
• add Python linters: isort, Pycodestyle (formerly pep8), Pylint
• add Python 3.x-compatibility
• add a demo Django project for quick testing/demoing
• update packaging / setuptools settings
• fix (most) lint errors

Notes:

• the commits have been kept atomic to ease reviewing
• the documentation would need to be updated to reflect the latest changes
• I plan on adding / improving the following features / integrations before using this project in a production environment:
  • Travis CI integration
  • Docker image
  • broader test coverage
  • more idiomatic Django-ORM queries

Would you be interested in integrating these changes into your repository? I'd be happy to rework my modifications so the commits can be upstreamed :)

Regards,

VirtualTam

I am totally unexperienced with django, but i decided to try your project, as it seems as interested. But initial testing fails with:

...
  File "tmp/reports/reports/urls.py", line 19, in <module>
    from dmarc import urls as dmarc_urls
  File ".venv/dmarc/lib/python3.9/site-packages/dmarc/urls.py", line 10, in <module>
    from django.conf.urls import url
ImportError: cannot import name 'url' from 'django.conf.urls'
    (.venv/dmarc/lib/python3.9/site-packages/django/conf/urls/__init__.py)

Quick search points me to https://stackoverflow.com/a/70319607 where is noted, that url() was deprecated in 3.X and removed in 4.

Your setup.py doesn't limits django to any version in its requires field.

Hello and thanks for open-sourcing this, it's much appreciated.

I was looking for a way to receive my DMARC reports directly on the Django site, and this helps a ton.

If you ever find the time, a feature that would be really nice is the ability to visualize aggregated data, in a way similar to what this does: https://dmarcly.com/features

Hello,

Where is base.html, that is required? It indicated in report.html.
https://github.com/alan-hicks/django-dmarc/search?utf8=%E2%9C%93&q=base.html