Use it for all carriers.

• basic implementation
• use cerberus
• output zpl
• test
• document

Add Geodis carrier

Could you release roulier once #163 will be merged please ?

I saw that you didn't add a license to this project.
If you want to add one, what would it be ?

Thanks,
cc @lepistone, @hparfr

Instead of using a string, use a more defined type like "number".
See http://docs.python-cerberus.org/en/stable/validation-rules.html#type

Some carriers may need the weight in kg or in g and choose a "," or "." as separator.

Since firstname is not present some countries a simple name field is enough.
It will work with Laposte API and it's compliant with other API on the market.

(env) USER@WORKSTATION:~$ pip install roulier==0.0.0
Collecting roulier==0.0.0
  Downloading roulier-0.0.0.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-4KXwP2/roulier/setup.py", line 6, in <module>
        version = open('VERSION').read().strip()
    IOError: [Errno 2] No such file or directory: 'VERSION'

I'm investigating but not so used to build pip installable package :(

Tests calls with accents and non alpha chars.

For some carrier, we may want to manage different services/implementation.
Gls France for instance propose multiple solutions, like GLS-BOX, which return zpl, or GLS Web API.
Laposte fr also have multiple solutions (SOAP XML, the current implementation, or a REST API, not implemented yet)
DPD is also changing its api, the current one should be abandoned soon, etc...

It seems it could be quite usefull to ba able to choose among mulltipe implementation of a service/action.
For example to enjoy new functionalities or during the transition from one system to another, etc...

We currently have the case for GLS, where present implementation is the GLS-BOX and we want to also implementent the GLS Web API one : #138.

Since one carrier may have a propose different solution depending on the country (typlically, the implemented GLS-BOX is only for France and won't work for other countries), we had previously decided to add a suffix depending the country to be able to manage the carrier in multiple countries.
So, the gls_eu carrier type proposed in #138 is really confusing (unless it work for multiple european countries, but I doubt it..not sure though.

I'd like then to introduce a system allowing to choose between 2 implementation, while having a default one (so the user that do not care about which implementation is used to get a label don't need to care about that).

For this, we could modify the factory sytem to have something like that :

class RoulierFactory(object):
    def __init__(self):
        self._carrier_action = {}

    def register_builder(self, carrier_type, action, Carrierclass, ttype="default"):
        self._carrier_action[(carrier_type, action)] = {ttype: Carrierclass}

    def get(self, carrier_type, action, ttype="default, **kwargs):
        carrierclass = self._carrier_action.get((carrier_type, action), {}).get(ttype)
        if not carrierclass:
            raise ValueError((carrier_type, action))
        return carrierclass(carrier_type, action, **kwargs)

def get(carrier_type, action, *args, **kwargs):
    carrier_obj = factory.get(carrier_type, action)
    ttype = kwargs.pop('ttype', 'default')
    return getattr(carrier_obj, action)(carrier_type, action, *args, **kwargs)

And on carrier side :

class GlsFrBoxGetLabel(CarrierGetLabel):
...

factory.register_builder("gls_fr", "get_label", GlsFrBoxGetLabel, ttype="gls-box")

class GlsWebGetLabel(CarrierGetLabel):
...

factory.register_builder("gls_fr", "get_label", GlsWebGetLabel)

This way, calling roulier.get('gls_fr', 'get_label', payload) will return a gls label using the WEB api
and calling roulier.get('gls_fr', 'get_label', payload, ttype="gls-box") will return a gls label using the GLS-BOX solution.

Any comment about such a change ?
@DylannCordel I'd appreciate your opinion about this

cc @hparfr @bealdav

Hi do you have tips on how to integrate this module inside Odoo.

I assume it's with your other module named delivery-carrier on branches 9-roulier, origin/9-roulier.
But how does it work when you installed delivery-carrier inside Odoo in v9 ?

Thx in advance,

Razgort

use
from .carriers.laposte.laposte import Laposte'
instead of
from carriers.laposte.laposte import Laposte'

See also http://programmers.stackexchange.com/questions/159503/whats-wrong-with-relative-imports-in-python

get_parts https://github.com/akretion/roulier/pull/3/files#diff-b0df2a6cf5c7d698e8c760e7cbde1e03R140

Some WS returns the label as base64 in xml, some other as MIME Attachement.
get_parts has been written for the latter.

Because, it's not laposte specific, it should be put elsewhere.

When i want to use this api, i have a traceback

-> from roulier import roulier
-> laposte = roulier.get('laposte')
-> laposte.api()
Traceback (most recent call last):
File "", line 1, in
File "/root/roulier/roulier/carriers/laposte/laposte.py", line 19, in api
return self.encoder.api()
File "/root/roulier/roulier/carriers/laposte/laposte_encoder.py", line 52, in api
return api.api_values()
File "/root/roulier/roulier/api.py", line 158, in api_values
return self.normalize({})
File "/root/roulier/roulier/api.py", line 180, in normalize
return self._validator().normalized(data, self.api_schema())
File "/root/roulier/roulier/api.py", line 133, in api_schema
schemas = self._schemas()
File "/root/roulier/roulier/carriers/laposte/laposte_api.py", line 150, in _schemas
schemas = super(LaposteApi, self)._schemas()
File "/root/roulier/roulier/api.py", line 116, in _schemas
'parcels': self._parcels(),
File "/root/roulier/roulier/api.py", line 89, in _parcels
'default': [v.normalized({}, self._parcel())]
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 593, in normalized
self.__init_processing(document, schema)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 548, in __init_processing
self.schema = DefinitionSchema(self, schema)
File "/usr/local/lib/python3.5/dist-packages/cerberus/schema.py", line 69, in init
self.validate(schema)
File "/usr/local/lib/python3.5/dist-packages/cerberus/schema.py", line 197, in validate
self._validate(schema)
File "/usr/local/lib/python3.5/dist-packages/cerberus/schema.py", line 218, in _validate
if not self.schema_validator(schema, normalize=False):
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 879, in validate
self.__validate_unknown_fields(field)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 912, in __validate_unknown_fields
if not validator({field: value}, normalize=False):
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 877, in validate
self.__validate_definitions(definitions, field)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 940, in __validate_definitions
result = validate_rule(rule)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 922, in validate_rule
return validator(definitions.get(rule, None), field, value)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 1236, in _validate_schema
self.__validate_schema_mapping(field, schema, value)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 1247, in __validate_schema_mapping
if not validator(value, update=self.update, normalize=False):
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 877, in validate
self.__validate_definitions(definitions, field)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 940, in __validate_definitions
result = validate_rule(rule)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 921, in validate_rule
validator = self.__get_rule_handler('validate', rule)
File "/usr/local/lib/python3.5/dist-packages/cerberus/validator.py", line 338, in __get_rule_handler
"domain.".format(rule, domain))
RuntimeError: There's no handler for 'description' in the 'validate' domain.

I tried with python2.7 and python3.5 with the same result.
What i'm doing wrong ?

incoterm must be at the same level than "addresses" field, not inside the delivery address.

Hello,
I got an error when I call the api() method.
I'm on Cerberus 1.2. No issue with Cerberus 1.1.

Python 2.7.15rc1 (default, Apr 15 2018, 21:51:34) 
[GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from pprint import pprint
>>> from roulier import roulier
>>> 
>>> 
>>> laposte = roulier.get('laposte')
>>> pprint(laposte.api())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "build/bdist.linux-x86_64/egg/roulier/carriers/laposte/laposte.py", line 19, in api
  File "build/bdist.linux-x86_64/egg/roulier/carriers/laposte/laposte_encoder.py", line 52, in api
  File "build/bdist.linux-x86_64/egg/roulier/api.py", line 158, in api_values
  File "build/bdist.linux-x86_64/egg/roulier/api.py", line 180, in normalize
  File "build/bdist.linux-x86_64/egg/roulier/api.py", line 133, in api_schema
  File "build/bdist.linux-x86_64/egg/roulier/carriers/laposte/laposte_api.py", line 150, in _schemas
  File "build/bdist.linux-x86_64/egg/roulier/api.py", line 116, in _schemas
  File "build/bdist.linux-x86_64/egg/roulier/api.py", line 89, in _parcels
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 593, in normalized
    self.__init_processing(document, schema)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 548, in __init_processing
    self.schema = DefinitionSchema(self, schema)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/schema.py", line 69, in __init__
    self.validate(schema)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/schema.py", line 197, in validate
    self._validate(schema)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/schema.py", line 218, in _validate
    if not self.schema_validator(schema, normalize=False):
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 879, in validate
    self.__validate_unknown_fields(field)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 912, in __validate_unknown_fields
    if not validator({field: value}, normalize=False):
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 877, in validate
    self.__validate_definitions(definitions, field)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 940, in __validate_definitions
    result = validate_rule(rule)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 922, in validate_rule
    return validator(definitions.get(rule, None), field, value)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 1236, in _validate_schema
    self.__validate_schema_mapping(field, schema, value)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 1247, in __validate_schema_mapping
    if not validator(value, update=self.update, normalize=False):
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 877, in validate
    self.__validate_definitions(definitions, field)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 940, in __validate_definitions
    result = validate_rule(rule)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 921, in validate_rule
    validator = self.__get_rule_handler('validate', rule)
  File "/home/quentin/.local/lib/python2.7/site-packages/cerberus/validator.py", line 338, in __get_rule_handler
    "domain.".format(rule, domain))
RuntimeError: There's no handler for 'description' in the 'validate' domain.

Thank you

according to the error resposne is type of string or dictionnary for geodis

Geodis Response don't contain "attachement" key.

File "/workspace/parts/8-roulier/delivery_carrier_label_roulier/stock.py", line 219, in _call_roulier_api
ret = roulier_instance.get_label(payload)
File "/workspace/eggs/roulier-0.0.1-py2.7.egg/roulier/carriers/geodis/geodis.py", line 32, in get_label
return self.get(data, 'demandeImpressionEtiquette')
File "/workspace/eggs/roulier-0.0.1-py2.7.egg/roulier/carriers/geodis/geodis.py", line 26, in get
parts = response['attachement']
KeyError: 'attachement'

Add a CHANGELOG.md

How could i make the difference between the mobileNumber and the phoneNumber with LaPoste since the template for an address is

<address>
        ...
	<mobileNumber>{{ address.phone }}</mobileNumber>
        ...
</address>

I'm thinking about making a pull request about that, is there anything I should know before?

get_carriers return possible values for roulier.get()

Hi @hparfr,

Do you plan to publish this library to Pypi ?

Thanks.

• Introduce what roulier is
• big picture (py lib which call WS)
• simple usage