ajmurmann / resque-heroku-autoscaler Goto Github PK

Hey there! I was taking a look at resque, and found this awesome gem, something I was thinking of doing myself.

A quick question though, is there any plans to have this work with the new Heroku Cedar Stack? It would be awesome to use this same method to scale different process models.

Cheers!

Your example for new_worker_count config is incorrect. Change it to:

(pending/5.0).ceil.to_i

Unless you put the decimal point on the denominator you will effectively be getting the floor instead of the ceiling.

I don't see anything in the documentation abou running in development mode, and don't see any indications that it's handled in the code. I'm currently only extending my workers in environments that are running on Heroku, but it would be great if there were a more graceful way of handling that, maybe by being able to set a disabled boolean on the config.

If that were set then the plugin could just log what it would have done, rather then attempting to scale up the workers on my live applications just because I queued a job on my development machine.

I'm very happy to write a patch to implement that if it's of interest, but I just want to check I've not missed anything obvious first.

When I enqueue a job I get this error:

NameError (uninitialized constant Resque::Plugins::HerokuAutoscaler::Heroku)

I don't know why I would need it, but I added to my job class:

require 'heroku-api'

Then I get:

NameError (uninitialized constant Heroku::Client)

Huh? So I add:

require 'heroku/client'

Then I get:

NoMethodError (undefined method []' for nil:NilClass)`

For each of these errors my stack trace stops at the initial call to #enqueue so that's where I gave up.

I think I followed the readme instructions exactly. Thoughts?

Hey there!

I'm gearing up to work on Resque 2.0, and I'd like to coordinate better with plugin authors to make sure stuff doesn't break.

I'd like to know a few things:

1. Can I do something to help get you testing against edge Resque?
2. Are you monkey-patching anything in Resque currently? Can 2.0 expose an API to help you not have to do that any more?
3. Do you need any help in bringing your plugin up-to-date with the latest Resque?

Thanks!

Related: https://github.com/defunkt/resque/issues/880