ajjohnston / gulp-polylint Goto Github PK

Please see https://github.com/gonsfx/gulp-jscs-stylish#combine-results-with-those-of-jshint for a way to combine jshint and jscs results. I would love to see a possibility to do the same with polylint results. This would also remove the need for a fail reporter (#2), because jshint's fail reporter can be used.

Please provide another reporter to let the build fail when issues have been found. See https://github.com/spalger/gulp-jshint#fail-reporter for an example.

gulp-polylint seems to fail in Gulp 4 using the most paired-back code possible:

function markup() {
  return gulp.src(sourceFiles)
    .pipe(polylint());
}

Starting 'markup'...
The following tasks did not complete: markup
Did you forget to signal async completion?

Adding .pipe(debug({title: 'markup'})) shows that the task is otherwise doing what I am expecting:

markup app/index.html
markup app/styles/app-theme.html
markup app/styles/shared-styles.html
markup 3 items
The following tasks did not complete: markup
Did you forget to signal async completion?

This is the path that is checked:
/Users/connor/source/app/Users/connor/source/app/bower_components/moment/moment.js

Somehow the root (where I run gulp from) is doubled. It needs to be:
/Users/connor/source/app/bower_components/moment/moment.js it would

I honestly haven't looked at the source to understand exactly what is happening. Just hoping this is something dumb with my setup. I'll dig in meanwhile.