Giter Club home page Giter Club logo

choco-docker-engine's Introduction

Hi there 👋

An image of @ajdurant's Holopin badges, which is a link to view their full Holopin profile

choco-docker-engine's People

Contributors

ajdurant avatar lukasz-mitka avatar viceice avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

choco-docker-engine's Issues

Detecting user existence in a group is not always working

If (net localgroup $($pp.DockerGroup) | Select-String $groupUser -Quiet) {

There is an issue while detecting if user already exists in a group. This causes an error and terminates the instalation.

In my case, I have a username with parenthesis ()

This prints nothing:

echo "my user (123)" |Select-String "my user (123)"

But this one works:

echo "my user (123)" |Select-String "my user"

Include Docker Credentials Helper?

Using Docker installed from this package and attempting to login to a private repository (should be the same logging in to Docker Hub), I get an error stating docker-credential-wincred.exe was not found and the login fails.

As far as I can tell this isn't available in another Chocolatey package so perhaps it should be added to this one? I was able to download and rename https://github.com/docker/docker-credential-helpers/releases/download/v0.8.0/docker-credential-wincred-v0.8.0.windows-amd64.exe to successfully login.

Proxy cannot be set

HTTP_PROXY and HTTPS_PROXY environment variables are not taken into account.
Unable to set the proxy.

Fix version string in the chocolateyInstall.ps1

The url in the install powershell should not contain a variable but a fix url.
Background. There is an internalization functionality by chocolatey which repacks the package for own package server and e.g. offline szenario. So the url cannot be determined because the variable doesn‘t exists… It may work for install, but not for internalization.

https://docs.chocolatey.org/en-us/features/package-internalizer

Would it possible to fix this and release the newest version? Many thanks

Cannot find file at '..\\lib\docker-engine\tools\docker\dockerd.exe'

Trying to run dockerd manually from a command prompt (to temporarily configure proxy settings), I get the following error:

c:\ProgramData\chocolatey\bin\dockerd.exe
Cannot find file at '..\lib\docker-engine\tools\docker\dockerd.exe' (c:\ProgramData\chocolatey\lib\docker-engine\tools\docker\dockerd.exe). This usually indicates a missing or moved file.

Allow configuring the group name

I'm migrating our infrastructure to this package and i already have a docker group.
So i would like to use my existing group.

Automation for updates

At the moment I follow the moby releases RSS feed, and update the package when a new release is made.

It should be straightforward to automate this - or even just to script updating and validating the checksum and version number.

cli-plugins not found

By default docker binary distribution brings two cli plugins.
Those are not found, because docker searches C:\Program Files\docker\cli-plugins\ and this packages installs them to C:\ProgramData\chocolatey\lib\docker-engine\tools\docker\cli-plugins\.

So i would suggest to install the docker files to C:\Program Files\docker by default.

I think setting the UnzipLocation 1 parameter should do it.

Footnotes

  1. https://docs.chocolatey.org/en-us/create/functions/install-chocolateyzippackage#unziplocation-string

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.