aistomin / guitarist Goto Github PK

Let's integrate with https://codecov.io/ and add a badge to the README

This issue is a part of #21

Maybe this post will be helpful: https://stackoverflow.com/questions/16462854/midi-beginner-need-to-play-one-note

For the beginners it's better to start with something like first 5 frets.

Now we have only questions where user have to input the answer. We need the answers with options. For the first implementation let's cover the following scenario:

1. Display the question with a) b) c) d) ... answer options.
2. User have to input "a" or "b" or "c" or "d" ...
3. The software validates if the user selected the right option.
4. Display the result to the user.

This issue is a part of #21

We need somehow to control the code style. I suggest to use https://www.qulice.com/ for it. In scope of this issue let's just integrate the qulice with our project and create an issues to fix the problematic code which doesn't pass the check style.

See https://hitsofcode.com/

https://travis-ci.org/github/aistomin/guitarist/builds/757538189

The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .

It is a part of #16. We need to create a question which can play sound after the question's text is displayed.

https://www.alt-codes.net/music_note_alt_codes.php

Let's use https://github.com/aistomin/maven-dependencies-analyser

Currently we use maven-surefire-plugin:2.19.1, because we had problems with running Junit5 tests with maven-surefire-plugin:2.22.0. Let's re-visit this problem and try to make it working.

http://doc.rultor.com/

Let's add a badge to the README. See https://www.javadoc.io/ how to do it.

Let's create the demo app and add all the existing tests to it.

The flow:

1. The program asks to select the test. It displays list of the tests with the numbers and asks user to press the desired number. Offer the "Exit" option.
2. User should be able to pass the test.
3. Ask user to continue or exit.
4. On exit the application shows "Good bye!" message.
5. On continue we start with the step 1.

Let's add the instruction to README file. In this instruction we should explain how to run the demo app.

Currently if the user made a mistake we say that test is failed. Let's adjust this logic and introduce acceptable percentage of the wrong answers.

Now the class com.github.aistomin.guitarist.simple.SimpleQuestion accepts question's text as a string. It's not really convenient in case of multi-choice questions.
Let's create a structure which will decide how to display itself.

Add the mechanism which allows to read the test questions from JSON file.

It is a part of #16. Let's create an answer which plays sound after displaying the text, so the user can remember the sound.

We need a test which allows to check the student's knowledge of the notes on the fretboard.

We want to keep the code-coverage relatively high, so let's add this validation to the test phase.

Looks like it's just an edge case of com.github.aistomin.guitarist.advanced.PercentageBasedResult where percentage = 100. Let's do the following:

1. Add special constructor to com.github.aistomin.guitarist.advanced.PercentageBasedResult where percentage is default = 100
2. Let's replace all the usages and delete com.github.aistomin.guitarist.simple.SimpleResult
3. Let's rename com.github.aistomin.guitarist.advanced.PercentageBasedResult to something like DefaultTestResult.

Once #2 is solved we can implement the simple notes' sound test:

1. User hears the sound.
2. User needs to recognise which note is that?

Here are the MIDI sounds: http://www.inspiredacoustics.com/en/MIDI_note_numbers_and_center_frequencies