aisola / objectweb Goto Github PK

I don't work with regular expressions at all. So sorry if this makes no sense, but would it make sense to cache the regular expressions compile method, in the _match method?

    def _match(self, rpath):
        ...
        for pat, what in self.urlmap.iteritems():
            """
            Cache the re.compile so I only have to match
            """
            result = re.match(str(rpath))
        ...

Maybe somewhere in the initialization. Then there would need to be like an add_route method that makes sure every new route gets cached.

Hi, I'm not sure, maybe I don' know how to properly use kwargs but seems like this (in webapi.py, getall):
for key, val in kwargs:
http_params.append(get(key, val))

should be

for key, val in kwargs.iteritems():
    http_params.append(get(key, val))

Learning a lot with your library :)

https://webapp-improved.appspot.com/_modules/webapp2.html#cached_property

Can not find the way to get the data passed by curl sending by post ... as one json data ... I get FieldStorage (None, None, {data})

On line 92 the " % self.error" is missing.