Giter Club home page Giter Club logo

Comments (5)

argaen avatar argaen commented on May 26, 2024

aioredis behaves like this by default:

In [5]: import asyncio
   ...: import aioredis
   ...: 
   ...: loop = asyncio.get_event_loop()
   ...: 
   ...: @asyncio.coroutine
   ...: def go():
   ...:     redis = yield from aioredis.create_redis(
   ...:         ('localhost', 6379), loop=loop)
   ...:     yield from redis.set('my-key', 1)
   ...:     val = yield from redis.get('my-key', encoding="utf-8")
   ...:     print(val)
   ...:     print(type(val))
   ...:     redis.close()
   ...: loop.run_until_complete(go())
   ...: 
1
<class 'str'>

Reducing priority since its the behavior of the default client.

Anyway, the solution that could be implemented is to save the type of the key and make the cast when it is retrieved. This type saving should be optional since it will use extra space... An example flow:

  1. set("my-key", 1, save_type=True) # this will create both the my-key: 1 and my-key-type: int keys.
  2. When retrieving, it will do a my-key-type(retrieved_value).

If save_type is not passed, client default behavior is implemented. This behavior should only be for built int python types?? For advanced python objects pickle and custom serializer strategies can be followed. Need to think about it and see if this case is worth it to implement

from aiocache.

argaen avatar argaen commented on May 26, 2024

Where this logic will reside is yet to decide (serializers or backend).

from aiocache.

argaen avatar argaen commented on May 26, 2024

Add an example of how to solve this using marshmallow. Once its well explained issue can be closed (and reopen another one in case the saving type functionality is asked

from aiocache.

argaen avatar argaen commented on May 26, 2024

Problem is deeper, with defaultserializer, memorycache can store any object and will retrieve it correctly. with memcached and redis this is not possible. Behavior should be the same for the different caches but then we will be cutting functionality from the memory one...

from aiocache.

argaen avatar argaen commented on May 26, 2024

Lets follow redis-py approach of converting the values transparently instead of limiting the behavior.

This will introduce the following behavior with the default serializer:

await cache.set("key", 1)
await cache.get("key")
>>>> '1'

await cache.set("key", {"a": 1, "b": []})
await cache.get("key")
>>>> '{"a": 1, "b": []}'

Documentation must be clear and warn the user about that.

Each backend must be responsible of converting to the needed datatype. I've tried to do this in the serializer layer but then the user must change existing serializers to return bytes or something supported by the user. Lets allow this "incorrect" type propagation until the backend itself and then deal with it there.

from aiocache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.