Giter Club home page Giter Club logo

Comments (6)

Dreamsorcerer avatar Dreamsorcerer commented on June 23, 2024 1

I've removed the py.typed file for the next 0.x release, so it go back to being untyped.
We'll focus on getting the type annotations working for the 1.0 release.

from aiocache.

Dreamsorcerer avatar Dreamsorcerer commented on June 23, 2024

Pretty sure 0.11 has no typing, so it's not a regression.

That class does some weirdness with __new__(), maybe adding annotations to that method will get mypy to figure it out. Otherwise, I think that's due for a refactor to make the implementation a bit simpler. There are already some tasks open to refactor parts for the 1.0 release, if you've got any time to help out and look at some of those, that'd help get us there quicker.

from aiocache.

bvlasyuk-cw avatar bvlasyuk-cw commented on June 23, 2024

Yes, I was not correct in my takes. 0.11 has no typing, but mypy returned issues about that Cache instance doesn't have some attributes. I will try chech it if I have a free time. Thanks

from aiocache.

Dreamsorcerer avatar Dreamsorcerer commented on June 23, 2024

I just had a quick check, if I try to annotate __new__() I get more errors (e.g. that it must return a subclass of Cache, but it's actually returning a subclass of BaseCache).

I think refactoring this for 1.0 is going to be the best option. Maybe we should just remove the Cache class completely and get users to import the actual cache implementation they want to use? Would likely make things a lot simpler.

from aiocache.

cpaillet avatar cpaillet commented on June 23, 2024

Hi,

after upgrade from 0.12.0 to 0.12.1, I have this mypy error

Skipping analyzing "aiocache": module is installed, but missing library stubs or py.typed marker [import]

from aiocache.

Dreamsorcerer avatar Dreamsorcerer commented on June 23, 2024

See the comments above. I've disabled typing support until v1.

from aiocache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.