ailon / phonenameresolver Goto Github PK
View Code? Open in Web Editor NEWHelps resolve actual reported Windows Phone model names to their "canonical" (publicly known) form.
License: MIT License
Helps resolve actual reported Windows Phone model names to their "canonical" (publicly known) form.
License: MIT License
Documentation is needed. It's easy to decipher what Manufacturer name is (DeviceStatus.ManufacturerName
) but it's not straightforward what "Model" is referring to. XML documentation tags would clear this up. Or at least a usage example in the Readme.
Any reason why .Resolve
can't be parameterless with internal usage of the DeviceStatus
API?
See this:
https://www.bluetooth.org/tpg/QLI_viewQDL.cfm?qid=23305
RM-1140 and RM-1141 are both Lumia 540 DS.
Seems like this project would be great as a nuGet package so users can easily incorporate and then get updates as we figure out new manufacturers & models.
Are you sure that the latest change of RM-codes in PhoneNameResolver.cs ("nokia rm-1010 update") is really correct? According to http://forums.wpcentral.com/upcoming-rumored-devices/293171-just-found-rm-1010-others-navifirm.html the codes are as follows:
==> RM-1010 = Lumia 638
==> RM-1027 = Lumia 636
I'm not sure what the model code is for this at this time, but just submitting this so it's something that gets put on the list to be added as soon as somebody knows it.
i have a friend w/ an M8 - if I can get him to pull the model name i'll attach it to this issue.
Hi there,
According to the service manuals, the Lumia 636 has code "RM-1027" assigned. Furthermore, the Lumia 638 has code "RM-1010" assigned. And the Lumia 1020 is also known as 909, i.e. you should add for the Lumia 1020 the codes "LUMIA 909" and "909". Additionally, you write on lines 194-197...
if (lookupValue.StartsWith("C620"))
{
lookupValue = "C625";
}
Ergo, the according lookup value should be C620.
Best regards,
Patrick
Hi ailon,
In lines 235-238: Why don't you just simly write...
result.CanonicalManufacturer = manufacturer;
...?
And in line 219:
CanonicalManufacturer = manufacturer,
From the switch/case statement in lines 25-26, the variable "manufacturer" is always filled with the respective manufacturer name (either Nokia or Microsoft). This would make the code easier and would also prevent an implementation of redundant Information, such as "CanonicalManufacturer="MICROSOFT" (see lines 522-525).
What do you think?
Best regards,
Patrick
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.