aiktb / furiganamaker Goto Github PK

Is your feature request related to a problem? Please describe.

To put (or prepare to put) hiragana, when this extension is turned on, it will create spaces between words (Kanji)
Even it is under on-hover mode, we can see the layout of the contents changed, as the below pictures showed
Sometimes these spaces between words cause a little inconvenience in reading

I tried to set hot-key, but it actually is not "turn on-off" Furigana, but call (pop-up) menu.

Describe the solution you'd like

I would like to ask if it is possible to have a hot-key to "turn on-off" Furigana,
that can make the reader to switch between "normal layout" (easier to read) and "show Hiragana"?
Or, it does not pre-leave space to put Hiragana, but create space "dynamically" when on-hover (in hover mode)?

Hope my description is not confusing.

Describe alternatives you've considered

No response

Additional context

No response

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

Describe the bug

I tried to 1. modify one item 2. remove all rules 3. just save with the original rules,
it warns me JSON is invalid (and unable to save).

Reproduction

1. modify the rule,
   from [{"domain": "twitter.com","selector": "div[lang='ja'] span","dynamic": true,"enabled": true},
   to [{"domain": "twitter.com","selector": "div[lang='ja'] span","dynamic": true,"enabled": FALSE}, ...
   → Invalid JSON

2. remove all contents in the rule box
   → Invalid JSON

3. undo all steps by 2 times ctrl+Z
   → Invalid JSON

Expected behavior

Clear the rule

Browser

Edge

System Info

No response

Additional context

No response

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• Read the Contributing Guidelines.
• I would like to fix this BUG via a PR.

Describe the bug

Vicious bugs extremely seriously affect the user experience and must be fixed.

Reproduction

Example Site

Expected behavior

The browser will not become unresponsive.

Browser

Chrome

System Info

System:
    OS: Windows 11 10.0.22621
    CPU: (12) x64 AMD Ryzen 5 5600U with Radeon Graphics
    Memory: 2.61 GB / 13.86 GB
  Binaries:
    Node: 20.6.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.2.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.12.1 - ~\AppData\Local\pnpm\pnpm.CMD
  Browsers:
    Edge: Chromium (120.0.2210.121)
    Internet Explorer: 11.0.22621.1

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• Read the Contributing Guidelines.
• I would like to fix this BUG via a PR.

Is your feature request related to a problem? Please describe.

This issue is used to track the progress of feature implementation in the comments following.

Describe the solution you'd like

Nothing

Describe alternatives you've considered

No response

Additional context

No response

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

Is your feature request related to a problem? Please describe.

Thank you for creating this extension first.

While looking for a furigana extension, I found x6ud and your extension.
https://github.com/x6ud/auto-furigana-chrome-extension and your extension

For me as someone with very very basic Japanese knowledge, an ideal furigana extension will be one that

1. autodetects
2. vocab feature - for users to translate any words (via word segmentation like with kuromoji) through any manner
3. display furigana for Kanji and in Hiragana / katakana and not romaji.

Describe the solution you'd like

Translation / Vocab feature for words using word segmentisation like auto-furigana to allow users to hover over words and understand the meaning of certain kanji. It would be even better if it is available for all Japanese words and not just kanji.

Describe alternatives you've considered

No response

Additional context

No response

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

Describe the bug

Reproduction

Unnecessary.

Expected behavior

Browser

Chrome

System Info

No response

Additional context

This is confirmed to be a TinyColor bug:

> tinycolor({h: 100, s: 0,v: 10}).toHsv()
> {h: 0, s: 0, v: 10}

This results in a serious loss of hue accuracy.
The solution is to use another color space conversion library, which requires correct handling of the following values:

• named-color
• "currentColor"
• HSV
• HSL

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• Read the Contributing Guidelines.
• I would like to fix this BUG via a PR.

Is your feature request related to a problem? Please describe.

I was testing out all the options to find something comfortable to read - as I have very poor eyesight and dyslexia - I was trying out the other options under the section with "Always Show" and "Hover".

I like the extra space that the "Hover Gap" option had for the kanji between sentence lines compared to it's 'no gap' counterpart but I would still like to see the furigana above the kanji with a little bit extra space.

With just the current "Always Show" option, it squishes the characters a little too much together for someone with bad vision/disability. Sometimes the page loads in such a way that the characters even overlap which makes it even more difficult to understand.

(Image showing the option section I'm talking about.)

(Image of the overlapping kanji and furigana on the front page of JP wiki as example.)

Describe the solution you'd like

I'd like it if there could be an added option for an "Always Show" to have more space between the lines to adjust for the added characters. Even if it's only a few pixels worth, just to make it more readable for those with vision disabilities. Maybe called "Always Show with Gap" or something similar.

(Made a little mock-up of what I mean.)

Describe alternatives you've considered

The only other option that I can think of is adding the furigana after text in parentheses rather than over the top but that doesn't always work with webpage formats.. I've seen other extension trying something like this and color code the furigana but I never got them to work.

Additional context

Um, the only other thing that I could think of is that if there is an ability to have/import different fonts from something free like Google Font. Sometimes it makes it easier to read the text than with the default fonts, in terms of the disability issue.

Thank you for your time and consideration!~ orz

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

Describe the bug

As title.

Reproduction

https://ja.vuejs.org/guide/introduction.html

Use the Popup or content menu's "Add furigana" function to click on a link on the page.
Note that on-site links behave differently than off-site links.

Expected behavior

Prevent the link's routing.

Browser

Chrome

System Info

No response

Additional context

This involves some internal details of vue-router, for which event.preventDefault will not work.

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• Read the Contributing Guidelines.
• I would like to fix this BUG via a PR.

Is your feature request related to a problem? Please describe.

Currently this extension only supports N5 level kanji filters.
The N5 level still has many common Chinese characters that are not covered, and it needs to be expanded to a higher level.

Describe the solution you'd like

Supports N4/N3/N2 levels of kanji filters.
Provide a filter level switcher on the options page.

Describe alternatives you've considered

Just the corresponding JSON file is required.

This file needs to conform to the following format:

interface FilterRule {
  kanji: string;
  reading: string[];
}

filter.json as {
  N2: FilterRule[];
  N3: FilterRule[];
  N4: FilterRule[];
  N5: FilterRule[];
};

Additional context

Planning to extract this information from the JTPL sensei website requires writing a script.

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

Is your feature request related to a problem? Please describe.

Currently, this extension uses the @iconify/react dependency, a library that loads icons on-demand from the web, generates a noticeable FOUC on first load, and subsequently loads them via cache.

Through research, this library can be replaced by @egoist/tailwindcss-icon and all icons are local with no FOUCs, which is great!

Describe the solution you'd like

No FOUC.

Describe alternatives you've considered

Migrated from @iconify/react to @egoist/tailwindcss-icon.

Additional context

No response

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency @tailwindcss/typography to v0.5.14
• chore(deps): update dependency react-i18next to v15.0.1
• chore(deps): update dependency tailwindcss to v3.4.9
• chore(deps): update dependency @commitlint/cli to v19.4.0
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency @floating-ui/react to v0.26.22
• chore(deps): update dependency @types/node to v20.14.14
• chore(deps): update dependency @wxt-dev/module-react to v1.1.1
• chore(deps): update dependency autoprefixer to v10.4.20
• chore(deps): update dependency husky to v9.1.4
• chore(deps): update dependency vitest to v2.0.5
• chore(deps): update dependency wxt to v0.19.4
• chore(deps): update dependency @playwright/test to v1.46.0
• chore(deps): update dependency react-router-dom to v6.26.0
• chore(deps): update pnpm to v9.7.0
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update react monorepo to v18.3.1 (react, react-dom)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Describe the bug

Submissions could be submitted normally before January 15, 2024, but now Edge review has suddenly added the requirement that uploaded zip files are not allowed to contain compressed files.
The third-party library kuromoji.js used by this extension relies on some local *.dat.gz files. The gz files are compressed files, which prevents the extension from being submitted to Edge.

Reproduction

Unnecessary.

Expected behavior

Add a fork of kuromoji.js to upload to NPM and reference it in this project so that it accepts *.dat files instead of *.dat.gz files.

Browser

Chrome

System Info

No response

Additional context

Link to microsoft/MicrosoftEdge-Extensions#135

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• Read the Contributing Guidelines.
• I would like to fix this BUG via a PR.

Is your feature request related to a problem? Please describe.

Discontinued maintenance of firefox version as of version 2.0.0, which means that the latest version of firefox Furigana Maker will be 1.6.1, which will keep the default addition of furigana functionality for X.

The main reason for this is that firefox currently has poor MV3 support, Service Worker missing in firefox MV3, which causes me to have to use firefox MV2, which is too much different code and causes me to have to test both browsers.

It adds a lot of maintenance costs.

Describe the solution you'd like

I will try to add it again when firefox MV3 is fully supported.

Describe alternatives you've considered

No response

Additional context

No response

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

Is your feature request related to a problem? Please describe.

For example, when twitter.com migrates to x.com, what should be done to update the old rules and prevent conflicts?

Describe the solution you'd like

One possible solution is to add a dialog to options.html that lets users choose whether they want to import new rules or delete outdated ones, etc.
The callback to open the options page and pop up the dialog should be registered in the event listener that the extension update.

Describe alternatives you've considered

No response

Additional context

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.

Is your feature request related to a problem? Please describe.

A small green or blue dot is used for flag.

This requires adding a new "action" permission to the manifest.

When the content script determines whether the current page matches the custom rule, use tabs.query to query the currentTab id and pass it to action.setBadgeBackgroundColor to set the badge.

If the content script does not have action API access, move it to a service worker.

This also requires action.setTitle() to provide some more useful information.

Describe the solution you'd like

Like this:

Describe alternatives you've considered

No response

Additional context

No response

Validations

• Check if you're on the latest Furigana Maker version.
• Follow our Code of Conduct
• Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
• I would like to implement this feature via a PR.