This should definitely be fixed:

This is to remember that the widgetsnbextension<3.6.3 constraint was set to avoid this issue. Should be removed when things are fixed.

For the moment I am considering/testing three libraries:

• Dulwich
• GitPython
• pygit2

The main criteria for me are the following:

1. Easy to install
2. Easy to use
3. Supported git features
4. Ability to work as a part of a daemon process
5. Active development

User stories

As a user, I would like to have a special link that not only opens an AiiDAlab app, but also ensure that it is installed so that I do not need to manually install an app in order to be able to use it.

As an app provider I would like to be able to provide a link that users can use to automatically install and open an app so that I can guarantee that a user can use my app without needing to manually install it.

Context

Right now we use the standard /user-redirect endpoint to be able to provide links directly to app interfaces. This however assumes that the app is already installed. In case that the app is not yet installed, it would simply result in a 404.

Proposed solution

Implement a home app install tool that implements an arbitrary application and then automatically redirects to the correct app. The URL for this tool would be of the form:

/apps/apps/home/install.ipynb?app=<app-url>&redirect=<app-entrypoint>

Example:

https://demo.aiidalab.net/apps/apps/home/install.ipynb?app=my-app&redirect=/apps/apps/my_app/start.ipynb

I got the following error but can not anchor which app cause it. It would be better if the error message is more detailed to tell the user where the app metadata structure incompatibility happened.

---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
/opt/aiidalab-home/home/start_page.py in render(self)
    106                 # Create app widget if it has not been created yet.
    107                 if name not in self._app_widgets:
--> 108                     self._app_widgets[name] = self._create_app_widget(name)
    109 
    110                 display(self._app_widgets[name])

/opt/aiidalab-home/home/start_page.py in _create_app_widget(self, name)
     66         """Create the widget representing the app on the home screen."""
     67         config = self.read_config()
---> 68         app = AiidaLabApp(name, None, AIIDALAB_APPS)
     69 
     70         if name == "home":

/opt/conda/lib/python3.7/site-packages/aiidalab/app.py in __init__(self, name, app_data, aiidalab_apps_path, watch)
    563 
    564         self.name = self._app.name
--> 565         self.logo = self._app.metadata["logo"]
    566         self.categories = self._app.metadata["categories"]
    567         self.is_installed = self._app.is_installed

KeyError: 'logo'

This is just to keep in mind that I haven't tested the home app in general and AppStore in particular against other git platforms (apart from github).

This means that if there will be an AiiDAlab App located on Bitbucket (for example) - then I cannot guarantee that the Home app will keep working normally.

The available version list will fetch the tags of the specified branch of an app. For app developer, they are willing to quickly see the newest change they merge to the default branch without making the release by adding the tag.
It would be helpful if the edge version can be list in the version list of version selector widget when the pre-release checkbok is ticked. This will allow user to install the edge commit immediatly.

The caching of apps_meta.json is already enabled employing requests_cache package, however we want to have something as lazy caching. If the repository server gets down, the caching machinery should return the cached information first and later update the cache in the background.

suggestion from Nicola - to be decided

I believe it would be nicer if the following "URL" button opened the App's URL in a new tab.

To reproduce:

1. Trigger and install of an app version that you know will fail. In that case, the output of the pip install command will remain on the screen (which is good).
2. Select a different version, retrigger an installation. The output from the previous install will not be cleared, but will be appended instead.

https://github.com/aiidalab/aiidalab-home/wiki/AiiDA-1.0-migration

just let me know @yakutovicha ; if it's not really needed now, I guess we don't need to move it

In the appstore we render all apps below each other. There is <hr> element as a visual separator, but it is not that much visible, (on one of my monitors with lower brightness, it is actually invisible).

We need to add some styling to it. We should also adjust the overall whitespace around the apps, it seems currently there's a bit too much of it.

Currently, whenever you try to navigate away from an appmode app (e.g. by clicking a URL link, or closing a tab), I almost always get a confirmation dialog, even if I didn't really interact with the page. This gets especially annoying for the home app (e.g. every time I want to close it, I need to confirm).

I would propose to disable this dialog for pages that are static, such as the home page, appstore and perhaps others.

I've tested that the following code in a jupyter code cell achieves the effect.

%%javascript
window.onbeforeunload = function() {return}

The original dialog seems to come from jupyter notebook, see file /opt/conda/lib/python3.9/site-packages/notebook/static/notebook/js/notebook.js

I've verified that even with the override, the python kernel gets killed when the app window is closed. It seems that this is handled by the appmode via the event listener here:

https://github.com/oschuett/appmode/blob/master/appmode/static/main.js#L26

Of course this would need to be tested more carefully.

@unkcpz @yakutovicha LMK your thoughts on this, happy to take this on if you agree, once we're done with the current changes.

Here's what I see on Firefox 88.0 on Linux Mint

I think the word "Description:" is redundant here. Also, there is a lot of white space between the various UI elements (might be a CSS artifact of my browser? Need to check)

Hey,
I am not sure if this is the right place to report the issue but I couldn't find a repo for the App.
When I try to launch the Geometry Optimisation and Charges calculation I get this error:

`---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
/tmp/ipykernel_583173/1428171309.py in <cell line: 18>()
16
17 # Local imports.
---> 18 from utils.mof_checker import MofCheckerWidget, CheckMofStructure
19
20 # Workchains.

~/apps/aiidalab-lsmo/utils/mof_checker/init.py in
5 from ase import Atom, Atoms
6 from IPython.display import clear_output, display
----> 7 from mofchecker import MOFChecker
8 from traitlets import Instance, Int, List, observe
9

~/.local/lib/python3.8/site-packages/mofchecker/init.py in
16 from pymatgen.io.cif import CifParser
17 from pymatgen.symmetry.analyzer import SpacegroupAnalyzer
---> 18 from structuregraph_helpers.analysis import get_cn
19 from structuregraph_helpers.create import construct_clean_graph, get_structure_graph
20 from structuregraph_helpers.hash import (

ModuleNotFoundError: No module named 'structuregraph_helpers'`

The other calculations work fine. @yakutovicha can you help here? It's also not super urgent as we won't use it in the class. Thank you!

For more details see aiidalab/aiidalab-registry#6

Currently __pycache__ is picked up as a legal app and shown on the home page.
This should be avoided.

The output from pip when installing from AppStore only shows 5 lines, which makes it quite hard to see what is happening. Also, the output does not automatically roll down while the installation is ongoing.

The output disappears after the installation is complete, although I would personally prefer if it stayed there even after the successfully install in case one wants to inspect the details (in the case we need to make it very obvious that the installation finished successfully). But here opinions can differ. :-)

Observed behavior

When installing a new app, the app store will show a confusing warning:

The installed version of this app is not compatible with this AiiDAlab environment.

See also screenshot:

Expected behavior

The app store should not check compatibility during the installation, but only after the installation has completed.

Same config as in the aiidalab package.

This is what I saw in the top-right corner of my app when I loaded the home page.

I wasn't able to reproduce this since then, but we should keep an eye.
The app statuses are displayed via the AppStatusInfoWidget, but the cause of this is likely elsewhere.

Currently there is no information shown about why an app (version) might not be compatible with the current environment. It would be valuable to display more information about potential reasons for the incompatibility.

See also this comment.

For example aiidalab-widgets-base appears without git url, which is wrong:

In Quantum Mobile, launching the mc-home app for the first time writes an empty .launcher.conf into the app directory.
This causes the app to crash, when one runs it a second time.

Since the .conf file is executed via eval, the error message is rather cryptic for python standards:

File "<string>"
SyntaxError: unexpected EOF while parsing

I'll make a pull request for this in a bit.

If one tries to go inside apps folder, but app is not present -- there should be a fallback option that leads to the app install page.

There are a couple of basic selenium tests in tests/ folder, but they are currently not being run in GHA.

These tests need to run inside the aiidalab docker image. We should port the notebook test infrastructure from AWB and re-enable the tests in CI.

Related to #18, specifically the line:

• Allows to modify the apps order

Under Home page.

This should be extended to something more specific. Namely, the ordering should be done in a more agile and easy way, instead of now, where one has to click several times to set the order of apps.

Change suggestions:

• Create pop-up window, where the order may be set.
• Have a separate notebook (with app-mode), where the order may be set.
• Drag-and-drop the existing apps directly on the home page to reorder.
• Give each app a number to the side that may be changed directly on the home page.

Here's what I see in the latest docker stack. Here the example is AWB, but other apps suffer from this as well.

Note that the button is active, but the tooltip says the app is incompatible, even though it clearly is. I've looked at the code in the app_manager.py but couldn't see an obvious problem. It's possible the underlying issue is in the aiidalab package.

This page should provide user-friendly tools to interact with AiiDA. The features might include:

• Interacting with processes
• Interacting with database
• Interacting with daemon
• Interacting with groups
• Interacting with profiles

Related issues:

• #53
• #94

i.e. that the Quantum Mobile can read and "understand" what needs to be installed for the app to work.

I believe the requirements to install into the aiida environment (as opposed to the jupyter one) are:

• aiidalab==20.11.0b1
• ipython
• ipywidgets
• jinja2
• markdown
• traitlets

Under some circumstances, updating an app can trigger a TraitError.

This bug occurred when I tried to update the OPTIMADE app via the app manager. The exact circumstances and causes for this issue are unknown, but this might be related to the local git repository and the git data from the apps metadata being out-of-sync. More investigation is required to determine the cause of the issue.

Traceback:

---------------------------------------------------------------------------
StopIteration                             Traceback (most recent call last)
/opt/conda/lib/python3.7/site-packages/ipywidgets/widgets/widget_selection.py in findvalue(array, value, compare)
    136     try:
--> 137         return next(x for x in array if compare(x, value))
    138     except StopIteration:

StopIteration: 

During handling of the above exception, another exception occurred:

ValueError                                Traceback (most recent call last)
/opt/conda/lib/python3.7/site-packages/ipywidgets/widgets/widget_selection.py in _validate_value(self, proposal)
    240         try:
--> 241             return findvalue(self._options_values, value, self.equals) if value is not None else None
    242         except ValueError:

/opt/conda/lib/python3.7/site-packages/ipywidgets/widgets/widget_selection.py in findvalue(array, value, compare)
    138     except StopIteration:
--> 139         raise ValueError('%r not in array'%value)
    140 

ValueError: 'git:refs/tags/v1.2.2' not in array

During handling of the above exception, another exception occurred:

TraitError                                Traceback (most recent call last)
~/local/aiidalab-home/home/app_manager.py in _update_app(self, _)
    279             self._show_msg_failure(str(error))
    280         else:
--> 281             self.version_selector.version_to_install.value = version
    282             self._show_msg_success("Updated app.")
    283 

/opt/conda/lib/python3.7/site-packages/traitlets/traitlets.py in __set__(self, obj, value)
    602             raise TraitError('The "%s" trait is read-only.' % self.name)
    603         else:
--> 604             self.set(obj, value)
    605 
    606     def _validate(self, obj, value):

/opt/conda/lib/python3.7/site-packages/traitlets/traitlets.py in set(self, obj, value)
    576 
    577     def set(self, obj, value):
--> 578         new_value = self._validate(obj, value)
    579         try:
    580             old_value = obj._trait_values[self.name]

/opt/conda/lib/python3.7/site-packages/traitlets/traitlets.py in _validate(self, obj, value)
    610             value = self.validate(obj, value)
    611         if obj._cross_validation_lock is False:
--> 612             value = self._cross_validate(obj, value)
    613         return value
    614 

/opt/conda/lib/python3.7/site-packages/traitlets/traitlets.py in _cross_validate(self, obj, value)
    616         if self.name in obj._trait_validators:
    617             proposal = Bunch({'trait': self, 'value': value, 'owner': obj})
--> 618             value = obj._trait_validators[self.name](obj, proposal)
    619         elif hasattr(obj, '_%s_validate' % self.name):
    620             meth_name = '_%s_validate' % self.name

/opt/conda/lib/python3.7/site-packages/traitlets/traitlets.py in __call__(self, *args, **kwargs)
    973         """Pass `*args` and `**kwargs` to the handler's function if it exists."""
    974         if hasattr(self, 'func'):
--> 975             return self.func(*args, **kwargs)
    976         else:
    977             return self._init_call(*args, **kwargs)

/opt/conda/lib/python3.7/site-packages/ipywidgets/widgets/widget_selection.py in _validate_value(self, proposal)
    241             return findvalue(self._options_values, value, self.equals) if value is not None else None
    242         except ValueError:
--> 243             raise TraitError('Invalid selection: value not found')
    244 
    245     @observe('value')

TraitError: Invalid selection: value not found

Suggested by @danielhollas,

the include pre-releases" toggle may better be hidden. If the user wants a pre-release, they should probably go to the "manage app" page anyway.

I don't fully agree with this, we have this functionality and it benefits for the user when need to keep it here. In essence, AiiDAlab encourages quick development so the pre-release should be common. Let's discuss!

This will allow to make App Store more lightweight. The install/uninstall/update buttons will be replaced with "Manage" html button that lead to the App home page.

I am not sure, whether this is the right repository for this, but I would like to keep track of an enhancement proposal that I have been thinking about for a while now.

I think it would be extremely useful to have a "factory reset" button, that would allow users (and administrators), to reset the AiiDAlab environment to "factory conditions", that means basically that the environment is completely reset. Use cases include, but are not limited to:

1. The ability to test the "new user" experience, especially for testing and in preparation for workshops etc.
2. The ability for users to reset their environment after having it rendered inadvertently unusable in some way.

It would be good to have some kind of notification systems that automatically informs users of upcoming events, maintenance periods, upcoming changes to the platform, or anything else that is noteworthy.

I imagine some kind of banner at the top that can potentially be closed by users. The way that I imagine the implementation is that we add notifications to the registry that are specific to the domain, a time period, and potentially, some other user condition (e.g. checking for the existence for certain paths or so), and which the home app then automatically checks for at start up and presents to the user.

Here is a draft for how such a registry entry could look like:

"notifications": [
  {
    "domain": "aiidalab-demo.materialscloud.org",
    "after": "2020-12-24T00:00:00",
    "before": "2020-12-25T00:00:00",
    "message": "Merry Christmas!",
    "category": "info",
  }
]

Defaults would be:

"domain": ".*",
"after": ""
"before": ""
"category": "info",

Additional notes:

• There could be an optional "condition" object, that could be used for checks. I imagine that we implement certain checks that can be made, package version, existence of a specific file etc.
• The message should be accepted in (sanitized) HTML format to make it easy to customize notifications and embed images etc.

As a user, I would like to have a simple way to upgrade my database. Ideally, there should be a message that informs me about migration and starts it when I click on the "Start migration" button.

As a developer, I would like users to be blocked for any action during the migration process.

depends on: aiidateam/aiida-prerequisites#41

For the moment, the AppBase checks updates only by comparing the commit hashes. If a specific tag is selected, the update is not checked (even if newer tag is present). This should be fixed