Giter Club home page Giter Club logo

ads---python-example-'s Issues

Refactor Test_Procedures.py New Feature

I'm looking to refactor Test_Procedures.py. I've started to do so on my forked branch, but before I make too many changes, I wanted to run a simple feature by you. I'm thinking about adding:

def __init__(self, GL, Log, GL_Column, Log_Column, output_folder):
    # save values as part of the object
    self.GL = GL

So that we can instantiate an object for each GL, i.e.:

GL_Client = Test_1_Procedures(GL = General_Ledger_MMYYYY,
                               Log = Log_File,  GL_Column = "Journal_ID",
                               Log_Column = "Journal_ID")

GL_Client.check_for_gaps_in_JE_ID()

Or we also add a function that will run all of the tests for you:

GL_Client.runAll()

# Or don't even save the object
Test_1_Procedures(GL = General_Ledger_MMYYYY,
            Log = Log_File,  GL_Column = "Journal_ID",
            Log_Column = "Journal_ID").runAll()

Audit standards

I really don't understand how this repo works. I'm I suppose top update the repo with Audit standards or what?

Wording for output in Test_Procedures.py, Procedure 1.2

For Procedure 1.2 (Test_procedures_1, procedure 2), there is a print line (line 37) that says:

        writer.writerow(['Amounts of following %a journal entries do not match their amounts in Log File:' %(len(In_LOG_not_in_GL))])

I don't think this is accurate, since we're not comparing the Amount of the JE, just the JE_ID.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.