agildata / tpcc Goto Github PK

in NewOrders.neworder

...
ResultSet rs0 = pstmt35.executeQuery();
// ResultSet rs1 = pstmt35.executeQuery();
if (rs0.next()) {
c_discount = rs0.getFloat(1);
c_last = rs0.getString(2);
c_credit = rs0.getString(3);
// }
// if (rs1.next()) {
// w_tax = rs1.getFloat(1);
w_tax = rs0.getFloat(1);
}
rs0.close();
// rs1.close();

                should merge rs0 and rs1,or jdbc will throw exception

...

mysql server's default wait_timeout is 8 hours，if some one change it to a shorter time such as 30 minutes，it will occur problems bellow:
Caused by: com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: The last packet successfully received from the server was 41,330,583 milliseconds ago. The last packet sent successfully to the server was 41,330,582 milliseconds ago. is longer than the server configured value of 'wait_timeout'. You should consider either expiring and/or testing connection validity before use in your application, increasing the server configured values for client timeouts, or using the Connector/J connection property 'autoReconnect=true' to avoid this problem.

also in load_data.sql

LOAD DATA local INFILE 'new_orders.txt' INTO TABLE new_orders; --then execute this one
LOAD DATA local INFILE 'orders.txt' INTO TABLE orders; --should execute first

Hi,
with your current implementation transaction will always "suceed". At "TpccStatements.java" you have a commit method that catch the SQL Exception. You call this method to commit transaction at "Delivery.java", "NewOrder.java", etc.

However, since you catch the SQL exception inside the commit method, you will always "return 1" at the end of a transaction.

Solution: do not catch SQL exception in "commit" method in "TpccStatements.java" and add the throws signature. This way, you will "return 0/1" properly.

Thanks,
David

in load_data_sql file, ' load data infile' should be changed to 'load data local infile'