Comments (2)
Karl,
First off — my apologies for the long delay. I'm actually currently hiking the Pacific Crest Trail, and so will be slow to respond (and not really in a position to do any coding) for the next five months or so.
I'm reluctant to add very special-purpose features like this to Fortitude…it's obviously pretty easy to build stuff like this just using the native #comment method, and you can customize it to your own precise needs. Erector always had a lot of syntactic sugar for things that, in my opinion, weren't always clearly necessary. (For example, just for me, features like this one were something I used rarely enough that I had to look up the exact syntax every time anyway…at which point it was probably easier to just use the raw comment syntax, anyway.)
Having said that, if someone wanted to build a "fortitude-erector-compat" gem (or something similar) that, for example, defined a FortitudeErectorCompat::Base subclass of Fortitude::Widget that added all that stuff in, that'd obviously be extremely useful to Erector users, and I'd be more than happy to link to it from relevant places in the (largely upcoming) Fortitude docs. If it's not already there by the time I get back, I'd be happy to work on it myself, too. I'm a big fan of this kind of code existing, in other words — I'm just not sure it necessarily should go into the Fortitude core. (I imagine in not so many years, those IE conditional comments will largely disappear from the Web entirely, as IE 6/7/8/etc. finally become relics of the past. But if we add this stuff to Fortitude, we can really never remove it without breaking compatibility, and that would suck.)
Anyway, that's my (long-winded) 2¢ on the topic. Hope that helps. Thanks for using Fortitude, and, if anything else comes up, I'd be more than happy to help in any way I can!
Thanks,
Andrew
On Apr 17, 2015, at 4:45 PM, Karl He [email protected] wrote:
See http://www.quirksmode.org/css/condcom.html
Erector supported this type of comment as a block comment.
—
Reply to this email directly or view it on GitHub.
from fortitude.
Indeed, I only mentioned it because I thought it was a rather commonplace syntax to use, but you're right that the need for it is dying out.
from fortitude.
Related Issues (20)
- Unit testing of widgets without loading entire Rails stack in test environment? HOT 2
- Script to convert to and from HTML/ERb? HOT 3
- :csrf_meta_tags helper unavailable? HOT 1
- Even more forms weirdness, or... HOT 11
- Using #inline_html with a Rails view context HOT 2
- Implicit passing of `needs` variables fails when View class is named the same as the `needs` key HOT 4
- Can't mark HTML attribute values as html_safe HOT 1
- Upgraded to Rails 4.2.5.2 and everything is blowing up HOT 3
- use controller.view_paths to resolve view paths when calculating widget_class_from_file HOT 1
- Status? HOT 8
- alias_method_chain deprecated in Rails 5 HOT 2
- fix Travis build HOT 2
- Release latest code to rubygems HOT 1
- ArgumentError: wrong number of arguments (given 5, expected 4) with ActionView 4.2.6 HOT 2
- Issues when running tests: "uninitialized constant OopRailsServer::RailsServer::Bundler" HOT 1
- Regression: automatic inclusion of Rails helpers breaks implicit route arguments HOT 6
- Fortitude prevents Rails csrf_meta_tags from being rendered in the <head> element HOT 1
- retina_images repo unavailable
- Single arity template handlers are deprecated in Rails 6.0
- Still maintained? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fortitude.