Regression: automatic inclusion of Rails helpers breaks implicit route arguments about fortitude HOT 6 CLOSED

Alright, rather than stealthily editing my first post, I'll amend it here:

It looks like I might be misinformed about the instance variables, and it's actually the current request's parameters that are implicitly passed to the path helpers. The issue still stands, though! :D

from fortitude.

This definitely is a bug! Got a working test case repro’ing it — let me fix.

from fortitude.

Sweet, thanks!

from fortitude.

OK, all fixed. It’s on a weird branch (ageweke/rails_generator_support), but I’ll merge that into master once it’s green on Travis. Fix is here.

Ironically, this issue was caused by exactly some of the stuff we were talking about in the caching thread — Rails.application.routes.url_helpers (which is a Module) was being include'd directly into Fortitude::Widget, causing those methods to end up run in the context of the widget (and thus didn’t have access to the incoming request), rather than on that magic/special helpers object that Rails creates, where they belong.

from fortitude.

Awesome, thanks for the quick turnaround!

from fortitude.

If you get a chance, it would be great to have this on Rubygems :)

from fortitude.