prj-rev-bwfs-tea-cozy's People
prj-rev-bwfs-tea-cozy's Issues
SUMMARY
Summary Grade: Satisfactory
Good job! Your files are organized nicely, and you did a great job of matching the client specification for the most part -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed excellent code practice, so make sure to keep that up!
I have made some comments in your code to take note of. First off, good job commenting the main parts of your HTML. This is something that many learners forget to do, but it goes a long way, especially as your projects grow and become more complex. Make sure to keep this up! You should also make sure to comment your stylings in your CSS, so that it's clear why you are styling elements a particular way. Here is a quick reminder on commenting in CSS:
Your code is also very nicely structured/formatted and follows excellent code practices such as readability, indentation, etc. Overall, you did an excellent job.
This isn't a big issue now since you haven't learned about this yet, but I wanted to introduce you to the idea of responsive design. You will certainly learn more about this concept in the next project, but I wanted to provide a great resource to get you to start thinking about building sites that look good on all different kinds of platforms/browser sizes:
https://www.w3schools.com/css/css_responsive_intro.asp
Great job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs.
CSS is clean and succinct
https://github.com/afloyd8/prj-rev-bwfs-tea-cozy/blob/master/TeaCozy/resources/css/style.css#L1-L140
Your CSS is short, clean and succinct -- make sure to keep it up! One area of improvement is to make sure to comment your main stylings so that it's absolutely clear why you are styling elements a particular way. Here is a quick reminder on commenting in CSS:
nice job commenting main parts of code
https://github.com/afloyd8/prj-rev-bwfs-tea-cozy/blob/master/TeaCozy/index.html#L1-L95
Good job commenting the main parts of your code, which is something that learners seem to overlook. Make sure to keep that up!
responsive design
In the next project you will learn more about responsive design, which is basically web design that lets you create content that fits different browser sizes/platforms. Here is a great resource to get you to start thinking about that:
HTML nicely structured/organized
https://github.com/afloyd8/prj-rev-bwfs-tea-cozy/blob/master/TeaCozy/index.html#L1-L95
Your HTML is very nicely structured and you generally followed excellent code practices such as indentation, readability, commenting, etc. Make sure to keep up the great work!
nav/menu not fixed to top
https://github.com/afloyd8/prj-rev-bwfs-tea-cozy/blob/master/TeaCozy/index.html#L14-L18
It seems that your nav/menu selection is not completely fixed to the top, so I would double check your CSS/styling for this part
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.