afawcett / custommetadataapi Goto Github PK

Given

• one is using the CustomMetadata Service
• one has testmethods that execute code that deploys Custom Metadata

When

• executing the testmethod

Then

• the testmethod fails because with AsyncException System.AsyncException: Metadata cannot be deployed from within a test

Class CustomMetadataTest conveniently includes public inner class MockPlatform that does useful stuff. However, if you code in your testmethod

CustomMetadataTest.MockPlatform mockPlatform = new CustomMetadataTest.MockPlatform();
mockPlatform.xxx = ... // cloning examples from CustomMetadataTest.whenUpsertingByFieldMapSendsEvent
....

you get compiler exception that CustomMetadataTest Type is not visible.

There are some workarounds:

• Reimplement CustomMetadataTest.MockPlatform in your own namespace/org (meh)
• Use !Test.isRunningTest() to decide whether to execute String deployId = CustomMetadata.Operations... (ugh)

Or, the GitHub lib can move class MockPlatform to a outer public class
Or, the GitHub lib could make CustomMetadata public instead of private
Or ... ?

Since you made CustomMetadataTest.MockPlatform public, you must have intended it to be reused in other classes.

Happy to do a PR once I understand your intent.

"On your blog, I suggested adding a custom field "context" to the
Platform Event SObject (someone else on the blog comments suggested
something similar - "topic") so the Platform Event consumer would have some
idea what use case generated the MD deployment action."

CustomMetadataValue only handles primitives, so it fails on relationship fields. The value just needs to be converted to a string before being assigned.

I've gotten it to work by changing line 140 to this: cmv.value = dsr.soapType == Schema.SoapType.ID ? String.valueOf(fieldValue) : fieldValue;

As far as I can tell this is the only type that needs special handling.

When I try to deploy via button to my dev org it fails with the below error