afaundez / jekyll-favicon Goto Github PK

View Code? Open in Web Editor NEW

18.0 18.0 7.0 457 KB

Favicon generator and tag for Jekyll.

Home Page: https://afaundez.github.io/jekyll-favicon

License: MIT License

Ruby 98.31% Shell 0.19% Dockerfile 1.50%

favicon jekyll jekyll-plugins

jekyll-favicon's People

Contributors

Stargazers

Watchers

Forkers

hedgehogcode hlascelles getaaron mir1001 jonchang ohrite semperfu

jekyll-favicon's Issues

Webmanifest does not include icons if it already exists

Describe the bug
If a webmanifest already exists, icon field is not present

To Reproduce
Steps to reproduce the behavior:

Add webmanifest.manifest in the same location favicon will generate one, usually at /.
Build the site
Check the webmanifest.manifest served

Expected behavior
The gem should read the manifest.webmanifest and generate the new webmanifest with the icons added.

Desktop (please complete the following information):

OS: MacOS
Ruby: 2.1.0

{{ favicon }} typo in README.md

I think you meant to write {% favicon %} instead of {{ favicon }}, right? :)

Update gemspec to Jekyll 4.0

Jekyll 4.0 just got released, current spec is locked to 3.+.

SVG not scaled when it includes 'width' and 'height' attributes

Describe the bug
An SVG image that has width and height attributes will not be scaled (up or down) during conversion.

I was able to bisect this down to b2e0439, when this plugin switched from scale to size.

To Reproduce
Run jekyll-favicon on a site with the following minimal SVG as its favicon.svg file:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg
   xmlns="http://www.w3.org/2000/svg"
   version="1.1"
   width="64"
   height="64"
   viewBox="0 0 64 64">
  <circle cx='32' cy='32' fill='red' r='15'/>
</svg>

This is based on test/fixtures/favicon.svg, but sized larger so cropping will be evident in the .ico output and with the problematic width & height attributes added.

Expected behavior
Image is scaled as normal, even if it has width & height specified—especially if those dimensions match those of the viewBox.

Screenshots
Source favicon.svg:

Output favicon.ico:

Environment:

OS name and version: Ubuntu 22.04 (both in GitHub Actions and in WSL1 locally)
Ruby manager name and version (if present): rvm 1.29.12
Ruby version: 3.2.2
Bundler version: 2.4.10
Jekyll version: 4.3.3
Jekyll Favicon version: 1.1.0

Additional context:

The same test SVG with just those two attributes removed works properly:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg
   xmlns="http://www.w3.org/2000/svg"
   version="1.1"
   viewBox="0 0 64 64">
  <circle cx='32' cy='32' fill='red' r='15'/>
</svg>

Note, while I reported this against Ruby 3.2.2, Jekyll 4.3.3, etc. I did go all the way back to Ruby 2.7.8 + Jekyll 4.2.2 while bisecting to track down the commit that changed this behavior. (rvm was very helpful for that!) Ruby 3.x vs. 2.x seems not to affect this problem at all.

No such file or directory

Hi, just playing with your plugin in my project. Every time I run jekyll serve and the plugin finds the icon, I get:

jekyll 3.7.3 | Error:  No such file or directory @ rb_file_s_stat - /var/folders/y9/m_5lr9mn471gxjxh9xgrmzs80000gn/T/favicon_template20180407-35527-1gy2ucn.png

My _config.yml:

favicon:
  source: assets/images/favicon.png
  path: /assets/images

My favicon is indeed in assets/images/favicon.png source. But even if I move it to project root, it does not work.
I'm using mmistakes theme if that might play a role somehow.

Unfortunately I'm very new to Jekyll so I can't really help with debugging unless you give me some hints what should I do.

Incompatible with `jekyll-minifier`?

Describe the bug
I was trying to use this plugin, but encountered with a bug. After trying to read the log, I found something with jekyll-minifier. I tried removing the jekyll-mifier plugin. This plugin works smoothly. But it gives an error with jrkyll minifier

To Reproduce
Use this plugin with jekyll-minifier

Environment:

OS: Archlinux
Ruby version: 3.0.4p208
Bundler version: 2.3.10
Jekyll version: 4.2.1
Jekyll Favicon version: 1.0.0

Log

/usr/lib/ruby/gems/3.0.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_file/convertible.rb:68:in `copy_file': wrong number of arguments (given 2, expected 1) (ArgumentError)
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-minifier-0.1.10/lib/jekyll-minifier.rb:223:in `write'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_file/convertible.rb:61:in `write'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:231:in `block in write'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:358:in `block (2 levels) in each_site_file'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:357:in `each'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:357:in `block in each_site_file'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:356:in `each'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:356:in `each_site_file'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:230:in `write'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:82:in `process'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:28:in `process_site'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/commands/build.rb:65:in `build'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/commands/build.rb:36:in `process'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `block in process_with_graceful_fail'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `each'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `process_with_graceful_fail'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
        from /usr/lib/ruby/gems/3.0.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `block in execute'
        from /usr/lib/ruby/gems/3.0.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `each'
        from /usr/lib/ruby/gems/3.0.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `execute'
        from /usr/lib/ruby/gems/3.0.0/gems/mercenary-0.4.0/lib/mercenary/program.rb:44:in `go'
        from /usr/lib/ruby/gems/3.0.0/gems/mercenary-0.4.0/lib/mercenary.rb:21:in `program'
        from /usr/lib/ruby/gems/3.0.0/gems/jekyll-4.2.1/exe/jekyll:15:in `<top (required)>'
        from /usr/bin/jekyll:25:in `load'
        from /usr/bin/jekyll:25:in `<top (required)>'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/cli/exec.rb:58:in `load'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/cli/exec.rb:58:in `kernel_load'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/cli/exec.rb:23:in `run'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/cli.rb:483:in `exec'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/cli.rb:31:in `dispatch'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/cli.rb:25:in `start'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/exe/bundle:48:in `block in <top (required)>'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/lib/bundler/friendly_errors.rb:103:in `with_friendly_errors'
        from /usr/lib/ruby/gems/3.0.0/gems/bundler-2.3.10/exe/bundle:36:in `<top (required)>'
        from /usr/bin/bundle:25:in `load'
        from /usr/bin/bundle:25:in `<main>'

Transparent background in SVG becomes white

This is basically identical to #19 but now the background is white. I don't remember if 0.2.6 has always been like this or not. Version 0.2.4 still seems to work fine in the meantime.

Gem crashes with syntax errors

Yikes, totally crashed.

~/Projects/blog>jekyll serve
Configuration file: /Users/Matthew/Projects/blog/_config.yml
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll-favicon.rb:5:in `require_relative': /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:11: syntax error, unexpected << (SyntaxError)
        <<~HTML
          ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:12: syntax error, unexpected '<', expecting keyword_end
        <!-- Begin Jekyll Favicon tag v#{Jekyll::Favicon::VERSION} -->
         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:12: syntax error, unexpected tCONSTANT, expecting keyword_do or '{' or '('
        <!-- Begin Jekyll Favicon tag v#{Jekyll::Favicon::VERSION} -->
                         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:13: syntax error, unexpected '<', expecting keyword_end
        <link href="/apple-touch-icon....
         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:13: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...ref="/apple-touch-icon.png" rel="apple-touch-icon" sizes="18...
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:13: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...g" rel="apple-touch-icon" sizes="180x180">
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:14: syntax error, unexpected '<'
        <link href="/favicon-32x32.png...
         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:14: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...k href="/favicon-32x32.png" rel="icon" sizes="32x32" type="i...
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:14: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...con-32x32.png" rel="icon" sizes="32x32" type="image/png">
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:14: syntax error, unexpected tIDENTIFIER, expecting keyword_end
..." rel="icon" sizes="32x32" type="image/png">
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:15: syntax error, unexpected '<'
        <link href="/favicon-16x16.png...
         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:15: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...k href="/favicon-16x16.png" rel="icon" sizes="16x16" type="i...
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:15: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...con-16x16.png" rel="icon" sizes="16x16" type="image/png">
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:15: syntax error, unexpected tIDENTIFIER, expecting keyword_end
..." rel="icon" sizes="16x16" type="image/png">
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:16: syntax error, unexpected '<'
        <link href="/manifest.json" rel="manifest">
         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:16: syntax error, unexpected tIDENTIFIER, expecting keyword_end
        <link href="/manifest.json" rel="manifest">
                                       ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:17: syntax error, unexpected '<'
        <link color="#5bbad5" href="/s...
         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:17: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...     <link color="#5bbad5" href="/safari-pinned-tab.svg" rel...
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:17: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...ef="/safari-pinned-tab.svg" rel="mask-icon">
...                               ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:18: syntax error, unexpected '<'
        <meta content="#ffffff" name="theme-color" />
         ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:18: syntax error, unexpected tIDENTIFIER, expecting keyword_end
        <meta content="#ffffff" name="theme-color" />
                                    ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:18: syntax error, unexpected '>'
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:19: syntax error, unexpected tCONSTANT, expecting keyword_do or '{' or '('
        <!-- End Jekyll Favicon tag -->
                       ^
/Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll/tags/favicon.rb:19: syntax error, unexpected '\n', expecting keyword_do_LAMBDA or tLAMBEG
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-favicon-0.1.0/lib/jekyll-favicon.rb:5:in `<top (required)>'
	from /Users/Matthew/.rvm/rubies/ruby-2.1.2/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:128:in `require'
	from /Users/Matthew/.rvm/rubies/ruby-2.1.2/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:128:in `rescue in require'
	from /Users/Matthew/.rvm/rubies/ruby-2.1.2/lib/ruby/site_ruby/2.1.0/rubygems/core_ext/kernel_require.rb:39:in `require'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/external.rb:58:in `block in require_with_graceful_fail'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/external.rb:55:in `each'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/external.rb:55:in `require_with_graceful_fail'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/plugin_manager.rb:30:in `require_gems'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/plugin_manager.rb:22:in `conscientious_require'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/site.rb:113:in `setup'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/site.rb:34:in `initialize'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/commands/build.rb:30:in `new'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/commands/build.rb:30:in `process'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/commands/serve.rb:93:in `block in start'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/commands/serve.rb:93:in `each'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/commands/serve.rb:93:in `start'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/lib/jekyll/commands/serve.rb:75:in `block (2 levels) in init_with_program'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `call'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/gems/jekyll-3.7.3/exe/jekyll:15:in `<top (required)>'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/bin/jekyll:23:in `load'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/bin/jekyll:23:in `<main>'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `eval'
	from /Users/Matthew/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `<main>'

It seems that whenever I add the tag `{% favicon %}` in my header, each and every page that ends up being generated into an index.html provokes the generation of the favicons.

I have more information to share. It seems that whenever I add the tag `{% favicon %}` in my header, each and every page that ends up being generated into an index.html provokes the generation of the favicons.
Is it really so that this plugin generates the favicon for each index.html?

**Important note:** If the source file for the favicon is a `PNG`instead of an `SVG`, the issue doesn't happen.

Originally posted by @hacketiwack in #39 (comment)

Extend documentation

Please extent the documentation that also the package librsvg2-bin is installed as prerequisite for Ubuntu/Debian.

safari-pinned-tab.svg not created from png source

Describe the bug
When providing a png source (assuming), the header generated includes:

<link rel="mask-icon" color="#ffffff" href="/assets/i/safari-pinned-tab.svg">

However, there's no such file so an error appears in the logs.

To Reproduce

Use any PNG as the source and run.

Expected behavior

I don't expect and SVG to be created. I just think the head line should not be added.

Screenshots
n/a

Desktop (please complete the following information):
Fedora

Smartphone (please complete the following information):
Safari

Additional context
n/a

Transparent background in SVG becomes black

I have been using version 0.2.4 to generate the favicon for my site from an SVG with a transparent background with no problems. After upgrading to 0.2.5, however, the generated favicon.ico now has a black background. I've tried a couple different SVGs with transparent backgrounds and the generated icon always has a black background.

Running into an Error

Hi,

I am running into following error.
Are you able to help me with?

/Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:430:in `visit_Psych_Nodes_Alias': Unknown alias: defaults (Psych::BadAlias)
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:345:in `block in revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `each_slice'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:343:in `revive_hash'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:167:in `visit_Psych_Nodes_Mapping'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:318:in `visit_Psych_Nodes_Document'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:30:in `visit'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/visitor.rb:6:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:35:in `accept'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:335:in `safe_load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:370:in `load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:671:in `block in load_file'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:670:in `open'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/3.1.0/psych.rb:670:in `load_file'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/configuration/defaults.rb:27:in `load_file'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/configuration/defaults.rb:21:in `load_defaults'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/configuration/defaults.rb:16:in `block in included'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_file/convertible.rb:18:in `convert'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_file/convertible.rb:14:in `convertible?'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/static_graphic_file.rb:13:in `generable?'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/hooks.rb:11:in `block (2 levels) in <top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/hooks.rb:9:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-favicon-1.0.0/lib/jekyll/favicon/hooks.rb:9:in `block in <top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/hooks.rb:103:in `block in trigger'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/hooks.rb:102:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/hooks.rb:102:in `trigger'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/site.rb:38:in `initialize'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/commands/build.rb:30:in `new'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/commands/build.rb:30:in `process'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `block in process_with_graceful_fail'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/command.rb:91:in `process_with_graceful_fail'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `block in execute'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `each'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/command.rb:221:in `execute'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary/program.rb:44:in `go'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/mercenary-0.4.0/lib/mercenary.rb:21:in `program'
	from /Users/tgermer/.gem/ruby/3.1.0/gems/jekyll-4.2.1/exe/jekyll:15:in `<top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/jekyll:25:in `load'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/jekyll:25:in `<top (required)>'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:58:in `load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:58:in `kernel_load'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli/exec.rb:23:in `run'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:484:in `exec'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:31:in `dispatch'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/cli.rb:25:in `start'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/gems/3.1.0/gems/bundler-2.3.5/exe/bundle:48:in `block in <top (required)>'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/site_ruby/3.1.0/bundler/friendly_errors.rb:103:in `with_friendly_errors'
	from /Users/tgermer/.rubies/ruby-3.1.0/lib/ruby/gems/3.1.0/gems/bundler-2.3.5/exe/bundle:36:in `<top (required)>'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/bundle:25:in `load'
	from /Users/tgermer/.gem/ruby/3.1.0/bin/bundle:25:in `<main>'

Thank you very much.
Tristan

baseurl not used on tag links

favicon tag generates wrong links when using a custom baseurl.

Infinite loop of favicon generation

Describe the bug
On macOS, when ImageMagick is installed along with Inkscape through brew.sh, the generation of a favicon from a SVG image never ends: infinite processes of Inkscape are spawn one after another.

To Reproduce
Steps to reproduce the behavior:

Install ImageMagick and Inkscape through brew.

brew install imagemagick inkscape

Install jekyll-favicon as mentioned in the documentation.
Proceed with the build

bundle exec jekyll build

The build never stops

Expected behavior
Once the build is launched, it should stop after a few seconds.

Screenshots
Not applicable.

Environment:

macOS 13.2.1 (22D68)
ruby 3.2.1 (2023-02-08 revision 31819e82c8) [arm64-darwin22]
Bundler version 2.4.7
jekyll 4.3.2
jekyll-favicon 1.1.0

afaundez / jekyll-favicon Goto Github PK

jekyll-favicon's People

Contributors

Stargazers

Watchers

Forkers

jekyll-favicon's Issues

Recommend Projects

Recommend Topics

Recommend Org