This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• fix(deps): update dependency axios to v0.21.1 [security]
• fix(deps): update apollo graphql packages (apollo-cache, apollo-cache-inmemory, apollo-client, apollo-link, apollo-link-context, apollo-link-http, apollo-link-retry, apollo-link-ws, graphql-tag)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all (@types/chai, @types/chai-as-promised, @types/debug, @types/fetch-mock, @types/lodash.find, @types/sinon, @types/uuid, @types/ws, bowser, browserify, chai, coveralls, debug, del-cli, graphql, loglevel, mocha, mockttp, offix-client, replace, source-map-support, subscriptions-transport-ws, ts-node, typedoc, typescript, uuid)
• chore(deps): update dependency lerna to v3.22.1
• chore(deps): update all (major) (@types/apollo-upload-client, @types/mocha, @types/node, @types/sinon, @types/uuid, @types/ws, apollo-upload-client, browserify, del, del-cli, fetch-mock, graphql, keycloak-js, mocha, mockttp, nyc, sinon, ts-node, typescript, uuid)
• chore(deps): update dependency lerna to v6
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Description

I'm building a sample application that uses the Security functionality and calls checkManyAndPublishMetric. I was running into an issue that stated "Missing required plugin to collect metrics".

The issue was that I had not run npx ionic cordova plugin add @aerogear/cordova-plugin-aerogear-metrics --save so the app-version plugin was missing.

Might be necessary to call this out somehow? It was easy to miss.

Steps to reproduce

1. Install the following:

    "@aerogear/app": "~0.3.0",
    "@aerogear/cordova-plugin-aerogear-security": "~0.3.0",
    "@aerogear/security": "~0.3.0",

2. Initialise using standard pattern from showcase app
3. Call checkManyAndPublishMetric
4. Error Missing required plugin to collect metrics is returned

Feature Request

At the moment, developers need to provide the JSON object of the configuration when initialise the SDK, here is an example.

In this example, the content of mobile-services.json is put into a JS file and then required by the user's application. This is due to the fact that JSON format is not universally supported by all the loaders/importers in nodejs/typescript. It is supported by the newer versions of node and typescript, but the older ones don't.

To make it easier for developers to use our SDK, we should handle the loading and parsing of the mobile-services.json file. It will:

1. Make it easier for developers to consume our SDK
2. Make it easier for us to document the setup steps.

A possible approach is to allow developers to provide the path to the mobile-services.json file as part of the SDK initialisation. The SDK will still be backward compatible if the parameter to initialise the SDK is an object. But if the parameter is a String type, the SDK will then load and parse the configuration file and build the configuration object.

$ ./scripts/docs.sh
returns:

Generate documentation for packages
lerna info version 2.11.0
fs.js:948
binding.stat(pathModule._makeLong(path));
^

Error: ENOENT: no such file or directory, stat '/home/pwright/repos/aerogear/aerogear-js-sdk/packages/metrics-cordova/src'

Description

See: https://groups.google.com/forum/#!topic/aerogear/T19gHBs9D5c
Example implementation: #18

Bug Report

Push SDK (and probably others) are working exclusively with mobile-services config.
However Push UI still have examples using old type of config that do not require many different elements like versions etc. We should enable passing direct push configuration for situations when no mobile-config (open shift) is present.

See: aerogear/datasync-starter#94

Bug Report

When starting SDK in any app following error appears a couple of times:

vendor.js:21535 Error when sending metrics {"stack":"Error: Metrics server configuration is missing. Metrics will be disabled.\n    at MetricsService.

there is no way to suspend it. Not having metrics enabled is not an error so we might remove this to not obfuscate logs.

ping @austincunningham

Bug Report

When performing a login to Keycloak without InAppBrowser on iOS I received a failure with this error in the console TypeError: null is not an object (evaluating 'ref.addEventListener').

• Affected Package(s): aerogear/auth
• Package version(s): 2.4.0
• Platform (e.g. Android/iOS): iOS
• Platform Version: 12.0 Simulator
• Cordova Version: CLI 9.0, [email protected]
• Node.js / npm versions: 10.15 / 6.4

I created a simple Cordova application using cordova create, then added the SDK, bundled via browserify with the following:

const app = agInit(config)

// initialise auth
const Auth = require('@aerogear/auth').Auth;
const authService = new Auth(app.config);
const initOptions = { onLoad: "login-required" };

authService.init(initOptions)
    .then(() => {
        // successful init & authentication
        alert('success')
    })
    .catch((err) => {
        // initialization error
        alert('fail')
        console.error(err)
    });

Running the app with this printed TypeError: null is not an object (evaluating 'ref.addEventListener'). After I added InAppBrowser the issue was resolved.

Maybe we need to check for InAppBrowser and report a better error depending on platform?

Motivation

Use more efficient storage solution that do not perform JSON.stringify etc.
Proposed option: https://github.com/localForage/localForage

Description

Based on the comment here (#91 (comment)) we could refactor checking for plugins into a helper function in platformUtils. Instead of null checking we could then do something like

IRoot = await platformUtils.getCordovaPlugin<IRoot>("IRoot");

There is no simple way to see persisted objects in cache. Adding debug flag is possible but currently, there is no way to do it without recompiling distribution binary.

We had that information in the README.md before but it was removed.

ping @austincunningham

Description

Link to example of mobile-services.json is broken in docs.

Steps to reproduce

1. Navigate to https://github.com/aerogear/aerogear-js-sdk/blob/master/docs/auth/README.adoc#configuration-file
2. Scroll to 'Configuration File' section
3. Click on 'mobile-services.json' link

Actual: Error 404 page.
Expected: Link should be valid and should navigate to examples.

Description

I've tested the root checks on my Nexus 5 device and found that our default check is not sufficient for certain devices.

We are invoking IRoot.isRooted(), but on my device this doesn't catch the root. I need to invoke IRoot. isRootedRedBeerWithoutBusyBoxCheck() which correctly detected the root as did IRoot.isRootedRedBeer().

I'm not 100% sure what solution is best here from an Android perspective. Maybe check both isRootedRedBeer and isRootedRedBeerWithoutBusyBoxCheck? If the isRootedRedBeerWithoutBusyBoxCheck returns false then assume it's a false positive per this doc?

Steps to reproduce

1. Root or obtain rooted Android Device
2. Invoke return this.securityService.check(SecurityCheckType.notRooted)
3. Verify that check.passed is false

Description

Currently conflict resolution is implemented as global function that can be customized by checking different mutation names. We could change that so users will provide object with names of mutations and specific conflict resolutions that needs to happen.