aerawatcorp / bikram Goto Github PK

The constant defined for the first 2 months in Bikram sambat seems to be incorrect for the year 2062 B.S. Which was converting the dates incorrectly.

Date conversion Issue:

Incorrect constant issue:

Actual days in Baisakh and Jestha for year 2062 B.S.

It should return YYYY-MM-DD so that string representation is predictable and similar to datetime.date

• Python Bikram Samwat version: 2.1.0
• Python version: 3.8.2
• Operating System: Linux Mint 19

Description

Adding samwat object with timedelta object didn't return the correct output.

What I Did

samwat(2000, 2, 2) + timedelta(days=1)
Out[1]: samwat(2000, 10, 21)

Expected output --> samwat(2000, 2, 3)

https://github.com/poudel/bikram/blob/5a669c66e5a447c2e5c67576ed1adf3eb34969a3/bikram/constants.py#L66-L157

was curious how did you get those values?

• Python Bikram Samwat version:
• Python version:
• Operating System:

Description

need to check for a max day in the month

• samwat-constructor
• samwat().replace(day=?)

What I Did

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

Currently it parses the date, but does not format the date object to string.

I had done a similar converter few months ago, and when I was thinking of taking it to public, I found yours.

Upon curiosity, the first thing I checked was the map of dates :)
My approach was something like this

2087-9-1 => December, 17 2030 | <span>२०८७ पौष १</span>
2087-10-1 => January, 15 2031 | <span>२०८७ माघ १</span>
2087-11-1 => February, 14 2031 | <span>२०८७ फाल्गुण १</span>
2087-12-1 => March, 16 2031 | <span>२०८७ चैत्र १</span>
2088-1-1 => April, 15 2031 | <span>२०८८ बैशाख १</span>
2088-2-1 => May, 15 2031 | <span>२०८८ जेठ १</span>
2088-3-1 => June, 15 2031 | <span>२०८८ आषाढ १</span>
2088-4-1 => July, 17 2031 | <span>२०८८ श्रावण १</span>
2088-5-1 => August, 18 2031 | <span>२०८८ भाद्र १</span>

The first date of the month in BS calendar stored with the equivalent Gregorian Calendar date.