Options and values from suggestion list do not have description and icon.
Properties from suggestion list do not have type

Steps:

1. Type any code
2. Start typing expression after "$" character
3. Invoke completion
4. Observe suggestion list

Actual:
Options and values from suggestion list do not have description and icon
Expected:
Options and values from suggestion list have description and icon

Currently collections as part of call chain aren't resolved properly
e.g.

• ${bean.collection[1].field} for collection which is inheritor of List here the field should be taken from the type which is the type which parametrizes the collection
• ${bean.map['key'].field} for map

• data-sly-use
  sort completion items to contain more relevant at the top

• variable completion (${<caret>})
  the most relevant items according to current position should be proposed

Mark following constructions as warnings:

data-sly-use.bean="${'com.test.Model'}"

Quick fix action should be provided:

"${'com.test.Model'}" -> "com.test.Model"

Add inspection which will make warning for following case:

<sly data-sly-unwrap>
  ...
</sly>

The inspection should say: "data-sly-unwrap is redundant for "sly" tag"

Message with detailed information about the error is displayed in inappropriate way

Steps:

1. Type any code in editor area
2. Make any syntactic error
3. Hover over an error marker
4. Observe appeared message

Actual:
Message with detailed information about the error is displayed in inappropriate way
Expected:
Message with detailed information about the error is displayed as for other languages supported in Idea

Given:

<div data-sly-use.bean="${'com.test.BeanName' @ option='value'}" >
${bean.<caret>} // here bean's fields aren't resolved

"Show quick documentation" action triggered on HTL attributes should show description of attributes

Some tests use full JDK taken from path, evidently loading full JDK for single test is huge overkill.
Some lightweight version of JDK should be used instead

Context object should have icons describing whether current object is a class or interface

Custom panel which should contain list of AEM groups:

/dev
  - author
  - publish
/qa
  - author
  - publish1
  - publish2

Rename refactoring should work for following cases:

1: data-sly-use

<div data-sly-use.bean="${'com.package.ClassName'}> // Rename triggered on `ClassName` should rename corresponding class also

<div data-sly-use.bean="com.package.ClassName"> // the same behaviour as above

2: Sly variable rename

${bean.field} // rename of should work for `bean`

3: Model field rename

${bean.field} // rename of `field` should rename the name of corresponding field in underlying java class

4: Model method rename

${bean.method} // rename of `method` should rename the name of corresponding method in underlying java class

Highlight unused Htl variables:

• data-sly-use.varName="..." // varName should be annotated as unused if it not accessed in current file
• data-sly-template.template="${@ param}" // param should be annotated if it not used within the template's body
• data-sly-list.var, data-sly-repeat.var // in both cases var should be annotated if both var and varList aren't used
• data-sly-test.variable // variable should be annotated if it is not used within current file

Add documentation for itemList variable's fields

Utilize depfinder (/system/console/depfinder) features, given
The project is associated with certain AEM instance(s), (via AEM Selector panel), the "AEM: Analyze dependencies" action available.
The action should collect all dependencies per module and check if they're present in connected AEM instance(s)

Found issues should be printed into log console (TBD)

The variables declared in data-sly-list and data-sly-repeat should be resolved properly.

The reference for non-normalized method name is not resolved

package com.test;

public class TestClass {
    public String getField() { 
        return "Test";
    }
}

The HTL file:

<div data-sly-use.bean="com.test.TestClass">
    ${bean.getField} // isn't resolved
</div>

<div data-sly-use.bean="${'com.package.BeanClass`}">
  ${bean.field}
</div>

• The QD action triggered on com.package.BeanClass and on bean should show the class's top level documentation
• QD on field should show documentation of corresponding "getter" or field

QD = Quick Documentation (ctrl+q)

"Quick documentation action" triggered on htl options should show description of the option

e.g.

   ${@ context='unsafe'}

"Quick documentation action" triggered on context should show description of context (should be taken from here: https://docs.adobe.com/docs/en/htl/docs/getting-started.html?wcmmode=disabled)

The list of standard options:

"join",
            "i18n", "context", "format", "locale",
            "type", "timezone", "scheme", "domain",
            "path", "prependPath", "appendPath",
            "selectors", "addSelectors", "removeSelectors",
            "extension", "suffix", "prependSuffix", "appendSuffix",
            "query", "addQuery", "removeQuery", "fragment"

Add completion for data-sly-call

  data-sly-call="${<caret>}" // here should be list of all templates available in current scope, including those spawned by `data-sly-use`

  data-sly-call="${template @ <caret>}" // here should list of parameters declared in template

Variable type isn't resolved properly for following cases:

   <div data-sly-list="${list1}">
   </div>
   <div data-sly-list="${list2}">
        ${item.<caret>} // variants from list1 will be proposed
   </div>

Add completions for data-sly-resource

    data-sly-resource="${'path' @ <caret>}" // the "resourceType" should be proposed as first variant for completion
    data-sly-resource="${'path' @ resourceType="<caret>"} // list of all resource types declared in the current project should be proposed

Resolve file name in following constructions:

   data-sly-use="${'file.html'}"

All htl files within a component should receive component's properties declared in component's dialog (for Touch UI)
given:

/jcr_root/apps/app_name/components/test/_cq_dialog/.content.xml

Has properties with names property1 and property2
then all htl files under
/jcr_root/apps/app_name/components/test/
Should have aforementioned properties proposed in following case:

    ${properties.<caret>} // -> `property1` and `property2` should be present among other variants

The variants declared in dialog should be marked as "dialog property" (via type text)

Go to declaration action will be implemented in separate ticket: #90

All HTL/HTML files containing data-sly-template attributes should be proposed as a variants for data-sly-use
Templates declared in current directory should have higher priority

Propose common variants for context objects:

{
  "properties": [
    "jcr:title",
    "jcr:description",
    "jcr:primaryType",
    "jcr:mixinTypes",
    "jcr:createdBy",
    "cq:lastReplicationAction",
    "cq:lastReplicatedBy",
    "jcr:lastModifiedBy",
    "jcr:lastModified",
    "cq:lastReplicated"
  ],
  "pageProperties": [
    "jcr:title",
    "jcr:description",
    "jcr:primaryType",
    "jcr:mixinTypes",
    "jcr:createdBy",
    "cq:lastReplicationAction",
    "cq:lastReplicatedBy",
    "jcr:lastModifiedBy",
    "jcr:lastModified",
    "cq:lastReplicated"
  ],
  "inheritedPageProperties": [
    "jcr:title",
    "jcr:description",
    "jcr:primaryType",
    "jcr:mixinTypes",
    "jcr:createdBy",
    "cq:lastReplicationAction",
    "cq:lastReplicatedBy",
    "jcr:lastModifiedBy",
    "jcr:lastModified",
    "cq:lastReplicated"
  ]
}

The above variants should be proposed in for nested objects too, e.g.:

   <div data-sly-list="${currentPage.listChildren}">
        ${item.<caret>} // variants for Page should be proposed 
   </div>

I have model

@Model
class MyModel {
   protected String getName() {
        return "str";
   }
}

and have inherited class from this model

@Model
class MyChildModel extends MyModel {
}

and in html file I define MyChildModel and I want use inherited method

<sly data-sly-use.model="MyChildModel">
    <p>model.name</p>
</sly>

Action: I try go to defining of method via Ctrl + Click on name.

Expected: I go to declaration of this method.
Actual: Nothing happens

• Filter out data-sly-unwrap in case if it is already present in tag's attributes or if the tag's name is "sly"
• Filter out data-sly-list
• Filter out data-sly-repeat

Check other attributes. In case if some attribute doesn't make sense to be present multiple times within one tag, filter it out

Given:

HTL:

<div data-sly-use.bean="com.test.Bean">
 ${bean.getProperty}
 ${bean.property}
</div>

Java bean:

public class Bean {
  public String getProperty() { return ""; }
}

"Find usages" action triggered on getProperty method will return only one occurrence: "bean.getProperty"

The "bean.property" is ignored.

Cannot comment code in html via Ctrl+/ in *.html files.

<div data-sly-template.templateName="${@ param1, param2}">
    ${<caret>}
</div>

In given example param1 and param2 should be present among other completion variants

HTL parser reports error in following case:

${ term1 && term2 || term3 ? "one" : "two"}

The reference to field/method isn't resolved properly for following case:

<div data-sly-list="${bean.list}">
    ${item.field} // no reference for field
</div>

The completion for following case doesn't work:

  ${variable @ option=<caret>}

Here the list of context objects and file variables should be shown.

  ${@ context=<caret>} --> the list of context values will be showed

The list of context values should be shown in that case ${@ context='<caret>'}

Implement brace matching for HTL

  ${someProperty} // if cursor is after '}' the opening brace should highlighted
  ${ ['1', '2', '3'] } // the same for the array

When I try to find element defining via Ctrl + Click I can not find need element.
Description picture.

Mark following constructions as warnings:

data-sly-include="${'included.html'}"

Quick fix action should be provided:

"${'included.html'}" -> "included.html"

File imports via data-sly-use should be resolved (i.e. they should be openable by ctrl+click)

   data-sly-use.model="model.js"
   data-sly-use.template="template.html"

The reference to method/field isn't positioned correctly for following case:

  ${bean['field']}

Create custom action
AEM: run TAR optimization

Steps to reproduce:
type any html/htl tag in editor:

move the cursor into the body of the tag and press enter.
As a result incorrectly formatted tag (nesting of tags isn't processed) :

Expected result:

Propose variants for data-sly-include

   data-sly-include="<caret>" // the list of HTL files from the same directory as the edited file should be proposed

Ability to open class by ctrl+click

<div data-sly-use.bean="${'com.package.BeanClass'}">
    ${bean.field}
</div>

• Click on com.package.BeanClass should navigate to class declaration
• Click on bean should navigate to bean declaration within same file (to data-sly-use.bean)
• Click on field should navigate to corresponding "getter" method (or field) within the class

The HTL should be injected only under jcr_root folder.
Also, the HTL files should be provided with custom icon to make it easier to distinguish them from ordinary HTML files

Resolve file reference in following constructions:

    data-sly-include="${'file.html'}"

Add support of smart completion for data-sly-use value.

1. From Use classes and Sling models should be proposed those which have name similar to the component's
2. Should be proposed html files containing data-sly-template elements from the same directory

Currently standard XmlAttributeInsertHandler is used to handle insertion of Htl attributes, it simply adds ="" after insertion and puts the caret inside.

The behaviour should be tuned to make it more convenient to insert different types of attributes

• data-sly-test -> data-sly-test.="${}"
• data-sly-use -> data-sly-use.=""
• data-sly-list -> data-sly-list="${}"
• data-sly-repeat -> data-sly-repeat="${}" (I think that it is more convenient to omit the variable name in list and repeat attributes as it is not mandatory)
• data-sly-attribute -> data-sly-attribute.="${}"
• data-sly-element -> ???
• data-sly-call -> ???
• data-sly-include -> ???
• data-sly-uwrap -> data-sly-unwrap
• data-sly-text -> data-sly-text="${}" (check if the attribute has name?)
• data-sly-resource -> ???

the first position of the caret.
the second position of the caret.
??? -> requires additional investigation