adventech / sabbath-school-ios Goto Github PK

The link when Recommending Sabbath school directs to to the Adentech website. It would be better suited if the link were to direct to the App Store page. For some other reason when sharing the Sabbath School from the App Store it also does not have a link to download the app.

• If no LAST_QUARTERLY_INDEX_OPENED cached proceed as below:

  • Get all languages available (cache or remote)
  • Get current system language or cached language (current)
  • Check if current is in the list of all available languages
    • If yes - then get quarterlies to that language and move this to the top of the list
    • If no - then fallback to English
  • If users changes current to another language -> cache new language

• If there is LAST_QUAETERLY_INDEX_OPENED cached immediately launch Lessons Screen with this LAST_QUAETERLY_INDEX_OPENED

I've run into an issue where after I highlight a section of text that section of text disappears. The text will reappear after I go to the lesson list page and back to the lesson I was reading. This issue appears to happen when highlighting text (anything but the first sentence) beneath a notes section.

https://www.dropbox.com/s/ix183tj5d0inva6/ScreenRecording_10-31-2018%2011-55-28.mp4?dl=0
https://www.dropbox.com/s/mecofft2djfqmow/ScreenRecording_10-31-2018%2011-50-51.mp4?dl=0

Hey @VitalikL, I noticed that you have localized strings for "Read" and "Open".

However, they don't seem to be working. Try changing the language to anything other than English -- it'll still read "READ" and "OPEN". If this is intentional, then feel free to close this ticket.

I'm assuming it's not intentional though, since you have localized strings for them.

Took a quick look at the code, and it looks like the culprit might be the uppercasing:
"Open".localized().uppercased()

I have a hunch that the localization will work if we removed the uppercase and did:

"Open".localized(). If I were to venture a guess, perhaps its because some languages (like Korean) don't really have a notion of uppercase characters, so Swift is just defaulting to the non-localized, English versions?

In any case, if that's true, feel free to confirm. I'll then send in a pull request with the fixes.

Allow users to use native iOS settings as well as in-app settings to control functionalities:

• Theme settings of reader
• Font size settings of reader
• Typeface settings of reader
• About section of the app
• Privacy policy link (TODO)
• Social links

When you open the font settings, the size slider is on the right of the slider. After changing the size and leaving in the middle, the font size changes to desired size but upon opening settings again, the indicator is at the right again.

Highlight text and tap on Share option, nothing happens on iPad.

There’s a bug on iPad when selecting the “Recommend Sabbath School”. Attached a screenshot for reference.

iPad Pro 10.5
iOS 13.1.2

As a sabbath school student,
I want the ability to see the lesson's Title and Memory Text as a widget in any platform and be actionable (click and open Today's lesson),
so that I can be reminded to read the lesson any time I am free.

• Sometimes when swiping the parallax does not allow to scroll up

Mark as coming soon

While in Read Screen - keep screen on from going to sleep

Let users know that we need help

• Lessons content
• App development
• Design
• New languages access / publishing house agreement
• Translations
• Social Media & etc

How to reproduce :

1. write a note on the verse, and it will add the height
2. After that close the lesson and then open again

• Should Support multiple Bible text versions (as per API)
• Should not have highlights / comments functionality (properly use reader app)

I can’t find a way to highlight lesson text on the iPad after typing in answers. When I try, the text area is selected and the highlight tools don’t work. The only way out, is to go back to the lesson index and then enter the lesson again.

How to reproduce :

1. Select text to highlight
2. Open a verse and then close the verse
   

This workspace has projects that contain source code developed with Swift 3.x. This version of Xcode (11.0) does not support building or migrating Swift 3.x targets.

Use Xcode 10.1 to migrate the code to Swift 4.

Doesn’t update to 2019 lessons
No possibility to manually recreate DB.
Simply as that.

Also would be good to access old lessons.

(iOS 12)

• Allows to enable local notifications about today's reading
• Controllable in settings

Does not update layout on orientation

Any image downloaded / displayed should be cached

In case of logout

• Clear all temporary cache (like user data & last quarterly opened & etc)
• Redirect to Login screen

We need to handle urls tô open on external browser like SFViewController, right know if you click it open on the lesson webView...