adomasa / learninghive Goto Github PK

I think same restrictions should be enforced for past and present training days.

Originally posted by @AidasKil in #17

This part doesn't work. If entity with specified id doesn't exist exception is thrown only if non id properties are accessed. You can make topic be its own parent when creating it. Also can make topic be its own parent when updating.

Originally posted by @AidasKil in #4

@domanttas Also I think it would be good to display the email user is registering for in the registration window. Doesn't seem like there is a way for frontend to find out what the email is. Maybe it could also be included in the invitation link.

_Originally posted by @AidasKil in #15

Probably shouldn't. Added a todo comment for now, but let's discuss how exactly this should work during our next call.

Originally posted by @AidasKil in https://github.com/adomasa/learninghive/diffs

{ "status": 409, "error": "Conflict", "message": "Can only change description of training day that is in the past", "trace": "distributed.monolith.learninghive.model.exception.ChangingPastTrainingDayException: <..>" "path": "/trainingDay" }

This requires to always include content and title when updating a topic, even if you don't want to change them.

Originally posted by @AidasKil in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjUwMzA5ODg0OnYy/pull_request_review_threads/discussion