Giter Club home page Giter Club logo

aio-lib-web's Introduction

Version Downloads/week Node.js CI License Codecov Coverage

aio-lib-web

Utility tooling library to build and deploy Adobe I/O Project Firefly app static sites to CDN

Explore

Contributing

Contributions are welcomed! Read the Contributing Guide for more information.

Licensing

This project is licensed under the Apache V2 License. See LICENSE for more information.

aio-lib-web's People

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

aio-lib-web's Issues

An in-range update of aws-sdk is breaking the build 🚨

The dependency aws-sdk was updated from 2.589.0 to 2.590.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.590.0

See changelog for more information.

Commits

The new version differs by 1 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Parcel 2 requires node 12.2, so we do too

Expected Behaviour

Actual Behaviour

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

An in-range update of webpack is breaking the build 🚨

The dependency webpack was updated from 4.41.2 to 4.41.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for v4.41.3

Security

  • force upgrade terser-webpack-plugin dependency for security fix (not affecting webpack)

Funding

  • add npm funding field to package.json
Commits

The new version differs by 5 commits.

  • df9f3eb 4.41.3
  • fe71d68 Merge pull request #10010 from webpack/funding
  • b396d96 Merge pull request #10123 from pustovalov/webpack-4-serialize
  • 29b2bdd Update terser-webpack-plugin to ^1.4.3
  • bedb566 chore: funding field

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of aws-sdk is breaking the build 🚨

The dependency aws-sdk was updated from 2.603.0 to 2.604.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.604.0

See changelog for more information.

Commits

The new version differs by 2 commits.

  • 047cfb0 Updates SDK to v2.604.0
  • d1cd4f0 Updated ---feature-request.md (#3050)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

evaluate moving to parcel v2

parcel-bundler v1.x is now deprecated, and showing this message:

DEPRECATED ⚠️  - Parcel v1 is no longer maintained. Please migrate to v2, which is published
under the 'parcel' package. See https://v2.parceljs.org/getting-started/migration for details.

We need to verify that everything still functions as expected, since this is a major bump.
Also, of note, parcel still lists 'latest' as a beta version => 2.0.0-beta.2

An in-range update of @adobe/aio-lib-core-config is breaking the build 🚨

The dependency @adobe/aio-lib-core-config was updated from 1.0.15 to 1.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@adobe/aio-lib-core-config is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Commits

The new version differs by 24 commits.

  • 019e817 Incremented version to 1.1.0
  • 4cf1e30 Remove node v.8 testing
  • f5a3598 chore(package): update eslint-plugin-jest to version 23.2.0 (#26)
  • f9d21b6 chore(package): update eslint-plugin-node to version 11.0.0 (#25)
  • 4a23791 chore(package): update eslint-plugin-jest to version 23.1.1 (#24)
  • ffc2b8e chore(package): update mock-stdin to version 1.0.0 (#22)
  • 07ba13c chore(package): update eslint-plugin-jest to version 23.0.4 (#21)
  • 8ddcf66 chore(package): update eslint-plugin-jest to version 23.0.3 (#20)
  • 2684ad4 Remove dep with pin for [email protected], [email protected] was released that patches the issue. (#18)
  • 47818f5 chore(package): update eslint-plugin-jest to version 23.0.2 (#15)
  • 3f8d8ee chore(package): update eslint-plugin-jest to version 22.19.0 (#12)
  • 45088ab Add .npmrc (no tag version prefix) (#13)
  • 3649863 Update bug_report.md
  • 45cdef8 Update CONTRIBUTING.md
  • e67e2f9 Update README.md

There are 24 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of aws-sdk is breaking the build 🚨

The dependency aws-sdk was updated from 2.594.0 to 2.595.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.595.0

See changelog for more information.

Commits

The new version differs by 1 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Actions generated by wskdebug don't get removed upon undeploy

Expected Behaviour

When called at the root of a CNA project folder, aio cna undeploy should remove all the actions and package used by this CNA.

Actual Behaviour

If the application is run and debugged remotely (aio cna run + CNA debugging with wskdebug profile), some proxy actions are created within the application package.
These actions are not stored in the manifest.yml and therefore not handled by https://github.com/adobe/adobeio-cna-scripts/blob/master/scripts/undeploy.actions.js

This results in an error like on the screenshot below:

Screenshot 2019-08-27 at 18 44 28

Reproduce Scenario (including but not limited to)

Please look at the steps below:

  • CNA creation
  • CNA add another action (e.g. 'goodbye')
  • CNA remote debugging of the 'hello' action
  • CNA deploy
  • CNA undeploy

Steps to Reproduce

$ aio cna init helloworld //just use the wizard default values
$ cp _your_dot_env helloworld/
$ cd helloworld

// add a second action in the actions folder and declare it in the manifest.yml
// for example 'goodbye', with a simple index.js implementation

$ aio cna run

// just set a breakpoint in the hello index.js file and launch a debugging session...
// Quit the debugging session and go back to your term

$ aio cna deploy
$ aio cna undeploy

// Error happens, the goodbye_wskdebug_original action is not undeployed

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

Please see the screenshot

An in-range update of webpack is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency webpack was updated from 4.42.1 to 4.43.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

webpack is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for v4.43.0

Features

  • add module.hot.invalidate() to HMR API

Dependencies

  • push versions for forced security updates
Commits

The new version differs by 17 commits.

  • c9d4ff7 4.43.0
  • 9a2febd Merge pull request #10715 from webpack/hmr/invalidate-4
  • a53bb8f add invalidate method to HMR
  • 4c644bf Merge pull request #10518 from TechieForFun/webpack-4
  • 9efaba2 Merge pull request #10571 from mjziolko/watchpack-vuln
  • a704715 Merge pull request #10622 from webpack/ci/fix-azure
  • 7f843e8 fix vm images in azure
  • 9c23e18 Update watchpack to the most recent minor version to remove mimimist vulnerability.
  • 499b537 revert unneccessary changes
  • c9bb7a9 Update snapshots of tests
  • 4023e8c Update package.json, yarn.lock
  • 2ca966c Update package.json
- [`a7cfbfe`](https://github.com/webpack/webpack/commit/a7cfbfe0b16a2a34e13491e7cecdbc0676904786) Update package.json - [`f97fedc`](https://github.com/webpack/webpack/commit/f97fedc0c63a546e9f2eee8a3513ef0cd1624af4) Update package.json for tests - [`3320b9d`](https://github.com/webpack/webpack/commit/3320b9dfd88785d1bbc15d51dc8dc05f09445f99) Update on yarn.lock

There are 17 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Linux: no connection to localhost:3233

Do you provide support for Linux?

In the following setup:

  • Fresh Debian 10 installed
  • AIO-CLT installed
  • Docker installed
  • App generated with a "generic" action.

there is an issue:

The application is not available when trying to start using aio app run --local
A timeout is given.

I tried the following:

Docker's network interface is docker0 with IP 172.17.0.1

3: docker0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
    link/ether 02:42:99:4a:ab:f8 brd ff:ff:ff:ff:ff:ff
    inet 172.17.0.1/16 brd 172.17.255.255 scope global docker0

I changed this file manually:

/home/marko/.nvm/versions/node/v12.14.1/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-app-scripts/scripts/dev.js

const OW_LOCAL_APIHOST = 'http://172.17.0.1:3233'

This is working now.

I also tried to put

AIO_RUNTIME_APIHOST=http://172.17.0.1:3233

to .env before starting using aio app run --local. But this didn't work

Cache issue for deployed SPA updates

Expected Behaviour

An end-user should always access the latest deployment of a Project Firefly SPA from the browser.
This means that the browser should load the latest version of the static files from the cache.

The TTLs are defined as follow:

  • 1 min for HTML
  • 7 days for every other mime type

The Parcel bundler generates content hashes for the static files, which are used as selectors to ensure the expected behavior.

Actual Behaviour

The Parcel bundler doesn't generate new hashes upon static files updates, which forces the end-user to manually clean the browser cache in order to use the latest SPA deployment.

Reproduce Scenario (including but not limited to)

  • Create a new SPA using the aio CLI
  • Deploy the SPA using aio app deploy
  • Access the deployed SPA from your browser
  • Update the SPA front-end code (e.g. update some JS or CSS file)
  • Redeploy the SPA using aio app deploy
  • Even after one minute delay and page refresh, the deployed changes are not loaded in the browser
  • Manually clean the cache of your browser or access the deployed SPA from another browser
  • The deployed changes are loaded in the browser

An in-range update of aws-sdk is breaking the build 🚨

The dependency aws-sdk was updated from 2.627.0 to 2.628.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.628.0

See changelog for more information.

Commits

The new version differs by 2 commits.

  • 715152d Updates SDK to v2.628.0
  • 8367b11 Bump codecov from 1.0.1 to 3.6.5 (#3105)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Cleanup Readme

  • Better dev command instructions
  • remove todos for dev command

Boolean("false") is true

In my node verision (v12.13.0), when the constructor for Boolean (at the line [1]) gets a string "false" as an input, the return is a boolean with a value true. It deals with any non-empty string as a true value.

One possible solution is to replace this line with (similar to [2]):
config.actions.devRemote = Boolean(process.env.REMOTE_ACTIONS === "true")

[1] https://github.com/adobe/aio-app-scripts/blob/3c6fc2bbfe6f53092fce55f9787513d4de803fb6/lib/config-loader.js#L111
[2] https://stackoverflow.com/a/264037

Tests fail for different filesystems

expectAppFiles has deep expectations of what the root file system looks like.
The tests should not actually touch the file system at all.

  ● with local actions and no frontend β€Ί should cleanup generated files on SIGINT

    expect(received).toEqual(expected) // deep equality

    - Expected
    + Received

      Set {
        "actions",
        "manifest.yml",
        "package.json",
    +   "repos",
        "web-src",
      }

      163 |   if (files.has('Users')) files.delete('Users')
      164 |   if (files.has('home')) files.delete('home')
    > 165 |   expect(files).toEqual(expectedFiles)
          |                 ^
      166 | }

ACNA-894 - Action running in local cannot be debugged

Expected Behaviour

Create an app, run the app with "--local", add a breakpoint in run the action and run the debugger. When action is executed, the debugger pause the execution.

Actual Behaviour

The debugger does not start.

Steps to Reproduce

On a fresh new app, run aio app run --local.
Open VC Code and hit the Run Action:<app>-0.0.1/<action> button from the debugger.

The debugger starts but crashes immediately:

Error: Action not found: <app>-0.0.1/<action>
    at AgentMgr.peekAction (/Users/acapt/work/dev/helix/playground/test/node_modules/@openwhisk/wskdebug/src/agentmgr.js:104:19)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Environment Info

  System:
    OS: macOS 10.15.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 2.60 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.21.0 - ~/.nvm/versions/node/v10.21.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - ~/.nvm/versions/node/v10.21.0/bin/npm
  Virtualization:
    Docker: 19.03.12 - /usr/local/bin/docker
  npmGlobalPackages:
    @adobe/aio-cli: 3.7.0

Workaround

I found the issue: the .env file contains the runtime_auth and runtime_namespace twice (almost lower case and uppercase) and the debugger use the lowercase one while it should use the uppercase one.
In fact, the "local override" does not work anymore because of the letters case.

AIO_runtime_auth=abc
AIO_runtime_namespace=def
SERVICE_API_KEY=
AIO_LAUNCH_URL_PREFIX=https://experience.adobe.com/?devMode=true#/custom-apps/?localDevUrl=
AIO_RUNTIME_APIHOST=http://localhost:3233
AIO_RUNTIME_AUTH=xyz
AIO_RUNTIME_NAMESPACE=guest

Workaround is to stop the server, edit the .env and uppercase the 2 variables: AIO_RUNTIME_AUTH and AIO_RUNTIME_NAMESPACE.

cc @meryllblanchet

Hidden files starting with a dot like .DS_store will make aio app build/run/deploy fail

Expected Behaviour

Γ io app run|deploy|...should work even if there are hidden files in theactions` folder.

Actual Behaviour

When there is any hidden file in the actions folder, building actions will fail.
aio will complain about the hidden file not being a folder.
This happens a lot on mac os if the OS creates hidden .DS_Store files (e.g. if you sort your icons by name).

Reproduce Scenario (including but not limited to)

Add a hidden file in the actions folder and try to build an aio app.

Steps to Reproduce

  • Create a hiden file starting with a dot ..
  • Put this file into the actions folder.
  • Try to build the aio-app.

Platform and Version

MAC OS X, latest aio.

Sample Code that illustrates the problem

N/A

Logs taken while reproducing problem

N/A

An in-range update of @adobe/aio-lib-core-config is breaking the build 🚨

The dependency @adobe/aio-lib-core-config was updated from 1.2.0 to 1.2.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@adobe/aio-lib-core-config is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for path files were not included in package.json
  • fix: patch files were not included ba0cc71

1.2.0...1.2.1

Commits

The new version differs by 2 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of aws-sdk is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency aws-sdk was updated from 2.652.0 to 2.653.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.653.0

See changelog for more information.

Commits

The new version differs by 1 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

rules are not undeployed using undeploy script/command

Sample manifest:

packages:
  __APP_PACKAGE__:
    license: Apache-2.0
    actions:
      report:
        function: /Users/himar/hello.js
        runtime: 'nodejs:10'
    triggers:
      everyMinute:
        feed: /whisk.system/alarms/alarm
        inputs:
          cron: "* * * * *"
          trigger_payload: "{\"message\": \"hello world!\"}"
    rules:
      reportEveryMinute:
        action: report
        trigger: everyMinute

It seems rules cannot be annotated and hence they cannot be fetched to undeploy.
Rules should be fetched the same way APIs are fetched from the manifest.

Expected Behaviour

rules should be undeployed

Actual Behaviour

rules are not undeployed

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

An in-range update of open is breaking the build 🚨

The dependency open was updated from 7.0.0 to 7.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

open is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for v7.0.1

v7.0.0...v7.0.1

Commits

The new version differs by 6 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of @adobe/aio-cli-plugin-runtime is breaking the build 🚨

The dependency @adobe/aio-cli-plugin-runtime was updated from 1.4.0 to 1.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@adobe/aio-cli-plugin-runtime is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for 1.5.0
  • Pass parameters to trigger fire (#120) 1634a28
  • Emit activation id for trigger firing. (#124) 767cf18
  • Support deploying of blackbox actions (#129) 8e43c27
  • Merge pull request #125 from rabbah/docker 23f871c
  • fix: code file links on README.md are broken (/blob/v1.4.0/ not found) (closes #126) (#127) 178bbcc
  • Add restricted access note. 26a1127
  • Support action create/update with --docker. 6ee0b03
  • Merge pull request #106 from Yu1986/e2e 9c9f9f4
  • get name from package name f38b5ce
  • get package name from package.json dc43522
  • change overloaded P flag to E (#117) 1d6e4dc
  • Fixes action invoke defects (#104) 6cdecac
  • Support -e for adding environment variables. (#103) c4710bf
  • Only emit rule delete if json flag is given. (#113) de569e0
  • Fix uncaught async exception warnings in unit tests. Closes #95 (#108) 8cfcc81
  • adding ability to limit action list by package. fixes #105 (#109) 3ceba9e
  • Tweak missing property messages to improve clarity (#107) ac148cc
  • add e2e test eac8d17

1.4.0...1.5.0

Commits

The new version differs by 25 commits.

  • d91f33d 1.5.0
  • 1634a28 Pass parameters to trigger fire (#120)
  • 767cf18 Emit activation id for trigger firing. (#124)
  • 8e43c27 Support deploying of blackbox actions (#129)
  • 23f871c Merge pull request #125 from rabbah/docker
  • 20be232 Merge branch 'master' into docker
  • 178bbcc fix: code file links on README.md are broken (/blob/v1.4.0/ not found) (closes #126) (#127)
  • 26a1127 Add restricted access note.
  • 6ee0b03 Support action create/update with --docker.
  • 9c9f9f4 Merge pull request #106 from Yu1986/e2e
  • f38b5ce get name from package name
  • 7bfc515 Merge branch 'master' into e2e
  • 021f328 fix lint
  • 6e7eff3 fix lint
  • dc43522 get package name from package.json

There are 25 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Dependencies have moved

warning @adobe/aio-cli-plugin-cna > @adobe/io-cna-scripts > [email protected]: This module has moved and is now available at @hapi/joi. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
warning @adobe/aio-cli-plugin-cna > @adobe/io-cna-scripts > joi > [email protected]: This module has moved and is now available at @hapi/topo. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
warning @adobe/aio-cli-plugin-cna > @adobe/io-cna-scripts > joi > [email protected]: This module has moved and is now available at @hapi/hoek. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
warning @adobe/aio-cli-plugin-cna > @adobe/io-cna-scripts > joi > topo > [email protected]: This module has moved and is now available at @hapi/hoek. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
warning @adobe/aio-cli-plugin-cna > @adobe/io-cna-scripts > @adobe/[email protected]: WARNING: This module has been renamed to @adobe/aio-cna-core-config. Please install it instead. See https://github.com/adobe/aio-cna-core-config for more information.

Static folders in /dist directory are not uploaded to CDN

Expected Behaviour

All subdirectories under my /dist/web-src-prod should be uploaded to CDN.

Actual Behaviour

Only files under /dist/web-src-prod are uploaded.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

My build process generates a /dist/web-src-prod directory that looks like this:

.
β”œβ”€β”€ index.html
β”œβ”€β”€ resources // <=== THIS does not get uploaded
β”‚   β”œβ”€β”€ README.MD
β”‚   β”œβ”€β”€ spectrum-css-icons.svg
β”‚   β”œβ”€β”€ spectrum-icons-color.svg
β”‚   └── spectrum-icons.svg
β”œβ”€β”€ src.a2b27638.css
β”œβ”€β”€ src.a2b27638.css.map
β”œβ”€β”€ src.a2b27638.js
β”œβ”€β”€ src.a2b27638.js.map

When I run aio app deploy -v

I get this in the logs:

> Deploy static files
⚠ an already existing deployment for version 0.0.3 will be overwritten
   > static.txt
   > index.html
   > src.a2b27638.css
   > src.a2b27638.css.map
   > src.a2b27638.js
   > src.a2b27638.js.map
βœ” Deploy static files

I have traced this issue to here:
https://github.com/adobe/aio-app-scripts/blob/e588449852e0afa53a57dbed290f39f2495d76ca/lib/remote-storage.js#L107

fs-extra does not support recursively walking the filesystem tree, The fs-extra author recommends using klaw here: https://github.com/jprichardson/node-fs-extra#what-happened-to-walk-and-walksync
or you could you any number of implementations to get the same result of including the whole directory recursively.

It's missing my resources folder

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

React + TypeScript support

React Spectrum is the default UI toolkit for Project Firefly.
React Spectrum is written in TypeScript.
Unfortunately, Project Firefly does not support writing React + TypeScript thus we can't leverage all the benefits of React Spectrum.

Parcel is used to bundle static files https://github.com/adobe/aio-app-scripts/blob/master/scripts/build.ui.js#L47. but it's not configurable currently.

See https://en.parceljs.org/typeScript.html#when-using-react for more information about Parcel + React + TypeScript.

An in-range update of @types/hapi__joi is breaking the build 🚨

The devDependency @types/hapi__joi was updated from 16.0.8 to 16.0.9.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/hapi__joi is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of aws-sdk is breaking the build 🚨

The dependency aws-sdk was updated from 2.614.0 to 2.615.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.615.0

See changelog for more information.

Commits

The new version differs by 1 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of @types/jest is breaking the build 🚨

The devDependency @types/jest was updated from 24.0.24 to 24.0.25.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of @types/hapi__joi is breaking the build 🚨

The devDependency @types/hapi__joi was updated from 16.0.6 to 16.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/hapi__joi is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

aio app:deploy error if static project contains files with .mst extension

Describe the bug
A static project containing .mst files (mustache templates) can not be deployed. Debug log:

Deploying actions
β ‹ Deploying web assets  @adobe/aio-lib-core-tvm:debug initializing with config: {
  @adobe/aio-lib-core-tvm:debug   "ow": {
  @adobe/aio-lib-core-tvm:debug     "namespace": "278519-mhtest-stage",
  @adobe/aio-lib-core-tvm:debug     "auth": "<hidden>"
  @adobe/aio-lib-core-tvm:debug   },
  @adobe/aio-lib-core-tvm:debug   "apiUrl": "https://firefly-tvm.adobe.io",
  @adobe/aio-lib-core-tvm:debug   "cacheFile": "/Users/mhaack/workspaces/playground/aio-pwa/.aws.tmp.creds.json"
  @adobe/aio-lib-core-tvm:debug }
  @adobe/aio-lib-core-tvm:debug read credentials from cache file with key b96338bb5bc5e6512bd5f8cf241b7168c3d302052818878a5188b8797fc8ef5c
TypeError: mimeType.startsWith is not a function
    at RemoteStorage._getCacheControlConfig (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-lib-web/lib/remote-storage.js:179:25)
    at RemoteStorage.uploadFile (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-lib-web/lib/remote-storage.js:110:37)
    at async /Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-lib-web/lib/remote-storage.js:157:21
    at async Promise.all (index 42)
    at async Object.deployWeb (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-lib-web/src/deploy-web.js:58:3)
    at async Deploy.run (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@adobe/aio-cli-plugin-app/src/commands/app/deploy.js:108:35)
    at async Deploy._run (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/command.js:43:20)
    at async Config.runCommand (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/config/lib/config.js:173:24)
    at async Main.run (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/main.js:27:9)
    at async Main._run (/Users/mhaack/.nvm/versions/node/v12.13.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/command.js:43:20)

Sample files can be found here: https://github.com/magento/pwa-studio/tree/develop/packages/venia-ui/templates

Expected behavior
Deployment is working.

Additional context
aio cli version:

System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 441.09 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node
    Yarn: 1.22.0 - /usr/local/bin/yarn
    npm: 6.12.0 - ~/.nvm/versions/node/v12.13.0/bin/npm
  Virtualization:
    Docker: 19.03.13 - /usr/local/bin/docker
  npmGlobalPackages:
    @adobe/aio-cli: 5.0.1
  CLI plugins:
    @adobe/aio-cli 5.0.1 (core)
    @adobe/aio-cli-plugin-app 5.2.1 (core)
    @adobe/aio-cli-plugin-auth 2.4.0 (core)
    @adobe/aio-cli-plugin-certificate 0.2.0 (core)
    @adobe/aio-cli-plugin-cloudmanager 0.18.2 (user)
    @adobe/aio-cli-plugin-config 2.3.0 (core)
    @adobe/aio-cli-plugin-console 3.2.0 (core)
    @adobe/aio-cli-plugin-events 1.1.0 (core)
    @adobe/aio-cli-plugin-info 1.1.1 (core)
    @adobe/aio-cli-plugin-runtime 3.0.0 (core)
    @oclif/plugin-autocomplete 0.2.0 (core)
    @oclif/plugin-help 2.2.3 (core)
    @oclif/plugin-not-found 1.2.4 (core)
    @oclif/plugin-plugins 1.9.4 (core)
    @oclif/plugin-warn-if-update-available 1.7.0 (core)

An in-range update of aws-sdk is breaking the build 🚨

The dependency aws-sdk was updated from 2.608.0 to 2.609.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.609.0

See changelog for more information.

Commits

The new version differs by 1 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of aws-sdk is breaking the build 🚨


☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency aws-sdk was updated from 2.634.0 to 2.635.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

aws-sdk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

Release Notes for Release v2.635.0

See changelog for more information.

Commits

The new version differs by 1 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

deploy fails if name in package.json contains a scope

deploy fails if name in package.json contains a scope (starting with @)

Expected Behaviour

deploy should succeed

Actual Behaviour

deploy fails

Reproduce Scenario (including but not limited to)

deploy a package with a scope

Steps to Reproduce

deploy a package with a scope

Platform and Version

current (master)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.