Giter Club home page Giter Club logo

aem-site-template-standard's Introduction

Standard Site Template

This is the standard site template for Adobe Experience Manager as a Cloud Service (AEMaaCS).

Standard site preview

It can serve as a standard starting point for creating a new site, or as a starting point for creating custom site templates.

Structure

  • files: Folder with the UI kit XD file and possibly other files.
  • previews: Folder with screenshots of the site template.
  • site: Content package of the content that will be copied for each site created from this template (templates, pages, etc.).
  • theme: Sources of the template theme to modify how the site looks (CSS, JS, etc.).

Install on AEMaaCS

Build locally

Alternatively you can build aem-site-template-standard-{version}.zip locally.

  1. Install Maven (to be able to use the packaging script).

  2. Initialize the project with following command executed at the template root:

    npm install
  3. To build the site template, run following command executed at the template root:

    npm run build
  4. The site template ZIP file is now located below the template root: aem-site-template-standard-{version}.zip.

  5. Upload to an AEMaaCS site creation wizard. For installing on a local cloudready development instance use npm run deploy.

Develop Site Template

See: https://github.com/adobe/aem-site-template-builder

Release

Run Build and release GitHub workflow and provide the semantic version you're about to release. The workflow executes the following steps:

  • Build Site Template
  • Release latest version on github
  • Commit, build and release latest Site Theme related changes in Site Theme E2E Repo.

Contributing

Contributions are welcomed! Read the Contributing Guide for more information.

Licensing

This project is licensed under the MIT License. See LICENSE for more information.

aem-site-template-standard's People

Contributors

bartoszglow avatar basecode avatar bpauli avatar comanv avatar gabrielwalt avatar jckautzmann avatar jshelley-xx avatar lauraa1003 avatar markszulc avatar reusr1 avatar richardhand avatar vladbailescu avatar vtsaplin avatar znikolovski avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

aem-site-template-standard's Issues

Clarify Node/NPM prerequisites for https://github.com/adobe/aem-site-template-standard/tree/main/theme

It is not clear which Node/NPM version is minimally required and which one is maximally supported by https://github.com/adobe/aem-site-template-standard/tree/main/theme.

Also a link towards https://experienceleague.adobe.com/docs/experience-manager-cloud-service/content/implementing/developing/developing-with-front-end-pipelines.html?lang=en and other resources which help understanding how this is supposed to executed in Cloud Manager would be beneficial.

Update Github action for theme deployment

AEM will soon support a new deployment infrastructure for frontend artifacts which require the frontend packages to be uploaded to an Azure blob store container. The default theme should be updated to include the changes to support this OOTB.

Logging into AEM Cloud using Sites30 Proxy

Hi guys

@bartoszglow I'm having issues logging into a dev instance of AEM Cloud after running npm run live to test frontend changes.

Is there any documentation on permissions that need to be granted to a user or a special user profile that needs to be configured?

I can log into the AEM author as a Business Owner and have full admin rights using my Adobe ID.

If I try to sign in under http://localhost:7002 using my Adobe ID I get redirected to the following URL which returns a 403:

https://author-p63602-e526610.adobeaemcloud.com/callback/j_security_check?code=eyJhbGciOiJSUzI1NiIsIng1dSI6Imltc19uYTEta2V5LWF0LTEuY2VyIiwia2lkIjoiaW1zX25hMS1rZXktYXQtMSIsIml0dCI6ImF0In0.eyJpZCI6IjE2NTA2MzU0MDU0NTRfYzEwOWY5M2UtOWQ5ZC00MDVhLThhMjktMTM0NzUyYmYxMDUyX3VlMSIsInR5cGUiOiJhdXRob3JpemF0aW9uX2NvZGUiLCJjbGllbnRfaWQiOiJ3ZWItcDYzNjAyLWU1MjY2MTAtYzA2ODQyYjctZGU1Yy00MjgyLWI2MTUtYjFlMTk1NTE1NzhiIiwidXNlcl9pZCI6IjIyMkU1N0UwNjI0NUE4NzAwQTQ5NUM4Q0BBZG9iZUlEIiwic3RhdGUiOiI5YjdmbzlmOWcxYnFmbW9vZXF2bmNqamxiNSIsImFzIjoiaW1zLW5hMSIsImFhX2lkIjoiMjIyRTU3RTA2MjQ1QTg3MDBBNDk1QzhDQEFkb2JlSUQiLCJmZyI6IldNREI0WktPWFBNN0lQVUtHTVFGUkhRQU9BPT09PT09Iiwic2lkIjoiMTY1MDYzNTIzMDU3N182Mzc3MDY2ZC03OTc5LTQ1NDAtYmFlMi01NzZhNjE5NjgzOTRfdWUxIiwib3RvIjp0cnVlLCJleHBpcmVzX2luIjoiMTgwMDAwMCIsInNjb3BlIjoiQWRvYmVJRCxvcGVuaWQscmVhZF9vcmdhbml6YXRpb25zLGFkZGl0aW9uYWxfaW5mby5wcm9qZWN0ZWRQcm9kdWN0Q29udGV4dCIsImNyZWF0ZWRfYXQiOiIxNjUwNjM1NDA1NDU0In0.elTDUTTD9CME7fZv_NuxxECFeneGYCN3z08LUzkD152hyQ-jJZe_lKVMv18aEZ2BUPq4tzR3_KiOxgg4Glnx4UjEfdjtXAwocrtvWuONaUL75ejTC_St1qbJzYqwpP-8enAee13jKi76beqiesShqs43mxP_c4xpEkrOe3qmplXmzgTAr_YpTlim2v5Iq5BmkHJlJ3b_-uL4u6S_M40Qspfq6_28KrchYXLg6ocM7t0QYa57kwbPWJPA4afNC0HI9qbRA5ZAlTFM5RqOgWCDNeS6gyATFYHn2Bbnrm-pRvbcVxME1_xPJ_YFRrTOoSzsvjTRoBXMmrMy2RIXxfmfEA&state=9b7fo9f9g1bqfmooeqvncjjlb5

But then if I navigate to https://author-p63602-e526610.adobeaemcloud.com/aem/start.html I'm logged in and have full access.

So this seems to be an issue with logging in under localhost.

This is basically a vanilla site created using the Standard AEM Site Template 2.1.1.

I've downloaded the Theme Sources from the AEM site and tested the theme code from this repository with the same result.

Regards, Charlie

Theme appears to reference a non-existent function

Hi,

we've created a new theme based on the sources provided in the standard site template. We've added ESlint with @typescript-eslint/parser to validate our code and it's picked up something awkward in languagenavigation.ts. A seemingly undefined function, closeNavigationGroup, is attached to an event.

We couldn't find a definition of closeNavigationGroup anywhere in the theme codebase or in AEM Core Components. Is this some external dependency that we could just add as a global to our linter's configuration or is this just accidentally missing?

Expected Behaviour

TypeScript code passes validation.

Actual Behaviour

https://github.com/Lauraa1003/aem-site-template-standard/blob/a9ca6f1aa4a0edb1a4a3b84f91a27426a13e22ed/theme/src/components/languagenavigation/languagenavigation.ts#L78 references the closeNavigationGroup function that isn't defined in the same file or any of the imports. Both the IDE and the linter point this out as an error.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Build theme code with .eslint enabled or import it into an IDE with TypeScript support. Inspect errors.

Platform and Version

Theme code from version 2.2.0 of the aem-site-template-standard

Sample Code that illustrates the problem

https://github.com/Lauraa1003/aem-site-template-standard/blob/a9ca6f1aa4a0edb1a4a3b84f91a27426a13e22ed/theme/src/components/languagenavigation/languagenavigation.ts#L78

Logs taken while reproducing problem

TS2304: Cannot find name 'closeNavigationGroup'.

CC @alicja-wierzbicka-wttech

Thanks,
Tomek

Question: AEM Site Creation Wizard not offering option to import file

Expected Behaviour

AEM Sites Creation Wizard should offer option to import a file.

Actual Behaviour

AEM Sites Creation Wizard does not offer option to import a file

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Go to Sites
Click Create -> Site

No option to Import a file is offered:
image

Platform and Version

2021.10.5977.20211021T153528Z

Sample Code that illustrates the problem

Logs taken while reproducing problem

Experience Fragment Styling

Expected Behaviour

Editing the Header XF within the basic site template, that the XF displays as per the new pages that are created

Actual Behaviour

XF fragment dissplays in an un-styled format, meaning i cant edit this branding

Reproduce Scenario (including but not limited to)

Create new site using basic site template 5.1.2
Edit the header XF

Steps to Reproduce

Create new site using basic site template 5.1.2
Edit the header XF

Platform and Version

AEMaaCS

Sample Code that illustrates the problem

N/A

Logs taken while reproducing problem

N/A
Screen Shot 2021-08-18 at 5 32 51 pm

Add package-lock.json to the template and to the theme

Both in main folder and in the theme there are no package-lock.json files. Those need to be added to secure single representation of a dependency tree for teammates, deployments, and continuous integration.

Expected Behaviour

There are package-lock.json files next to ./package.json and ./theme/package.json

Actual Behaviour

There are no package-lock.json files next to ./package.json and ./theme/package.json

Changes in code are not reflected on AEM instance

Expected Behaviour

Changes in code are reflected on instance.

Actual Behaviour

Changes in code are not deployed on instance after all steps from Wiki.

Steps to Reproduce

I followed all steps in wiki and also got a successful build on github actions.
You can check my repo here: https://github.com/thisisui/simple-theme/actions

Unfortunately on an instance I do not see any changes. Even when I download the theme once again from AEM I am still getting unchanged files.

In wiki it is written that Update theme config will be run after Build and deploy task but I cannot see in the logs any information that Update theme config has been started. Is there any way to debug this as I have no idea how to fix it.

Cheers
Igor

branding and html id are missing during page creation

Expected Behaviour

add a branding name and html id to a page when creating a new page

Actual Behaviour

the branding and thml id field are not displayed during the create page process

Steps to Reproduce

create a new page based on the core components base page

Platform and Version

cloud, latest as of today

Sample Code that illustrates the problem

Screenshot from 2021-04-22 09-03-41

Update XD file

  • Rename colors more semantically and ensure that they are offering enough contrast for accessibility.
  • Ensure that all components look good on normal and on inverted background.
  • Ensure that the AEM components are constructed with XD components.

Here's a WIP that's improved half-way through:
wireframe.xd.zip

Deploy script fails if zip file is named differently

Steps to reproduce:

  1. Clone/fork repo
  2. Run build script
  3. Zip file is created with aem-site-template-basic.zip
  4. Run deploy script
  5. Build script fails because it is looking for site-template.zip which doesn't exist

Issues with page responsiveness and language dropdown

Expected Behaviour

The responsive navigation should be functional and the CSS should display properly inside the author editor, and the language dropdown should show the selected language.

Actual Behaviour

The responsive navigation is not working as expected, and the CSS is off inside the author editor, and the language dropdown is not showing the selected language. (see screenshots below)

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Open the website in the author editor mode
  2. Go to mobile device view
  3. Attempt to navigate using the responsive navigation
  4. Check the language dropdown to verify if it displays the selected language

Screenshot 2023-02-22 at 15 40 01

Screenshot 2023-02-22 at 15 39 42

Screenshot 2023-02-22 at 15 40 31

Can we create new site structure

I wanted to create site as /content/quicksites//...
But, AEM quicksite import process is expecting structure like /content//...
When we use any other structure, we get an error “The filter.xml file does not contain the valid /content/aem-site-template-standard filter”
Could you please tell me, if AEM quicksite allows the content structure what we want? or is it under only /content

SASS updates not reflected in dist files due to Parcel cache

Related to Parcel V2 - Sass changes do not update in DIST folder.

Expected Behaviour

When changes are applied to SASS files those changes will be visible on the website proxy.

Actual Behaviour

Net-new changes are being packaged into the dist theme.css file but reverting back to changes that have already been processed by Parcel (e.g. change bg colour to red, then blue and then back to red results in the background still being blue) due to a cache management issue with Parcel V2 as described in the linked issue.

Fix resource type of root page

The resource type on the root page [1] is foundation/components/redirect, but it should be core/wcm/components/page/v2/page, like for all the child pages [2]. Also, the cq:template property is missing.

[1] https://github.com/adobe/aem-site-template-basic/blob/main/site/src/main/content/jcr_root/content/aem-site-template-basic/.content.xml#L12
[2] https://github.com/adobe/aem-site-template-basic/blob/main/site/src/main/content/jcr_root/content/aem-site-template-basic/fr/.content.xml#L16

Rebrand to "Standard Site Template"

This template should be rebranded as "Standard Site Template" instead of "Basic Site Template". Updates should be made to the code as well as documentation.

NPM errors when saving changes to theme sources.

Expected Behaviour

Changes compile and can be previewed on port localhost:3000

Actual Behaviour

All changes after the first save throw an NPM error

Reproduce Scenario (including but not limited to)

Making a secondary change to theme-sources after successful first change.

Steps to Reproduce

  1. In local open theme sources
  2. In theme source folder, run npm run live
  3. Wait for browser to open
  4. Make change in src/site/_variables.scss
  5. Save changes
  6. Wait for npm to pick up changes
  7. Re-fresh to see changes on localhost:3000
  8. Go through workflow steps 4 - 7
  9. npm throws an error

Platform and Version

Microsoft Windows 10 Pro
OS Version: 10.0.19042 N/A Build 19042

Sample Code that illustrates the problem

Logs taken while reproducing problem

[email protected] compile C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources
webpack -d --env dev --config ./webpack.dev.js

Error: ENOTEMPTY: directory not empty, rmdir 'C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\dist\css'
at Object.rmdirSync (fs.js:850:3)
at rmkidsSync (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\rimraf\rimraf.js:364:25)
at rmdirSync (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\rimraf\rimraf.js:342:7)
at Function.rimrafSync [as sync] (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\rimraf\rimraf.js:312:9)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\del\index.js:65:11
at Array.map ()
at module.exports.sync (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\del\index.js:57:40)
at CleanWebpackPlugin.removeFiles (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\clean-webpack-plugin\dist\clean-webpack-plugin.js:198:37)
at CleanWebpackPlugin.handleInitial (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\clean-webpack-plugin\dist\clean-webpack-plugin.js:135:10)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\clean-webpack-plugin\dist\clean-webpack-plugin.js:84:16
at AsyncSeriesHook.eval [as callAsync] (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :7:1)
at AsyncSeriesHook.lazyCompileHook (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\Hook.js:154:20)
at Compiler.emitAssets (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compiler.js:491:19)
at onCompiled (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compiler.js:278:9)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compiler.js:681:15
at eval (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :18:1)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\ts-loader\dist\after-compile.js:28:9
at AsyncSeriesHook.eval [as callAsync] (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :14:1)
at AsyncSeriesHook.lazyCompileHook (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\Hook.js:154:20)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compiler.js:678:31
at AsyncSeriesHook.eval [as callAsync] (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :4:1)
at AsyncSeriesHook.lazyCompileHook (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\Hook.js:154:20)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compilation.js:1423:35
at AsyncSeriesHook.eval [as callAsync] (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :4:1)
at AsyncSeriesHook.lazyCompileHook (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\Hook.js:154:20)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compilation.js:1414:32
at AsyncSeriesHook.eval [as callAsync] (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :4:1)
at AsyncSeriesHook.lazyCompileHook (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\Hook.js:154:20)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compilation.js:1409:36
at AsyncSeriesHook.eval [as callAsync] (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :4:1)
at AsyncSeriesHook.lazyCompileHook (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\Hook.js:154:20)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compilation.js:1405:32
at AsyncSeriesHook.eval [as callAsync] (eval at create (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\HookCodeFactory.js:33:10), :4:1)
at AsyncSeriesHook.lazyCompileHook (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\tapable\lib\Hook.js:154:20)
at Compilation.seal (C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compilation.js:1342:27)
at C:\aem-demo-machine-master\demos\qsc\basic-theme\theme-sources\node_modules\webpack\lib\Compiler.js:675:18
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] compile: webpack -d --env dev --config ./webpack.dev.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\cochrane\AppData\Roaming\npm-cache_logs\2021-05-13T14_51_35_283Z-debug.log

Update NPM deprecated packages

In the theme of Basic Site Template there are some packages which are deprecated. Those need to get update so there are no warnings during installation as for node v15 those will fail to build.

Expected Behaviour

No deprecation warnings during installation of npm packages.

Actual Behaviour

NPM deprecated warning.

Experience Fragment Editor and Preview don't load fonts/images from /theme/src/resources

image

In the Experience Fragment Editor, and in View as Published, something is preventing the images and fonts loaded from /theme/src/resources. It appears the fonts are trying to load from src: url(../src/resources/fonts/SourceSansPro/SourceSansPro-Black..ttf) which works fine when viewing normal content pages, but not when in an Experience Fragment.

Expected Behaviour

Fonts/Images from /theme/resources load as expected in XFs.

Actual Behaviour

Fonts/Images don't load

Reproduce Scenario (including but not limited to)

  1. Create site from template.
  2. Navigate to header experience fragment
  1. See the serif fonts instead of the expected sans-serif Adobe font

Steps to Reproduce

  1. Create site from template.
  2. Navigate to header experience fragment
  1. See the serif fonts instead of the expected sans-serif Adobe font

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

Deployment doesn't fail when the environment is unavailable

Expected Behaviour

The Github workflow responsible for deploying an updated theme to AaCS fails when the instance is unavailable. It only succeeds when the artifact has been successfully deployed.

Actual Behaviour

If deployment is attempted while the AEM instance is unavailable, the workflow is marked as successfully completed, which could be confusing under certain circumstances.

Under the hood, npx aem-site-theme-builder deploy makes an HTTP request to transfer the zip to AEM. If it receives a non-successful response code, the failure is silently ignored.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Create a site based on the AEM Site Template
  2. Put it under version control on Github and configure Github Actions to automate deployments
  3. Hibernate the Environment via the Developer Console
  4. Trigger the Build and deploy to Github artifacts workflow
  5. Wait for the Update theme config on AEM with artifact id workflow to kick off and inspect the log

Platform and Version

Site generated using "@adobe/aem-site-theme-builder": "4.0.1"

Sample Code that illustrates the problem

Logs taken while reproducing problem

From the output of the update_theme_config workflow kicked off while the relevant environment was hibernated. AEM responds with HTTP 503 but the workflow succeeds.

Run npx aem-site-theme-builder deploy
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  1269  100  1141  100   128   2616    293 --:--:-- --:--:-- --:--:--  2903
<!DOCTYPE html>
              <html lang="en">
                <head>
                  <meta charset="utf-8">
                  <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
                  <meta name="description" content="AEM Cloud Service">
                  <title>AEM Cloud Service</title>
                  <link rel="stylesheet" href="https://errors.adobeaemcloud.com/src.status.css">
                  <link rel="icon" href="https://errors.adobeaemcloud.com/favicon.ico">
                </head>
                <body>
                  <noscript>AEM Cloud Service.</noscript>
                  <div id="root" status="503"
                        backend="devconsole"
                        healthy="hibernated"
                        rid="0"
                        statusApi="https://dev-console-ns-team-aem-cm-prd-n6712.ethos13-prod-nld2.dev.adobeaemcloud.com/api/releases/ns-team-aem-cm-prd-n6712/status/cm-p8802-e42804"
                  > </div>
                  <script src="https://errors.adobeaemcloud.com/src.status.js"> </script>
                </body>
              </html>

The information in the log is quite clear but there's no visual hint at the failure at first. It is only once we've tried to access the environment that we realised it had been hibernated automatically.

successful runs that didn't actually deploy anything.

This is a trivial case in case of hibernation but it could behave in similar ways in case of unexpected problems with the environment and, depending on the development flow, some time-consuming and/or expensive tests could be started in a situation where the failure could be immediately obvious earlier. I think a fail-fast strategy would be a nice improvement here.

Browser sync does not use AEM_PROXY_PORT env var

  1. Browser sync doesn't read and doesn't use AEM_PROXY_PORT env variable. It always proxies to port 7000 expecting aem-site-theme-builder live preview to run on port 7000.

  2. Default proxy port should be changed from 7000 as this port is used internally by OS in latest release of Mac OS Monterey.

EPERM Error on Windows OS

When saving CSS code changes, browser sync does not sync to reflect the updated code after refreshing the browser and receives an EPERM error in the Command console. This happens on my Adobe issue Windows machine with Anti Virus Software running.

Expected Behaviour

Refreshing the browser should reflect css changes.

Actual Behaviour

EPERM error displays in the command console.

Reproduce Scenario (including but not limited to)

Update CSS in _variables.scss, save the file and refresh the browser, EPERM error occurs

Steps to Reproduce

navigate to the the theme-sources folder in a command window
run: npm live run
Update the background hex color in _variables.scss as instructed in the tutorial and save the file
in a web browser navigate to: http://localhost:7000/content/basic/en.html and refresh the page
View command window and an EPERM operation not permitted, lstat

Platform and Version

Windows 10 -OS
Carbon Black - Virsus scan software running (unable to turn it off)

Sample Code that illustrates the problem

Logs taken while reproducing problem

image

Issue on Publisher with theme.js and theme.css

Expected Behaviour

After publishing site should look good

Actual Behaviour

2 files are missing:
/content/anothertest.theme/_default/theme.js
/content/anothertest.theme/_default/theme.css

Steps to Reproduce

Install from Template
Publish the site
Hit the publish site and missing css and js

Platform and Version

AEMaacs

Content Page template path is incorrect

Expected Behaviour

Content Page Template opens for editing.

Actual Behaviour

The template loads incorrectly due to the template path being incorrect.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

Website performance optimization: dynamic media

Expected Behaviour

Images should load dynamically, with the sizes attribute optimizing image display. Above-the-fold images should not experience delays in rendering.

Actual Behaviour

Images are not loading dynamically, sizes attribute not being used and Above-the-fold images are being lazily loaded.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Load website in various browsers and devices
  2. Note the delays in the largest contentful paint.
  3. Observe above-the-fold image delays

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

Standard Site Template needs cleanup of page templates and policies

Rename Site Template

The term "basic" is not well received and also doesn't correspond anymore to this template that is now nicely themed.

We should rename it from "Basic Site Template" to "Standard Site Template" everywhere systematically.
Also, we should move this repository from adobe/aem-site-template-basic to adobe/aem-site-template.

Invalid template thumbnail on MacOS

Expected Behaviour

If I change site.png file in previews folder, it should be used for the built template.

Actual Behaviour

On Mac OS (couldn't test Windows) there are two thumbnails, first is incorrect (displaying placeholder), the second is intended site.png file.
image

Reproduce Scenario (including but not limited to)

N/A

Steps to Reproduce

On Mac OS replace previews/sites.png file, save and rebuild the package, then upload the package in Create (Template) wizard. Observe thumbnail on template list and preview images in details section on the right.

Platform and Version

Mac OS (Catalina, 10.15.7)
NodeJS v.12.18.2
NPM 6.14.5

Sample Code that illustrates the problem

No exact code. It seems like .DS_Store file is being packaged within previews folder and then uploaded to /conf/global/site-templates//previews like a preview file. It seems to be the first one in alphabetical order and is used for thumbnail. I tried manually removing .DS_Store via terminal rm before build, but it is still present in the output package.
image

Logs taken while reproducing problem

N/A

Dropping a teaser shows no placeholder

Steps to reproduce (incl. screenshots/recordings):


  • create a site with standard template 2.0.0 or higher
  • drop teaser v2 on the page

=> nothing visible, but the component is there.

Note: all other components show a placeholder.

Screenshot 2022-03-21 at 09 51 32

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.