Expected Behaviour

FlexModel is available to flex.html

Actual Behaviour

It's not

Reproduce Scenario (including but not limited to)

Try to use flex container

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

that installs "all" package

https://sonarcloud.io/project/issues?id=com.adobe.dx%3Areactor&resolved=false&types=BUG

in order to be able to work on #2, we need one command that builds everything, will add one parent, and a root POM

ability to execute javascript after component edit without using MutationObserver in both author and publish.

The admin-configmanager js files have a dependency on react-spectrum v2. V2 is not being open sourced, but react-spectrum v3 will be soon.

In order to build the js files:

1. Need to update the dependencies to use V3
2. Import the dependencies via .tgz files as done here

This blocks #11 from being merged.

it seems that we sends coverage data to sonarcloud on tests JS classes, those should obviously not be considered as problematic

needed for basic page

The ability to set CSS vertical height without editor.html infinitely scrolling.

first step before this repo is being usable would be to create an adobe-dx documentation website using adobe-dx, so we know it "works"

for now we have one admin team and no real way but github issues to discuss openly.

@chrischrischris reported an issue with local build failing because of some test on testLastModified

Feature Request

Is your feature request related to a problem? Please describe.
Maybe?

• You cannot vertically or horizontally center a container item.
• You cannot re-order container items based on breakpoint.
• You cannot define per-breakpoint container values (background, foreground, etc.).
• You cannot set a minimum height for a container or item
• You cannot use VH in editor.html without an infinite scroll bug.
• Items cannot vertically stretch to match siblings.
• You cannot set a universal gutter (or gap) between items

Describe the solution you'd like

The Dx (also known as Dexter) team wants to contribute our Flex Container component.

It is mostly based on flexbox with other niceties thrown in:

Component per-breakpoint features (individually configurable per mobile, tablet, desktop)

• Set item (child) order
• Set justify-content
• Set align-items
• Set align-content
• Set background image (with POI selection for offsetting crop)
• Set background color
• Set foreground color
• Set gap (to simulate the CSS grid gap feature)
• Set min height (px or vh)

Flex item per-breakpoint features (configurable per mobile, tablet, desktop)

• Set width (auto, column 1-12, %, px)
• Set min height (px or vh)

One size fits all features

• Container CTA - Ability to make the entire container clickable (with notice of accessibility concerns)
• Enable Container - Similar to Bootstrap's container: contstrain max widths using a 'container' CSS class.
• Accessibility Attributes - Ability to set element, landmark name, and landmark label.

Overall features that come with (i.e. required) and useful for other components

• dxPolicy - An inheritance scheme for content policy properties that will pick up component-level props first if present. API similarity to ValueMap.
• Component Governance Render Condition - The ability to completely remove dialog property selection if a boolean is set at the policy level to turn the property off. If policy property is set, page-level author cannot change property. ACLs allow for admins and template authors to still view and edit dialog properties.
• Context-Aware Datasource - A datasource to power granite selects & colorfields that allows tenant / brand / locale specific properties.
• Author VH - The ability to set CSS vertical height without editor.html infinitely scrolling.
• Author Watch - The ability to execute javascript after component edit without using MutationObserver in both author and publish.
• OSGi breakpoint service - The ability to configure breakpoint pixel values to satisfy per-breakpoint configs above.

Are there alternatives?
CSS Grid, but it's not IE11 compatible (without transpiling / decent authorability)

Documentation
https://css-tricks.com/snippets/css/a-guide-to-flexbox/

As I find time, I'll put some videos together in an AEM context. Most of the docs are probably covered with the above criteria.

render condition for dialogs

Something to generate CSS IDs. Must be unique and not cause collisions on page.

On private Dexter, we went with something based on path and hashed it.

/content/xfs/my-xf/master/jcr:content/my-component > ee2b49d80498e239dcc727c355611696

I think there was some stumbling with this approach. @sabyamon may know more details as he dealt with this a bunch.

The addition of npm install to the build slows it down significantly.

By caching the npm packages, we can speed up the build.

See https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows on guidance for implementation.

• Ability to store Marketo Client Props
• Ability to retrieve Auth Token, and Forms from Marketo

Expected Behaviour

As a developer I expect Adobe Fonts configuration should be de-coupled from Configuration Manager so I can release each feature independently.

Actual Behaviour

Adobe Fonts configuration code resides in Config Manager.

In order to add background gradients to Flex, create a ConfigManger that can interactively create gradients.

Sonarcloud needs a Generic Execution Data file of the js test results in order to display js test results.

A datasource to power granite selects & colorfields that allows tenant / brand / locale specific properties

@chrischrischris complains that rat is listing all excludes each time and i stumbled on https://issues.apache.org/jira/browse/RAT-241.
Will bump the version.

JS tests for the configManger need to achieve at least 80% code coverage.

Github homepage is only displaying "Releasing"

ability to configure breakpoint pixel values to satisfy per-breakpoint configs above.

all package points to 0.0.1-SNAPSHOT versions. We should

1. decide wether latest "all" points to the latests, or to the latest releases,
2. update accordingly

cc @adobe/adobe-dx-devs

While writing FlexModel, I realized the ID service can generate an id that starts with a number. This is not compliant with the ID property for HTML.

We could:

1. Prefix in our classes ("d" + id)
2. Change the ID service.

For now I am going to prefix.

right now, no unit tests are there, nor core coverage utility for java, we need this to finish up #2

right now it's only 6.5

Centralize to prevent duplication of node_modules and common scripting configs.

right now, this seems to create confusion with GH packages, see https://github.com/adobe/adobe-dx/packages/166512 group id is "com.adobe.dx.dx"

makes it easy to contribute new content or bundle module

We should use eslint with airbnb rules.

May also be useful to use Prettier - see https://gist.github.com/bradtraversy/aab26d1e8983d9f8d79be1a9ca894ab4 for possible implementation.

right now, because dx_pageId does not change, it will not be updated, and we'll end up having twice the same id

if possible to mimic aem's htl rendering context in a pax-exam osgi container (am a bit afraid around wcm dependencies...), this would be a first good coverage of both java and htl script to ensure that those htl are rendered correctly based on a developer providing content, script, and expected output.

Expected Behaviour

1. parlite respects cq:responsive nodes set by responsivegrid
2. Outputs css classes in wrapper to correctly show / hide (no width or ordering as this is done by flex container)
3. "default" node should have following behavior:
   1. No nodes - Everything - parlite-hide-all
   2. Mobile - tablet & desktop - parlite-hide-tablet parlight-hide-desktop
   3. Tablet - mobile & desktop - parlite-hide-mobile parlight-hide-desktop
   4. Mobile & Tablet - desktop only - parlite-hide-desktop

Actual Behaviour

None of this exists.

e.g. #15

problem is that secrets.SONAR_TOKEN seems unreadable from PR

Most projects in Dx have: src/main/content. I would argue this tree provides no value for UI related code.

Expected Behaviour

As a developer, I do not have to click on src, main, content to get to my code. I should be able to click on src to get to my code.

Actual Behaviour

I click a lot.

Reproduce Scenario (including but not limited to)

Click on apps admin app src main content.

Steps to Reproduce

Just start click'n.

Platform and Version

All of them.

Sample Code that illustrates the problem

https://github.com/adobe/adobe-dx

Logs taken while reproducing problem

LOG: It takes 5+ seconds to descend into being able to work.

same as for #11 but for javascript, still for #2

make available a widget that allows, in a user friendly way, to provide:

• no value,
• 0 value,
• positive random value

default slider can't be "disabled" by user choice.

while re-evaluating id tags is necessary at replication time, we'll need IDs on author far before first replication.

cc @auniverseaway @ccongerp

goal would be to be able to use, in htl scripts ${dxPolicy.text} where text would first be looked up in component properties, then in bindings content policy

As a developer I want a service to provide me with proper breakpoint fallbacks for the property I provide so that I do not have to re-implement my own breakpoint fallbacks for each property individually.

Context

We have background color, foreground color, background image, and spacing that all need this service. We should be able to ask for a property (padding left) and the current breakpoint (desktop) and if the the property doesn't exist, it is probably empty so that tablet, mobile can still exist but we're not outputting unnecessary code.

Expected Behaviour

The build works.

Actual Behaviour

The build fails.

Reproduce Scenario (including but not limited to)

Try to build.

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

as an owner i want to be able to release individual adobe-dx modules. Goal being that anyone could simply (assuming configuring a maven repository is simple) add a module for his own project.

typically
[ERROR] Failed to execute goal biz.aQute.bnd:bnd-baseline-maven-plugin:4.2.0:baseline (baseline) on project com.adobe.dx.testing: Unable to locate a previous version of the artifact: Could not transfer artifact com.adobe.dx:com.adobe.dx.testing:jar:0.0.2 from/to github-dx (https://maven.pkg.github.com/adobe/adobe-dx): Transfer failed for https://maven.pkg.github.com/adobe/adobe-dx/com/adobe/dx/com.adobe.dx.testing/0.0.2/com.adobe.dx.testing-0.0.2.jar: Connection timed out (Read failed) -> [Help 1]

Expected Behaviour

As a developer, I would like a CI service to build my branch for which my PR is based on so that it can check for:

1. Unit test coverage (Java & Javascript)
2. Security vulnerabilities (as described by Cloud Manager rules)
3. Ability to compile

Actual Behaviour

There is no CI service.

Reproduce Scenario (including but not limited to)

1. Submit a PR

Steps to Reproduce

1. Submit a PR

Platform and Version

All

Sample Code that illustrates the problem

None

Logs taken while reproducing problem

Submitted PR