adityanatraj / git-pr Goto Github PK

The git system already has configuration files we can use. We should use them.

Why do I like them:

• they already exist as canonical configuration
• it won't break anything to add to them in a consistent way
• there's a nice scoping concept that allows info about a repo to "live within it" or not (local, global)
• there's already a tool to nicely read/edit/etc the git config at all levels
• reading those config files may have value in the future

I ran with PR on a branch that was recently merged with master, so no commits in between. this is what I got:

POST https://api.github.com/repos/nytm/sartre-sublink/pulls: 422 Validation Failed [{Resource:PullRequest Field: Code:custom Message:No commits between master and feature/PLTO-11624-change-logic-to-look-for-names}]

I think there could be a nicer way to display that messages, perhaps just showing: No commits between master and working-branch