adiferd / expr Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 328 KB

JavaScript 100.00%

expr's Introduction

Hi there 👋

expr's People

Contributors

Watchers

expr's Issues

Split to Error resposen and Success Response

expr/app/helpers/Formatter.js

Line 4 in ad693d9

static toSingleResponse(data, message, error) {

I think this function need to be splitter to success formatter and error formatter, so that there is no error value in success return. Any suggestion @firyalff ?

uncaught exception handler

expr/app/kernels/Http.js

Lines 8 to 24 in f89026d

 class Http { 

 static async apply(server) { 

 try { 

 server.use(bodyParser.json()); 

 server.use(bodyParser.urlencoded({ extended:false })); 

 server.use('cors'); 

 } catch (e) { 

 console.log(e); 

 } 

 } 

 static async errorHandler(req, res, route, err) { 

 const response = Formatter.toSingleResponse({ reqBody: req.params }, 'Error occured', err.status || err.message || err.description || 'Internal Server Error') 

 res.send(err.code || 500, response); 

 } 

 }

Add uncaught exception handler function
server.on('uncaughtException', (req, res, next) => { ... });

error escape

expr/app/controllers/Hello.js

Lines 5 to 8 in f89026d

 static async sayHello(req, res, next) { 

 let response = Formatter.toSingleResponse({hello: 'world'}, 'Say hello') 

 res.send(response) 

 next()

Should wrap function in try catch

Should add validator layer

Kindly check this package

https://www.npmjs.com/package/express-validator

Change entrypoint script in config directory

replace script inside /config/index.js with script from /config/local/index.js. App will accept non-local environment

adiferd / expr Goto Github PK

expr's Introduction

Hi there 👋

expr's People

Contributors

Watchers

expr's Issues

Split to Error resposen and Success Response

uncaught exception handler

error escape

Should add validator layer

Change entrypoint script in config directory

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	class Http {
	static async apply(server) {
	try {
	server.use(bodyParser.json());
	server.use(bodyParser.urlencoded({ extended:false }));
	server.use('cors');
	} catch (e) {
	console.log(e);
	}
	}

	static async errorHandler(req, res, route, err) {
	const response = Formatter.toSingleResponse({ reqBody: req.params }, 'Error occured', err.status \|\| err.message \|\| err.description \|\| 'Internal Server Error')

	res.send(err.code \|\| 500, response);
	}
	}

	static async sayHello(req, res, next) {
	let response = Formatter.toSingleResponse({hello: 'world'}, 'Say hello')
	res.send(response)
	next()