adhawkins / flactag Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 1.0 814 KB

A utility for tagging single album FLAC files with embedded CUE sheets using data from the MusicBrainz service

License: GNU General Public License v3.0

C++ 49.97% Shell 8.96% C 0.46% Makefile 0.97% M4 39.60% sed 0.03%

flactag's People

Contributors

Stargazers

Watchers

Forkers

coldtobi

flactag's Issues

Correctly handle images too big for METADATA block

The largest size a metadata block can be is 16MB. If an image is retrieved that is bigger than this, it should be scaled down so as to fit.

handle 403s on cover art download

Recently, amazon cover art downloads fail:

flactag -w /home//music/flacs/CD-ACHHQh9M0lFleeWtf77D8csm3SM-.flac 
Unrecognised disc element: 'offset-list'
...
/home//music/flacs/CD-ACHHQh9M0lFleeWtf77D8csm3SM-.flac: Exception: Fetch error: 403 Forbidden
/home//music/flacs/CD-ACHHQh9M0lFleeWtf77D8csm3SM-.flac: No albums found

A strace yields:

 sendto(3, "GET /images/P/B0039208US.02.LZZZZZZZ.jpg HTTP/1.1\r\nUser-Agent: flactag/v2.0.4 neon/0.32.3\r\nKeep-Alive: \r\nConnection: TE, Keep-Alive\r\nTE: trailers\r\nHost: images.amazon.com\r\n\r\n", 174, MSG_NOSIGNAL, NULL, 0) = 174
poll([{fd=3, events=POLLIN}], 1, 120000) = 1 ([{fd=3, revents=POLLIN}])

recvfrom(3, "HTTP/1.1 403 Forbidden\r\nServer: CloudFront\r\nDate: Wed, 07 Dec 2022 06:23:02 GMT\r\nContent-Type: text/html\r\nContent-Length: 919\r\nConnection: keep-alive\r\nX-Cache: Error from cloudfront\r\nVia: 1.1 4201bd1d1fc37ea7749b
3bd1b64fce02.cloudfront.net (CloudFront)\r\nX-Amz-Cf-Pop: YVR50-C1\r\nX-Amz-Cf-Id: Yj9CA7vp2lrtF0NEpFXUlo3P4_oeCbB1AanEFQkyHpZRtpGoiJR4_A==\r\n\r\n<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\" \"http://www.w3.org/TR/html4/loose.dtd\">\n<HTML><HEAD><META HTTP-EQUIV=\"Content-Type\" CONTENT=\"text/html; charset=iso-8859-1\">\n<TITLE>ERROR: The request could not be satisfied</TITLE>\n</HEAD><BODY>\n<H1>403 ERROR</H1>\n<H2>The request could not be satisfied.</H2>\n<HR noshade size=\"1px\">\nRequest blocked.\nWe can't connect to the server for this app or website at this time. There might be too much traffic or a configuration error. Try again later, or contact the app or website owner.\n<BR clear=\"all\">\nIf you provide content to customers through CloudFront, you can find steps to troubleshoot and help prevent thi"..., 4096, 0, NULL, NULL) = 1270

I can fetch that URL with a web browser, so it might be user agent blocking.

Include ALBUMARTIST tag

For some reason, no ALBUMARTIST tag is currently written. This should be added, as it makes it easier to sort albums that are primarily by a single artist, but may have the odd track with a guest artist.

Add more fields to album view to help pick the right release

Add things like country, barcode, release data etc.

Find a replacement for libunac

libunac no longer seems to be packages for some distributions, and the last update was in 2002. A replacement should be found.

Add option to include album disambiguation in title

help to install this on fedora

hello, i'm trying to install this on fedora 37, but at the configure stage i am missing flac++ and unac, could you give me any help on building this?

Ability to select release in non-interactive mode

(From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698923)

I get the following:

$ flactag -r -w the-roots-things-fall-apart.flac
the-roots-things-fall-apart.flac: Multiple albums found
the-roots-things-fall-apart.flac: No matching album ID found, aborting

There are 2 releases for this discid. It would be nice if flactag
would allow me to specific the release on the command line.

Bonus points for printing what releases are available when you find
multiple ones.

Improved batch processing workflow

(From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769465)

Currently, when using the batch mode to operate on many flac files,
there is a pause between each file while flactag queries MusicBrainz.
The pause can last 5-10 seconds depending upon network conditions and
the MusicBrainz service availability.

E.g. if the user specifies ten files, then for each file:

5 second pause
flactag shows possible match(es)
user chooses how to proceed
goto step 1 (user waiting 5-10 seconds before interacting with
flactag again)

This pause between every operation can be frustrating for the user.

A better strategy would be:

scan all the flac files mentioned on the command line
obtain all possible data for all of the files from MusicBrainz (maybe
with parallel requests from a thread pool for better performance), show
a progress bar while this is happening
show a GUI listing each title and allowing the user to quickly move
between them in a list or using forward/back buttons

Once the user reaches the GUI stage, there should not be any pauses as
all relevant data has already been fetched from MusicBrainz.