adguardteam / adguardforwindows Goto Github PK

3. The inbuilt scan in Add Application for now looks in only the Program Files directory of C:. Here it misses the path of one major browser : Chrome. We can browse and add it but still for a major browser as this, I think you cud add this location for scanning.

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55303&viewfull=1#post55303

http://www.youtube.com/watch?v=v4_plXXrS-4&feature=youtu.be

• _SlimJet_
  http://www.slimjet.com/
  Process: slimjet.exe
• 7 Star Browser (Chinese popular)
  http://www.qixing123.com/
  Process: 7chrome.exe

We should find a place to store such user-specific settings.

Two options:
Registry
Configuration file in the %programdata% folder

Включено 3 фильтры

Check updates --> opens main UI progress dialog

It is 30 seconds now, decrease to 5-10 seconds.

Maybe we should decrease it for all popups?

Useful information:
http://www.hhhh.org/cloister/csharp/icons/
http://stackoverflow.com/questions/7490962/notifyicon-image-looks-terrible-once-image-ends-up-in-system-tray/22599852#22599852
http://stackoverflow.com/questions/18920357/notifyicon-and-high-dpi-displays

PC reboot may be required for proper change.

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55270&viewfull=1#post55270

There should be a possibility to add custom filter subscription by URL or file path.

Requirements

1. Add custom filters to the same group as user filter.
2. Handle the situation when users adds custom filter we already have (like EasyList) (use subscription_url field to merge them).
3. Filter parser should handle "Homepage", "Version", "Expires" fields
4. We should properly handle filters without such metadata.

If "Homepage" is not set - do not display it.
If "Version" is not set - display something like "Version from 15/01/2015"
Important: Handle empty version on update check result screen.

Parse "Last modified". If not set - use DateTime.Now.
If "Expires" is not set - set it to 48 hours.
Parse "Title". If "Title" not set - use URL instead (cut it to 64 characters)

1. Ignore [Adblock Plus 2.0] line

UI

1. New button to "Add filter" dialog:
   http://screencast.com/t/5W0DuQyo
2. New Filter Subscription dialog:
   http://screencast.com/t/THZmkmbSsPg

User may enter abp:subscribe or subscribe.adblockplus.org URL.
We should handle it.

http://forum.adguard.com/showthread.php?6047-%D0%A0%D0%B0%D0%BD%D0%BD%D0%B8%D0%B9-%D0%B4%D0%BE%D1%81%D1%82%D1%83%D0%BF-%D0%90%D0%BB%D1%8C%D1%84%D0%B0-%D0%B2%D0%B5%D1%80%D1%81%D0%B8%D1%8F-Adguard-6-0&p=55660&viewfull=1#post55660

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55270&viewfull=1#post55270

upon right clicking the tray icon we used to have an option named 'Close adguard but continue filtering' in v5, that is most useful for me personally. It wud be grt if it cud be accomodated too. because at the present adguard requires to be running all the time in the tray.

Just like it's done in Filter Editor window

http://api.adguard.com/userscripts.html instead of http://adguard.com/userscripts.html

We should add it, either column or a line in log record details

Also POS1 and End keys do not work. Have to press CTRL+POS1/End to make it work.

Steps to reproduce:

1. Disable "Launch Adguard at system startup"
2. Reboot
3. Run GUI manually

Expected result: protection is enabled
Real result: protection stays disabled

Adguard extensions are downloaded from URLs like that:
/adguard-ajax-api/injections/Adguard%20Assistant?rand=635729286615290489

After protection restart "rand" parameter will change, but scripts on cached webpages still use the old URL (which now returns 404 Not Found).

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55272&viewfull=1#post55272

http://forum.adguard.com/showthread.php?6043-Block-WebRTC-IP-address-leaks

What we should do:

1. Override javascript API, hide/disable all WebRTC object.
2. Block connections to STUN servers on the network level

Application: Adguard.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException
Stack:
at Adguard.App.b__c()
at System.Windows.Threading.ExceptionWrapper.Internal RealCall(System.Delegate, System.Object, Int32)
at System.Windows.Threading.ExceptionWrapper.TryCatch When(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.DispatcherOperation.Invok eImpl()
at System.Windows.Threading.DispatcherOperation.Invok eInSecurityContext(System.Object)
at System.Threading.ExecutionContext.RunInternal(Syst em.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threa ding.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threa ding.ExecutionContext, System.Threading.ContextCallback, System.Object)
at System.Windows.Threading.DispatcherOperation.Invok e()
at System.Windows.Threading.Dispatcher.ProcessQueue()
at System.Windows.Threading.Dispatcher.WndProcHook(In tPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation( System.Object)
at System.Windows.Threading.ExceptionWrapper.Internal RealCall(System.Delegate, System.Object, Int32)
at System.Windows.Threading.ExceptionWrapper.TryCatch When(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
at System.Windows.Threading.Dispatcher.LegacyInvokeIm pl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)
at MS.Win32.UnsafeNativeMethods.DispatchMessage(Syste m.Windows.Interop.MSG ByRef)
at System.Windows.Threading.Dispatcher.PushFrameImpl( System.Windows.Threading.DispatcherFrame)
at System.Windows.Threading.Dispatcher.PushFrame(Syst em.Windows.Threading.DispatcherFrame)
at System.Windows.Application.RunDispatcher(System.Ob ject)
at System.Windows.Application.RunInternal(System.Wind ows.Window)
at System.Windows.Application.Run(System.Windows.Wind ow)
at Adguard.App.Main()

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55303&viewfull=1#post55303

From the forum:

Окно "Поддержка". Начинаем вводить адрес почты, и при вводе первого символа выскакивает > окошко о недействительном адресе. Людей это вводит в заблуждение, на мой взгляд.
Вычищаем поле, убираем курсор, но красная окантовка остается, даже при переносе фокуса на другие поля. При этом, красный треугольник в поле смотрит вправо-вверх, а зеленые треугольники активности модулей в главном окне программы смотрят вправо-вниз. Тоже, стоило бы что-то сделать с этим, или обыграть положение и цвет треугольников.

Tray menu -> Advanced - Reset statistics

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55631&viewfull=1#post55631

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55302&viewfull=1#post55302

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55305&viewfull=1#post55305

Problem

OCSP check can time out. In this case AG makes an async check with an infinite timeout. The problem here is that until that check is finished AG counts cert valid.

Why?

OCSP servers are slow so revocation check can easily timed out.

What can we do?

1. Increase default OCSP check timeout
2. Use CRLSet just like Chrome does.

It is not very good solution though:
https://www.imperialviolet.org/2014/04/29/revocationagain.html
https://code.google.com/p/chromium/issues/detail?id=361820
https://www.grc.com/revocation/crlsets.htm
http://www.zdnet.com/article/chrome-does-certificate-revocation-better/

Try import file with windows-1251 encoding

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55272&viewfull=1#post55272

I see while selecting filters in the filters list u have enabled the select all features using CTRL+A, but atm this does nothing in the sense, that if u right click after selecting them all only the one u r focussed on gets selected ultimately, same is the case if after selecting all the filters u use the checkboxes to configure.

2. After deleting, when I proceed to 'Add Application' option, I noticed that it now gives you option of various executables to block ads. I chose Firefox(Stable version) and this time FF had a generic icon alongside it and not the Firefox specified icon.

http://forum.adguard.com/showthread.php?6048-Early-Access-Adguard-6-0-Alpha-Version&p=55303&viewfull=1#post55303