adguardteam / adguardformac Goto Github PK

AdguardTeam/AdguardForWindows#509

Review ID:
CR-AG-698

Just like here:
AdguardTeam/AdguardForWindows#591

Review ID: CR-AG-717

1. ChinaList+EasyList: http://sub.adtchrome.com/adt-chinalist-easylist.txt
2. CJX's Annoyance List: https://raw.githubusercontent.com/cjx82630/cjxlist/master/cjx-annoyance.txt

Original requester:
XQI-204-82994

If Adguard is set to proxy mode and does the filtering, the statistics in main UI are not updated. Count of blocked ads and trackers does not change.

The same as here:
AdguardTeam/AdguardForWindows#554

For now - suppress it.

http://www.kiboke-studio.hr/i-dont-care-about-cookies/

Self-explanatory.

The Mac needs some love here.

planeta.ru#$##page-head { background: white!important; } does not work, but planeta.ru#$#div[id="page-head"] { background: white!important; } works.

Look at how AdguardTeam/AdguardForWindows#502 was fixed

Already done in Windows version:
AdguardTeam/AdguardForWindows#322

Review ID:
CR-AG-691

http://forum.adguard.com/showthread.php?7528

Third-party request was blocked by rule

||traq.li^$third-party

https://ci3.googleusercontent.com/proxy/xInq9zlHUkhfo-01ET8UE7ihcifdb-iu0DRyXY4ZJWpuctOjhKX7neci2D5g0KSCz4WyN1Lp5QrftN6Qu8U5S-rw-Jc9j0x2aK8EB7TJIMGh87SN83ODi23M8FHfcyFOexkSCf1qYHujR6U7SNHIzSZUaJQ=s0-d-e1-ft#http://api.traq.li/url/image?url=http://go.publisher-news.com/AVDNinRDp3bAwNgUCMPL&w=500&h=300

Already done in Windows version:
AdguardTeam/AdguardForWindows#321

Review ID:
CR-AG-691

Browsers: Chrome, Safari
Authorization is set up using nginx

Config example:
https://rynop.wordpress.com/2012/11/26/howto-client-side-certificate-auth-with-nginx/

server {

        listen 0.0.0.0:443 ssl;

        ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
        ssl_certificate /etc/nginx/ssl/some_name.crt;
        ssl_certificate_key /etc/nginx/ssl/some_name.key;
        ssl_client_certificate /etc/nginx/ssl/ca_admins.crt;
        ssl_dhparam /etc/nginx/ssl/dhparams.pem;
        ssl_verify_client on;
        ssl_verify_depth 1;
        ssl_ciphers "EECDH+AESGCM:EDH+AESGCM:AES256+EECDH:AES256+EDH";
        ssl_prefer_server_ciphers on;
        ssl_session_cache shared:SSL:10m;
}

Server returns an error message:
400 no required ssl certificate was sent

AdguardTeam/AdguardForWindows#639

review ID: CR-AG-718

Source issue:
AdguardTeam/AdguardForWindows#691

Review ID:
CR-AG-724

Copy the one from Win version

Source:
AdguardTeam/AdguardForWindows#742

Review ID:
CR-AG-728

I don't yet have the logs and a clear way to reproduce this.

Source issue:
AdguardTeam/AdguardForWindows#701

Review ID:
CR-AG-725

https://adguard.com/en/filterrules.html#htmlFilterAdvancedAttributes

Review ID:
CR-AG-707

Source complaint
http://forums.macrumors.com/threads/the-el-capitan-safari-9-content-blocker-thread.1924936/page-7#post-22429683

AdguardTeam/AdguardForWindows#278

Code review for Windows version (look at how it's done):
CR-AG-690

Like it's done here:
AdguardTeam/AdguardForWindows#507

Look at review:
CR-AG-701

Also this:
CR-AG-702

There is a 300-400ms overhead, i don't get why.

Please try switching to simpler cipher.

Steps to reproduce:

1. Open google.com
2. Enter piwik
3. Click on first link

Expected result:

1. First request should be blocked, then the page should be loaded through main-document-white-list-cookie algorithm.

Real result:

1. Tab is closed automatically as if it was a $popup rule

http://www.ipvanish.com/software/

If 'automatically filter applications' option is checked in ADguard, IpVansih VPN does not connect, even though IPVanish is not listed in the filtered apps section. It connects fine if this option is disabled.

OS X El Capitan

RKL-474-61259

Please add two popular filters for blocking Chinese ads. Thanks!

CJX's Annoyance List
https://raw.githubusercontent.com/cjx82630/cjxlist/master/cjx-annoyance.txt

ChinaList+EasyList (Revised)
http://sub.adtchrome.com/adt-chinalist-easylist.txt

The issue I noticed with some HTTPS sites not working in Safari still happens. For example, it'll happen if I boot the Mac partition then start Safari and it'll attempt to load my homepage https://news.google.com/ and it'll end up giving off an error. It only happens the first time though when Safari is set to Google News as my homepage. Refreshing the page or opening Google News in a new tab works fine. It's just the first load when it does it.

We have three situations:

1. IPv6 address is not available (everything is ok)
2. IPv6 address is available AND IPv6 connectivity is ok (everything works good in this case)
3. IPv6 address is available AND IPv6 connectivity is NOT ok (that's our issue)

We should detect network change (for instance like it's done here http://stackoverflow.com/questions/11532144/how-to-detect-ip-address-change-on-osx-programmatically-in-c-or-c) and check IPv6 connectivity.

The same as here:
AdguardTeam/AdguardForWindows#566

Use new injection script.

Detailed description:
AdguardTeam/AdguardForAndroid#162

http://forum.adguard.com/showthread.php?8053-Unblock-Rapportive-Extension-for-Gmail

Extension is broken by Adguard.

The problem is in the wrong order of checks in ContentFilterRule.

Current implementation:

1. Attributes check
2. Check if content is empty (return NO if empty)
3. Check tag-content and wildcard

Proper implementation:

1. Attributes check
2. Check if tag-content and wildcard are empty. If so - return YES
3. Check if content is empty
4. Check tag-content and wildcard

Currently pressing the Del key doesn't do anything - whereas on the Windows version it'll delete filter(s).

The same as here:
AdguardTeam/AdguardForWindows#568

Check review:
CR-AG-703

Self-explanatory.

The Mac needs the protection Stealth Mode provides from pesky spies and the dreaded WebRTC protocol leaking your IP when using a VPN (I know, there's a filter rule for this, hehe).

I mean on the "howtodelete.html" page.

QMK-962-46146

The same as here:
AdguardTeam/AdguardForWindows#730

https://googleonlinesecurity.blogspot.com/2015/12/an-update-on-sha-1-certificates-in.html
https://blog.mozilla.org/security/2015/10/20/continuing-to-phase-out-sha-1-certificates/

TL;DR:
Do not filter SSL connection if a SHA-1 certificate is issued after January 1, 2016.
We should also add a code for step 2 also (stop accepting all SHA-1 certificates after January 1, 2017).

Read here for details (look at my comments in the end):
AdguardTeam/AdguardForWindows#458

Review ID: CR-AG-695

Source complaint:
http://forums.macrumors.com/threads/the-el-capitan-safari-9-content-blocker-thread.1924936/page-7#post-22431199

Video:
https://www.youtube.com/watch?v=x2b0hi5vZK8

This port is widely used by other software (mostly some server-side apps).
The proper solution is to use first open&available port.

I am not sure if it's possible in ObjC, but in Java when you create server socket, you can specify port=0 there. In this case app uses first available port.

If this string is in oneskyapp - don't forget to update every translation.

The same as here:
AdguardTeam/AdguardForWindows#614

Review: CR-AG-714

Source issue:
AdguardTeam/AdguardForWindows#421

The same is for Mac version.

Review ID:
CR-AG-692