Add userscripts support to Android version about adguardforandroid HOT 46 CLOSED

Hi guys

I'm back :-)

from adguardforandroid.

Ah, got it. Yeah, there will be a possibility to add custom userscripts by url, not just use some pre-defined.

from adguardforandroid.

@Nick-White of course you will:)

from adguardforandroid.

@ameshkov I agree w/ @Bluscream: @reek, as a maintainer of a (rather important ;) builtin list needs full access to wherever his list might be used, so ß license might useful to him across the platforms… unless @AdguardTeam would like to try to fix/workaround in-house. 😓

from adguardforandroid.

@ameshkov Still, #%#(function gives us a little something to play with in the user filters while waiting.

Any1 want to join me experimenting? The example I link to above is a rough-&-dirty implementation of #1436. It exhibits some JS injection to potentially block reading a hardware sensor. 🙇

The simplest userscript I'd like is the www.Amazon.com → smile.Amazon.com conversion, but, looking through the source of several addons/extensions, they involve window.location, tab.url, or chrome.webrequest. Whaddy'all think? Could these be converted successfully?

from adguardforandroid.

we might think about it after we finish Core Libs integration for all the platforms

from adguardforandroid.

Just to confirm, this will be userscripts subscription, not just static userscripts, right? Or both, just like user filters will be implemented?

from adguardforandroid.

This is good news, thank you!:)

from adguardforandroid.

Just a thought: Shouldn't this also allow us to do URL conversions of other types, e.g., http://www.Amazon.com/ → https://smile.Amazon.com/ or more advanced sorcery à la HTTPS Everywhere?

from adguardforandroid.

Hi, any good news about this very cool feature?

Good news is that we're in process of transition to the single cross-platform filtering engine (codename CoreLibs). AG for Android v2.10 is already partly transitioned, but there's a lot more to do. Once we finish with all the products transition, they will share common functionality.

Regarding the userscripts support, it's not enough to just execute a JS script as script hosts provide an API.

Off-topic: it becomes even more complicated given the changes in userscripts API brought by Greasemonkey 4: https://www.greasespot.net/2017/09/greasemonkey-4-for-script-authors.html
Basically, he decided to implement completely new API that is not backwards-compatible.

from adguardforandroid.

They're mostly Chrome extensions and not userscripts so direct conversion's not possible :(

from adguardforandroid.

@TPS something like that for instance?

amazon.com#%#if(window.location.host === 'amazon.com' || window.location.host === 'www.amazon.com') { window.location.host = 'smile.amazon.com'; }

Don't forget to enable HTTPS filtering on amazon.com

from adguardforandroid.

There needs to be a better way to find something here than scrolling and scrolling and scrolling

from adguardforandroid.

No, filter subscription is different thing, it will be covered in version 2.3.

from adguardforandroid.

Nono, I mean, like the filter subscriptions that will be covered in v2.3, I'm hoping the userscripts' enhancement will include userscripts subscriptions as well, not just static userscripts.

from adguardforandroid.

+1 I hope you will be able to specify custom userscripts from files too (not just public URLs) because I have tons of them.

from adguardforandroid.

I totally second this, would ♥ to see it soon :)

from adguardforandroid.

Mostly AAK and ads.fly bypasser and some other stuff like Github Dark Script and other userscript versions of userstyles to save my eyes when browsing the web from my tablet in my bed.

from adguardforandroid.

AAK looks abandoned, though.

from adguardforandroid.

It doesn't to me. Whenever i wrote a issue it was resolved within 3-4 days :)

from adguardforandroid.

@ameshkov @Bluscream @Reek's back, so this is as important as ever. 😃

from adguardforandroid.

2 more relatively popular projects that need this are https://github.com/adsbypasser/adsbypasser & https://github.com/handyuserscripts/antiadware.

from adguardforandroid.

Welcome back, friend! ☺

from adguardforandroid.

@ameshkov give this poor guy a beta license reek/anti-adblock-killer#1883 (comment) xP

from adguardforandroid.

Any news on this?

from adguardforandroid.

@Bluscream "this" which?

The main issue is milestoned for v4.0, so I don't expect anything on that front yet.

Though I'd like to know if @reek got his ß access yet. (He's 👍ed above, too, BTW.)

from adguardforandroid.

Though I'd like to know if @reek got his ß access yet. (He's 👍ed above, too, BTW.)

Not yet, but I am ready to provide it at any time. @reek if you need access to any AG premium product, just email me to am @ adguard.com

from adguardforandroid.

Another project that'd benefit from this is (based on AdguardTeam/AdguardForWindows#1609) @jspenguin2017's AdBlockProtector → https://gitlab.com/xuhaiyang1234/AAK-Cont, based on @reek's work, & consists of a blockscript & a filterset (which I request @AdguardTeam consider for inclusion).

Also, I forgot https://github.com/AdguardTeam/AdguardAssistant, of course! That's apparently build-scripts of some sort.… 🤦

from adguardforandroid.

@TPS Hi, thanks for the hard work of everyone here 😄
But unfortunately, we are currently dropping support of most proprietary softwares, step by step, except softwares from Google and Microsoft. My project may not stay as Userscript forever, or it may become an Userscript with custom extended API.

from adguardforandroid.

@jspenguin2017 Will filterset remain publicly accessible, @ least?

from adguardforandroid.

@TPS Everything will stay open source and publicly accessible, there is no worries about that 😄

from adguardforandroid.

Unrelated to AdBlockProtector, https://greasyfork.org/en/scripts/19993-ru-adlist-js-fixes/code (from gorhill/uBlock#2609 (comment)) seems like a fascinating thing to try, as well.

from adguardforandroid.

Just a thought: Shouldn't this also allow us to do URL conversions of other types, e.g., http://www.Amazon.com/ → https://smile.Amazon.com/ or more advanced sorcery à la HTTPS Everywhere?

@ameshkov Could #%#(function be used to effect this? Are there any docs about it &/or is this just straight (unsafe⁉️) JS?

from adguardforandroid.

Hi, any good news about this very cool feature?

from adguardforandroid.

Nothing so far sadly, but the UI rehaul had priority.

from adguardforandroid.

@ameshkov Could #%#(function be used to effect this? Are there any docs about it &/or is this just straight (unsafe⁉️) JS?

It is straight JS and that's why we limit those rules to AG filters only and not accept them from any third-party filters.

from adguardforandroid.

Ok, how about all these? They mostly use window.location.* & location.href.*. Some of these could possibly be converted? Would any of these rewrite any initial requests before loading a Non-Smile www.Amazon page?

from adguardforandroid.

@byaka the latest AdGuard for Android beta already supports custom userscripts, soon enough it'll be added to release version.

from adguardforandroid.

How far are we away from the 4.0? :'(

from adguardforandroid.

Pretty far:(

Btw, which exact userscripts do you want to have in Android?

from adguardforandroid.

@Bluscream I think that @ameshkov means that last commit was July 6, 2016. Even so, @ameshkov, this is fundamental for AAK's functionality.

Hey, @reek, are you still with us? 😟

from adguardforandroid.

какие новости?

from adguardforandroid.

yep, any news about this?

from adguardforandroid.

looks like you thinked and denied? maybe any comments?

from adguardforandroid.

@vbagirov ah, awesome, thx!

from adguardforandroid.

Guys, I'm so happy to get the version 3.2 this morning! This feature made my day! Thanks a lot to all of you ❤️

from adguardforandroid.