adfinis / ansible-role-icinga2_master Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 10.0 285 KB

This role is used to configure an icinga2 master

License: GNU General Public License v3.0

Shell 22.20% Jinja 77.80%

ansible ansible-galaxy ansible-role automation icinga2 infrastructure monitoring

ansible-role-icinga2_master's People

Contributors

Stargazers

Watchers

Forkers

breml kernt eni23 tongpu stdevel shurik-io aconitumnapellus ndgit flybyray michaelimfeld

ansible-role-icinga2_master's Issues

Feature: use a default variable for the recursive include directory

In several descriptions the default value for include_recursive in the icinga2 configuration will be overriden.
it is considered best practice to not mess with defaults from icinga package configuration files in the conf.d.

if you use a different custom directory the structure remains clean after an update. some backup or rpmnew files can be omitted by this practice. maintenance with tools like rpmconf will be easier.

https://github.com/adfinis-sygroup/ansible-role-icinga2_master/blob/4f9482a03b7eb6bfe867bf9e294d6f8890b4706d/templates/etc/icinga2/icinga2.conf.j2#L62

Make lsb_release a dependency

ISSUE TYPE

Bug Report

OS / ENVIRONMENT

Fresh Debian 11 setup

SUMMARY

If lsb_release isn't installed (which is not on Debian 11), the rolewill fail:

fatal: []: FAILED! => {"msg": "The conditional check '(ansible_lsb.id != 'Univention' or ansible_distribution_release != 'stretch')' failed. The error was: error while evaluating conditional ((ansible_lsb.id != 'Univention' or ansible_distribution_release != 'stretch')): 'dict object' has no attribute 'id'\n\nThe error appears to be in '/tmp/semaphore/.ansible/roles/adfinis-sygroup.icinga2_agent/tasks/installation.yml': line 38, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: configure icinga apt repository\n ^ here\n"}

STEPS TO REPRODUCE

Run role against Debian 11 Host

Move the zone and host configuration into a single file

ISSUE TYPE

Feature Idea

SUMMARY

Currently, runs for around 100 hosts take approximately 1 minute and 15 seconds. This change would remove one template and have both zone and host configuration in one file.

EXPECTED RESULTS

The runs should be faster. mitogen already helps but shorter runs are better.

Some important templates are missing

ISSUE TYPE

Bug Report

ANSIBLE VERSION

ansible 2.9.6
  config file = None
  configured module search path = ['/Users/christian/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/ansible
  executable location = /Library/Frameworks/Python.framework/Versions/3.8/bin/ansible
  python version = 3.8.2 (v3.8.2:7b3ab5921f, Feb 24 2020, 17:52:18) [Clang 6.0 (clang-600.0.57)]

CONFIGURATION

Vanilla Ansible 2.9 installation without modifications

OS / ENVIRONMENT

Apple macOS 10.15.3, but it also applies to other systems.

SUMMARY

There are several templates missing in templates.conf in comparison with the upstream templates.conf:

generic-host
generic-service
generic-user

STEPS TO REPRODUCE

Try to deploy Icinga2 using the example playbook on a Debian system:

- hosts: monitoring-master
  roles:
     - { role: adfinis-sygroup.icinga2_agent }
     - { role: adfinis-sygroup.icinga2_master }

EXPECTED RESULTS

Icinga2 master is installed and enabled.

ACTUAL RESULTS

Installing the configuration files fails due to missing templates:

RUNNING HANDLER [adfinis-sygroup.icinga2_master : icinga2_master reload icinga2] ****************************************************************************
fatal: [192.168.0.245]: FAILED! => {"changed": false, "msg": "Unable to reload service icinga2: Job for icinga2.service failed.\nSee \"systemctl status icinga2.service\" and \"journalctl -xe\" for details.\n"}

The status shows that the template generic-user is unknown:

[2020-04-05 11:12:39 +0100] critical/config: Error: Import references unknown template: 'generic-user'
Location: in /etc/icinga2/conf.d/users.conf: 13:3-13:23
/etc/icinga2/conf.d/users.conf(11):
/etc/icinga2/conf.d/users.conf(12): object User "admin" {
/etc/icinga2/conf.d/users.conf(13):   import "generic-user"
                                      ^^^^^^^^^^^^^^^^^^^^^

AnsibleUndefinedVariable: 'dict object' has no attribute 'monitoring_sat'

Applying this role with minimal mentioned variables, will result in the following failed task:

TASK [adfinis-sygroup.icinga2_master : create global zones configuration] ******
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'monitoring_sat'
fatal: [icinga2srv01]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'monitoring_sat'"}

reason is:
https://github.com/adfinis-sygroup/ansible-role-icinga2_master/blob/4f9482a03b7eb6bfe867bf9e294d6f8890b4706d/templates/etc/icinga2/zones.conf.j2#L36

fixing may include something of the follwing:

the template zones.conf.j2 should be more tolerant to missing groups
if special groups are required role documentation should have some notes

Support all icinga2 apply rule expressions

Support all icinga2 apply rule expressions in the groups.conf.j2 template.

ISSUE TYPE

Feature Idea

make the twilio API version configurable

check the twilio scripts

Configuration file owner/group incorrect for Debian-based systems

ISSUE TYPE

Bug Report

ANSIBLE VERSION

ansible 2.9.6
  config file = None
  configured module search path = ['/Users/christian/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/ansible
  executable location = /Library/Frameworks/Python.framework/Versions/3.8/bin/ansible
  python version = 3.8.2 (v3.8.2:7b3ab5921f, Feb 24 2020, 17:52:18) [Clang 6.0 (clang-600.0.57)]

CONFIGURATION

Vanilla Ansible 2.9 installation without modifications

OS / ENVIRONMENT

Apple macOS 10.15.3, but it also applies to other systems.

SUMMARY

Currently, the configuration file owner and group is always icinga which is correct for Red Hat-based systems. Anyhow, Debian-based systems name this user nagios for "historical reasons" - see also the official documentation: https://icinga.com/docs/icinga2/latest/doc/02-installation/#init-script

STEPS TO REPRODUCE

Try to deploy Icinga2 using the example playbook on a Debian system:

- hosts: monitoring-master
  roles:
     - { role: adfinis-sygroup.icinga2_agent }
     - { role: adfinis-sygroup.icinga2_master }

EXPECTED RESULTS

Icinga2 master is installed and enabled.

ACTUAL RESULTS

Installing the configuration files fails due to non-existent users and groups:

TASK [adfinis-sygroup.icinga2_master : install icinga2 configuration] ***************************************************************************************
fatal: [192.168.0.245]: FAILED! => {"changed": false, "checksum": "7952b01c49ff5f2250f3a3ded7458b522608500d", "gid": 116, "group": "icinga", "mode": "0640", "msg": "chown failed: failed to look up user icinga", "owner": "icinga", "path": "/etc/icinga2/icinga2.conf", "size": 1799, "state": "file", "uid": 111}
...

Why the ZoneName is the inventory_hostname per default for a icinga2 config master?

https://github.com/adfinis-sygroup/ansible-role-icinga2_master/blob/b71d39fabbeb6f03e6f83d585caa82f2a5aa2996/templates/etc/icinga2/constants.conf.j2#L30

Would it not be better to introduce a variable here which might be preinitilized with inventory_hostname but can be overriden?

compare and check with this default? Maybe it should just be this one:

https://github.com/adfinis-sygroup/ansible-role-icinga2_master/blob/5d601c5b15d0146c858fe2485beec97843409a12/defaults/main.yml#L4

Destination directory /etc/icinga2/zones.d/{{ icinga2_master_client_parent_zone }} does not exist

create all needed directories before

error:

TASK [adfinis-sygroup.icinga2_master : add our own host configuration] *********
failed: [icinga2srv01] (item=icinga2srv01) => {"ansible_loop_var": "item", "changed": false, "checksum": "20247d3d1fafa6dd4783b99d1687f904dfabba07", "item": "icinga2srv01", "msg": "Destination directory /etc/icinga2/zones.d/master does not exist"}

reasons:

Revert "Update mechanics to support satellites which are not directly reachable"

This Issue is to discuss reverting #51

I think this introduces too much complexity. I've created a PR with a simpler approach: #55

What are your opinions @Nyno-Kun @aconitumnapellus @eyenx

adfinis / ansible-role-icinga2_master Goto Github PK

ansible-role-icinga2_master's People

Contributors

Stargazers

Watchers

Forkers

ansible-role-icinga2_master's Issues

ISSUE TYPE

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

ISSUE TYPE

SUMMARY

EXPECTED RESULTS

ISSUE TYPE

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

ISSUE TYPE

ISSUE TYPE

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

Recommend Projects

Recommend Topics

Recommend Org