adaptlearning / adapt-contrib-mcq Goto Github PK

When a display text or pop-up is open it's still possible to scroll the page behind the pop-up, although the interactivity of elements is locked and the page is greyed out.

This is fine except that it is possible to 'close' or conceal the pop-up through scrolling, rendering it no longer possible to properly close the pop-up and restore the page to its original, interactive state.

Observed w/ Nexus 7, Chrome.

Radio implies only one option is possible. It would be more usable if radio would be served only for single choice options and checkbox for multi choice.

lines: 8, 9, 10, 70, 196, 225, 226

why: the gmcq component extends this component. gmcq uses the same logic but has different class names. shows mostly when resetting the component to its original state on revisit or viewing component state in page level progress menu.

From @shauncg on October 28, 2014 16:3

Every MCQ option is read once (I think as a string associated with the MCQ checkbox) and then again as a heading (for the text that a sighted user will read).

UPDATE: this is true of the MCQ on co-05, however the MCQ(s) on co-20 only read each answer option once.

Duplicate of: https://github.com/cgkineo/adapt-contrib-mcq/issues/4

I can tab to the close (x) button in Firefox when MCQ feedbacks are open, but the tabbing takes a long route around and tabs to page elements behind the feedback panel

@kirsty-hames

I've noticed that if you have multiple mcq components on one page things start to get a little bit funky:

• With two mcq components on the same block, (one left, one right), selecting the options on the right one, causes the one on the left to select. Also, the one on the right does not submit.
• As above but using two blocks, the behaviour is as above. Note that it also not possible to submit the second mcq.
• With two articles and blocks, and an mcq in each, submitting the second mcq disables the first.
• I have an article with two blocks, and two mcqs on each. If I go through the questions from top to bottom it works, if I do them from bottom to top, I don't get a chance to select all the items in the first question. Four should have been selectable but I can only select two.
  (@darylhedley, I spoke to @chris-steele about this and he asked me to assign it to you.)

properties.schema needs updating with new schema attributes. ariaLabel fields need adding to properties.schema.

Needed for framework v2.0 and authoring tool compatibility.

disabledAriaLabel in example.json is now redundant and can be removed

This is used by QuestionView, when only one item is selectable. See here:
https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/views/questionView.js#L52

As it stands this means unexpected 'final' feedback is given when the MCQ has more than one attempt and one answer..

bower.json must have the following attributes:

• displayName
• component

From @shauncg on June 20, 2014 12:27

After the MCQ is answered and the feedback text appears JAWS begins reading it. It gets as far as the second sentence, which it starts reading but then diverges:

"Scrolling is also a given when viewing content on a smartphone so a dialogue dun- button".

At this point the user can manually read through the remaining feedback text using the down cursor button (or similar) but it's unclear why JAWS stops and falters at the point it does.

See also #409 - JAWS falters in a similar way in the hotspot pop-up text.

Copied from original issue: adaptlearning/adapt_framework#413

item icon color styling for hover, selected and visited isn't set in mcq.less

How to replicate:

1- Click submit (nothing happens)
2- Click an option (you are unable to select)

focus highlight isn't visible on label after first item only on input.

This is to help the authoring tool determine layout styles for this component

"mcq" should be "Mcq" to match capitalisation convention found in other contrib components.

Feedback text in some popups currently displays:

[object Object]

E.g. in co-20 (b-55 MCQ; c-120 GMCQ)

Feedbacks should read something like:

This feedback will appear if you answered part of the question correctly.
Or:
This feedback will appear if you answered the question incorrectly.

Update this repo's readme with a standard format.

shouldn't lines 126 & 127:

this.$('label').removeClass('selected');
this.$('input').prop('checked', false);

be part of the function deselectAlItems?

items should be _items

• This is fired when interacting with the component
  Uncaught TypeError: Cannot read property '0' of undefined

In particular, this.model.get("selectedItems") is failing, but there may be others.

As per this post:
See https://community.adaptlearning.org/mod/forum/discuss.php?d=478

Regardless of whether partially correct scores should be rewarded as default, there looks to be an issue with the way the score is calculated. Why does it matter how many options there are when calculating this?

Would it be possible that if partly correct and incorrect feedbacks are both the same that _partlyCorrect feedback could be excluded and just use the _incorrect feedback for both of them?

When selecting the incorrect answer (in this case option 3), when changing to the model answer, the highlight shows up on the 2nd option.

Is there a reason why 9764c04 doesn't offer different feedbacks for multiple attempts like other feedback types?

From @shauncg on October 28, 2014 16:4

JAWS reads disabled Show Feedback buttons as if they were active.
N.b. this is true of other question types as well, not just MCQs.

Duplicate of issue: https://github.com/cgkineo/adapt-contrib-mcq/issues/3

Global to question components(?)

From @shauncg on October 28, 2014 16:18

Correct / incorrect marking is not read out in any way, so a blind user will have no idea of whether they were correct or not unless feedback is present.

This should be fine for questions throughout most courses, but for assessments / quizzes it may be a problem. If users get a final score then that helps, but for parity with sighted users is there any way of having JAWS announce whether an answer was correct or incorrect?

(This one could be really tricky to implement so it may just be a case of ensuring that all accessible courses definitely have either feedback / notify layers, or final scoring, for all question components.)

Duplicate of issue: https://github.com/cgkineo/adapt-contrib-mcq/issues/2

This is in setScore method

Logic error in this method. Doesn't factor in that an item not selected can count towards the number of correct answers

From @shauncg on June 20, 2014 15:54

Because no feedback pop-ups are used in the assessment JAWS doesn't have any way of interpreting the correct/incorrect marking, so visually impaired users will have no way of knowing if they were correct or not until they reach the end of the assessment and get their overall score and feedback.

Copied from original issue: adaptlearning/adapt_framework#422

Hi

I have built a course and have used the MCQ a few times. I have created a question with 2 correct answers and 2 attempts and this provides the correct feedback.

However I have also created a question with two attempts and only one correct answer, if you choose the wrong answer then the incorrect final feedback appears on the first go. It will then allow me to reset and attempt the question again but obviously this should be showing me the incorrect notfinal feedback first.

I have tested the question by increasing the number of correct answers to 2 and the feedback that should appear does appear. So it only seems to be an issue if you have multiple attempts and only one correct answer.

I've copied the code below:

{
"_id": "54db64562304c437586d2bdb",
"_parentId": "54db64342304c437586d2bda",
"_type": "component",
"_componentType": "54c265d4e024e9f113f872ce",
"_layout": "right",
"body": "

See for example the assessment: answer the MCQ, observe marking, go to menu then return to assessment. Notice marking not consistent. Cause of bug has been found to be a mistake in the hbs file: '_isCorrect' property should changed to 'correct' for item models. Branch and commit to follow.

N.B. issue duplicated adaptlearning/adapt_framework#335

Intermittent: sometimes I can't tab to the X (close) button in ie8 in MCQ feedbacks. It cycles around underneath the popup to select the page elements.

And there's a general tab focus, tab ordering and element selection issue here in ie8 with MCQ components.

@kirsty-hames

When I use the space bar for selecting MCQ options, it moves the whole page down instead of or in addition to selecting an option (radio button). I think this is related to #396 and #54?

@kirsty-hames