Subject of the issue

The a11y_alt_text helper tag syntax is being displayed instead of compiling the on screen text and hidden screen reader text.

Expected behaviour

Using the helper should produce display text with an alternative hidden screen reader version.

Similar issues were raised and resolved previously for other components. See Hotgraphic for reference.

Having issues where the select text turns into a light grey when disabled on IE8/9. After some research it looks like it's not possible to change that grey. This is causing issues where the text is very hard to read depending on the background colour of the select. Only way around it atm is for it to be styled with a white background colour on the browsers affected.

Recommendation https://www.w3.org/TR/wai-aria-practices-1.2/examples/combobox/combobox-select-only.html

• This needs to account for items that could not be correct

In the _items > _options attribute, "Mathing Options" should be "Matching Options":

With the last version, it was missed the style in the check icons problably because someone changed class naming.
Previosly the class was named
matching__select-state{
position: absolute;
top: 50%;
right: 1rem;
transform: translateY(-50%);
}
It could be now:
.matching-item {

&__select-container {
position: relative;
}

&__select-state {
position: absolute;
top: 15%;
right: 1rem;
transform: translateY(50%);
}
...

Thought it might have been a color issue but I'm pretty certain that no option is shown when then component is first rendered.

If you answer the question correctly, close the course and then relaunch it (refresh the page on scorm_test_harness.html) will mark the question as incorrect.

The selectOption function doesn't properly select the correct option in IE9. The fix is not to use attr, should be using prop. This is from jquery docs:

"To retrieve and change DOM properties such as the checked, selected, or disabled state of form elements, use the .prop() method."

The buttons element is inside the widget element when it should be outside it.

so you get some weird marking issues going on when the question is set to have more than 1 attempt

should be solved by adding the following to resetQuestion:

this.$(".matching-item").removeClass("correct").removeClass("incorrect");

Subject of the issue/enhancement/features

The globals need to be nested inside a _components object.

There appears to be a bug with matching when notifications are stacked up and then closed. This is currently not the behaviour of tutor, but for any extensions that expand on the Adapt.notify stack it may cause issues.

Replication of bug can be achieved by using the hack outlined below:

1. Make a change to tutor that forces multiple popups (i.e. add another notify.create(this.notifyOptions); below the original on line https://github.com/adaptlearning/adapt-contrib-tutor/blob/master/js/TutorNotify.js#L26, to force the same popup twice)
2. Create a course using matching and an assessment with this altered tutor
3. The first dropdown selection and submission gives assessment feedback and tutor feedback (if configured)
4. Reset the assessment
5. Dropdown options appear on click, but options do not disappear (on click/blur/escape etc)

On console debugging, I can see that the blur event is not been fired on the list items at all. Not sure why the page loses this.

Use monitorEvents($('.js-dropdown-list')[0], "control") in the console to confirm difference in before and after reset behaviour.

NB: Functionality is intact when tutor is removed

Redundant component setting

_shouldResetAllAnswers doesn't seem to do anything anymore?

Your environment

• version (AT/Framework) v0.10.5/v5.28.11

Steps to reproduce

• Create a Matching component using the Authoring Tool
• Set the attempts to 2 (or more)
• Uncheck the "Reset all answers?" option
• Answer some options incorrectly
• Reset question

Expected behaviour

The question should reset only the wrong answers.

Actual behaviour

All answers are reset

Screenshots (if you can)

When leaving the dropdown list, the blur even isn't being called. I was able to work around it by adding an additional event call after clicking the list item. Added to the this.$list.on even located on line 43 of the dropdown.js document.

Best guess is the original click even isn't firing changing the close property right and is creating a constant loop of setting the state to false and then back to true.

If anything, my solution is more of a fallback to ensure that the option is selected and the dropdown goes away as to not prevent progression.

Original requirement: https://community.adaptlearning.org/mod/forum/discuss.php?d=4080#p15019

Is it possible to add the ability to randomise the order of the Matching items as well as the Randomising of the answers?

Thanks

Caleb

The submit button is visible after the number of attempts has been exceeded, and the answer is incorrect.

Incorrect icon status is always displayed when:

• the component is completed
• _isEnabledOnRevisit is false
• you navigate away, then back

When you answer the question the question incorrectly, click on the correct answer button and then click on my answer button, you will notice that the answers that displayed are not the ones you answered.

See adaptlearning/adapt_framework#3078

Following similar inconsistent BEM naming in other plugins (Accordion / GMCQ), the Matching naming convention should be changed to follow suit.

e.g.

Current:
.matching_item
.matching__item-title

Proposed:
.matching-item
.matching-item__title

Subject of the issue

As per global question component issue adaptlearning/adapt-contrib-mcq#211.

Remove example placeholder text for ariaQuestion to prevent placeholder text being copied over and left in accessible courses.

ariaQuestion property description is noted in README and schema help/description for reference.

properties.schema needs updating with new schema attributes. ariaLabel fields need adding to properties.schema.

Needed for framework v2.0 and authoring tool compatibility.

disabledAriaLabel in example.json is now redundant and should be removed?

The text of a dropdown item can be selected, but unlike adaptlearning/adapt-contrib-mcq#192, doesn't prevent the click event. For consistency purposes it probably still makes sense to prevent text selection.

Would suggest the .u-no-select class is added to prevent text selection.

This is to help the authoring tool determine layout styles for this component

Currently when user does not select an option/options and clicks Submit, nothing happens. Better solution would be to give some hint - e.g. red border of text box or change the dropdown option colour to red.

Essentially adding a class to the dropdown would allow any bespoke customisation.

The ability to randomise question stems similar to the MCQ component via an _isRandom setting may be required

Subject of the issue/enhancement/features

Since adaptlearning/adapt-contrib-core#223, if the feedback title is empty, it no longer uses the component title as a fallback. The altTitle added in adaptlearning/adapt-contrib-core#201 is not included in the schemas or README.

The schemas, example.json and README need updating accordingly.

When the “Display Marking” toggle is switched off on the assessment, the correct/incorrect marking should not appear after the matching question has been answered.

The marking has not been applied correctly since this release Release v6.0.0 · adaptlearning/adapt-contrib-matching

I have taken a recording of the matching question working correctly in this release Release v5.0.0 · adaptlearning/adapt-contrib-matching

One of the LMS systems we are testing on is displaying an error for the matching question component

Your environment

Testing on Windows 10 Chromes PC

Steps to reproduce

Submit the answer to the matching question

Expected behaviour

I would not expect to get an error

Actual behaviour

An error appears saying "Incorrect Data Type"

Via dev tools the following:
16:40:50.462 ScormWrapper::setValue: _property=cmi.interactions.0.type _value=matching
16:40:50.557 ScormWrapper::setValue: _property=cmi.interactions.0.student_response _value=2.3,3.2,1.3
16:40:50.656 Unable to set cmi.interactions.0.student_response to: '2.3,3.2,1.3' Error: 405 - Incorrect Data Type LMS Error Info: For the 'cmi.interactions.0.student_response' data model element an incorrect value was submitted. Incorrect value: '2.3,3.2,1.3'.

Screenshots (if you can)

Block level elements fails the w3c validator when they are children of button or label elements.

Convert block level elements to inline to pass w3c validator checks.

In the below .json... the text attribute doesn't render html tags in the build.

"items": [
{
"text": "

Title

The ariaQuestion field needs to be added and normalized across all core question components.

Subject of the issue/enhancement/features

Tick and cross icons do not contain aria labels.

Relates to adaptlearning/adapt_framework#2241

Your environment

• Framework 5.22.3

Steps to reproduce

1. Complete a Matching component with a mix of correct and incorrect responses
2. Toggle between Show Correct Answer and Show My Answer

Expected behaviour

The tick and cross icons should have aria labels indicating if they represent correct or incorrect.

Actual behaviour

No aria labels

Remove _random attribute

Subject of the issue/enhancement/features

With _isRandom:true the zero-indexed item in each option is not restored correctly.

The issue is with the following line: https://github.com/adaptlearning/adapt-contrib-matching/blob/master/js/matchingView.js#L49 evaluating to null in the presence of _index:0

An example fix could be to change it to:
value: _.isFinite(selectedOption?._index) ? selectedOption._index : null

Subject of the issue/enhancement/features

Change _shouldShowMarking for _canShowMarking in matching.jsx template.
Now it looks like undefined and avoid to show the tick/cross next to the item.

Expected behaviour

True/false from config.

Actual behaviour

undefined

Subject of the issue/enhancement/features

Not a bug, but more housecleaning. Looking to ensure all icons in every template are uniform and set up with the same structure with the appropriate aria hidden label.

<span className="component-item__icon" aria-hidden="true">
  <span className="icon"></span>
</span>

OR

<span className="component-item__icon" aria-label="ARIA Description.">
  <span className="icon" aria-hidden="true"></span>
</span>

E.g. I was testing on co-20.

I answered the question incorrectly and pressed 'Reset' via tabbing. After closing the feedback panel the tab focus had shifted to the 'Slider type component' Submit button below.

@kirsty-hames

If you answer a question either partly correct or correct, on subsequent incorrect attempts it will still think you are partly correct due to this attribute not besing reset.