adamws / kle2netlist Goto Github PK

Some layouts will cause runtime error when attempting to use --controller-circuit option.
Example layout can be found here: adamws/keyboard-tools#11

/kicad/.local/lib/python3.10/site-packages/kle2netlist/skidl.py:376 in │
│ add_controller_circuit │
│ │
│ 373 │ for _, row in rows.items(): │
│ 374 │ │ row += uc[pins.pop(0)] │
│ 375 │ for _, column in columns.items(): │
│ ❱ 376 │ │ column += uc[pins.pop(0)] │
│ 377 │
│ 378 │
│ 379 def build_circuit(layout, **kwargs): │
IndexError: pop from empty list

Issue

Firstly, thank you so much for making this. It's amazing.
Forgive me if I am doing something incorrectly, my ultimate goal was to place a dip socket instead of the ATMEGA32U4AU. I have an STM32F411CEU6 board that I'd like to use to prototype a keyboard.

I take the default KLE json of "keycool 84":
https://pastebin.com/AiS5TqFj

And convert it to "internal form":
https://pastebin.com/HfpJhNSw

I then run (I just grabbed the tar from the github workflow build.yml for the switch symbols):
kle2netlist --layout keyboard-layout-converted.json --output-dir out --lib-path "/home/queso/src/kicad-symbols-v5"

In skidl.py, line 197 I run into a problem on the split of None:

        row, column = map(int, labels[0].split(","))

As you'll see in the internal form of the KLE json, the first element of labels is null in most cases:

{
  "keys": [
    {
      "color": "#cccccc",
      "labels": [
        null,
        null,
        null,
        "Esc"
      ],

If I change the line to:

        row, column = key['y'], key['x']

I think that might solve the issue? but I'm not sure as I'm not very familiar with the internal representation.

Other notes:

Do you know why .erc and .log files are created every time I run a file in the project?

I had to manually downgrade MarkupSafe==2.0.1 to fix issue:
ImportError: cannot import name 'soft_unicode' from 'markupsafe'
I think the poetry.lock file could be updated.

[package.dependencies]
MarkupSafe = ">=0.23"