adamniederer / ng2-mode Goto Github PK

ng2-mode EditorConfig does not follow EditorConfig properties

I'd love to have a feature like Tide's C-. for jumping to the definition of a symbol used in a template. It would also be lovely to be able to jump to a template/custom element definition from a template. Finally, it would be superb to do JS syntax checking in expressions used in templates.

Anyway, thanks for this tool.

Cool project! Is there a way to enable auto completion in templates?

It seems the current indentation level is set to 4. How do I set it to 2? Customize seems to show a default of 2, but I get a default of 4. I'm using prelude. Don't know if that makes any difference.

typescript-insert-and-indent does not seem to be called in ng2-ts-mode
I'm not sure this is the right way to correct,
but when I renamed ng2-ts-map to ng2-ts-mode-map, and deleted the (use-local-map ng2-ts-map) from
ng2-ts.el, then I get the "correct" behavior

Any reason the current list of decorators is hardcoded to a select few? There are way more decorators that come into everyday use, (@Injectable, @Input, @Output, @ContentChild, @ViewChild, etc).

Should this be based on a regex?

ng2-mode tide-mode does not display compile errors on save like typescript-mode tide-mode does

Problem

While following along with this tutorial ng2-ts mode seems to cause emacs to block and use 100% of the CPU. The code in question is from the "Error handling" section, specifically:

private handleError<T> (operation = 'operation', result?: T) {
  return (error: any): Observable<T> => {  // Typing the second > on this line causes the issue.
     // ...
  };
}

Environment

• MacOS 10.14.6
• iTerm2 Build 3.3.7
• Angular CLI: 8.3.20
• Node: 12.13.1
• Angular: 8.2.14
• Emacs 26.3

Emacs configuration

 ;; Angular/Typescript
 (use-package typescript-mode
    :ensure t)
 
 (use-package ng2-mode
    :ensure t
    :after typescript-mode)

Steps to reproduce

1. ng new repro Accept defaults.
2. cd repro
3. Launch emacs and open repro/src/app/app.module.ts
4. In the AppModule class, add the following block

getRepro() {
  return (): <T> => {
  }
}

5. Typing the second gt bracket (>) will reproduce the issue.

Misc.

• The issue does not happen with only typescript-mode enabled.
• Once the offending block of code is in the file, emacs will hang when attempting to open the file.
• Emacs does not recover. SIGKILL is the only option.

All the lines of the template are completely left justified.

Does this package integrate with Angular Language service? Or any plans to do so?
Thanks.

Code such as:

(f: (s) => boolean) => f

will cause ng2-mode's ng2-ts--highlight-lambda-args-fn to enter an infinite loop.

Initially I think this is due to ng2-ts--inside-lambda-args-p finding the first => and not the lambda's own =>

I am working on a patch and will post an update with it as soon as I can.

When using the common Angular convention of appending observable variables with a dollar sign (e.g. name$), ng2-html-goto-binding breaks with the error:
"Couldn't find name$"

I'm guessing that the dollar sign needs to be escaped to be treated as a regular character in the regexp?

Hello @AdamNiederer! Sorry for creating a post here, wasn't sure how I can reach you. I was wondering if you know what emacs theme was used in the screenshots? Much appreciated :)

I'm working in a project in which naming is different from what ng2 expects:

• home.component.ts
• home.template.html

It would be nice to have an option to configure it to specific needs