achhunna / client-revenue-schedule-t201610 Goto Github PK

https://github.com/achhunna/Tally/blob/master/tally-functions.php#L31
https://github.com/achhunna/Tally/blob/master/tally-functions.php#L64

let's make sure all variables are validated and passed in via wpdb's prepare statement to avoid any potential SQL injection issues down the road (less of an issue on L64, because that's a defined variable).

https://github.com/achhunna/Tally/blob/master/tally-functions.php#L15-L19

I'm wondering if we can't create more of a data structure for the purposes of defining tables.

We'll need to do strong type casting / validations. i.e. every input validated before being passed to an insert table helper function.

Maybe something like (pseudo code):

$tables = array(
  invoice_clients => array( 
       table=>acctg_invoice_clients,
       fields=> array(  acctg_invoice_clients_id => array( type=> int ), date_signed=>array(type=>date) ),
  client_transactions => array(
      table =>acctg_client_transactions,
      fields=> array(  acctg_client_transactions_id => array( type=> int ), date_of_transaction=>array(type=>date) ),

);

Then we can make helper functions to reference the tables and their attributes:

if( valid_input("invoice_clients","date_signed", $user_input_from_csv_or_UI ) )
  echo "it's valid input";