Comments (1)
This is an interesting one. You've made a very reasonable fix that I'm considering adopting. However, there's two considerations.
First, if I were to actually incorporate this change, there would need to be more edge cases to check. For example, your proposed sub-if would only catch those VCFs in which the INFO Header for SVLEN defined Number=.
. An equally valid definition is Number=1
, such that the entry.info["SVLEN"]
would not be in [list, tuple]
, so the last line size = abs(entry.info["SVLEN"])
would do the choking.
Second, I don't know for certain that SVLEN=.
is a valid tag and perhaps Truvari really should be choking on these entries. The VCF Format specification doesn't explicitly disallow a null SVLEN, but it does have a clear definition of what the value should be. A flaw in the format is that there are a lot of 'should' specifications, but very few enforced 'musts'.
I've often found that VCFs reported by some tools take liberties with the format's flexibility. Instead of trying to account for every edge case, Truvari expects a stricter adherence to the specification. I would suggest a VCF cleaning/qc step before using Truvari. For example, the SVLEN tag could be stripped with bcftools annotate -x INFO/SVLEN
, or a custom script could set it to the correct value.
from truvari.
Related Issues (20)
- Truvari refine fails when no regions to refine HOT 4
- TypeError, 'NoneType' and 'NoneType' HOT 2
- Duplication to Insertion doubt HOT 4
- Failure in pip installation HOT 2
- Question: Does truvari have a upper limit on the file size? How to speed up? HOT 2
- BED Region off-by-one error HOT 4
- Zero matches between base and comp HOT 4
- AttributeError: 'CollapsedCalls' object has no attribute 'consolidate' | version 4.2.1 HOT 4
- Calculate SNV HOT 7
- complex genotype problem HOT 3
- GT integrate HOT 1
- No TP or FP calls for CNV HOT 1
- merging different SV type? HOT 3
- No FP or TP calls HOT 2
- Unable to run MAFFT HOT 9
- md5sum FIPS issue HOT 1
- Support vector for intra-sample merge HOT 6
- some questions about the results in fp.vcf.gz
- some questions about the results in fp.vcf.gz HOT 1
- Getting same numbers of TP-base and TP-comp HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from truvari.