Giter Club home page Giter Club logo

Comments (1)

ACEnglish avatar ACEnglish commented on May 28, 2024

This is an interesting one. You've made a very reasonable fix that I'm considering adopting. However, there's two considerations.

First, if I were to actually incorporate this change, there would need to be more edge cases to check. For example, your proposed sub-if would only catch those VCFs in which the INFO Header for SVLEN defined Number=.. An equally valid definition is Number=1, such that the entry.info["SVLEN"] would not be in [list, tuple], so the last line size = abs(entry.info["SVLEN"]) would do the choking.

Second, I don't know for certain that SVLEN=. is a valid tag and perhaps Truvari really should be choking on these entries. The VCF Format specification doesn't explicitly disallow a null SVLEN, but it does have a clear definition of what the value should be. A flaw in the format is that there are a lot of 'should' specifications, but very few enforced 'musts'.
I've often found that VCFs reported by some tools take liberties with the format's flexibility. Instead of trying to account for every edge case, Truvari expects a stricter adherence to the specification. I would suggest a VCF cleaning/qc step before using Truvari. For example, the SVLEN tag could be stripped with bcftools annotate -x INFO/SVLEN, or a custom script could set it to the correct value.

from truvari.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.